MantisBT - Zandronum
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0001894Zandronum[All Projects] Bugpublic2014-07-21 01:352018-09-30 22:58
ReporterWaTaKiD 
Assigned ToDusk 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformMicrosoftOSWindowsOS VersionXP/Vista/7
Product Version2.0-beta 
Target Version2.0Fixed in Version2.0 
Summary0001894: hexen fighter fist desync online
Descriptionon the 3rd punch, the animation plays differently than offline, the fighter does not make the grunt sound, and the next swing or 2 dont actually connect
Steps To Reproducejoin hexen server
choose fighter
punch a monster 3 times
notice desync on 3rd punch

(i used 'summon dragon' as a punching bag)
Additional Informationive tested gzdoom 323/1.5.0/1.8.6 and zdoom 2.3.1/2.5.0/2.7.1 along with zandro 1.2.2 and 1.3-140703-1806 singleplayer and multiplayer, and this appears to happen only in zandro 2.0 online, in every build ive tested so far, latest being 140720-1542


'https://www.dropbox.com/s/4zhl8dz12qxu14x/2.0fighteroffline.mp4 [^]'

'https://www.dropbox.com/s/mqsaph4gde04c3x/2.0fighteronline.mp4 [^]'
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2014-07-21 01:35WaTaKiDNew Issue
2014-07-21 22:56DevilHunterNote Added: 0010031
2014-07-22 23:19DevilHunterNote Edited: 0010031bug_revision_view_page.php?bugnote_id=10031#r5388
2014-07-25 22:21ArcoStatusnew => confirmed
2014-12-31 11:30Torr SamahoNote Added: 0011149
2014-12-31 11:30Torr SamahoNote Edited: 0011149bug_revision_view_page.php?bugnote_id=11149#r6212
2014-12-31 11:31Torr SamahoStatusconfirmed => feedback
2014-12-31 14:46WaTaKiDNote Added: 0011155
2014-12-31 14:46WaTaKiDStatusfeedback => new
2014-12-31 15:47ArcoStatusnew => closed
2014-12-31 15:47ArcoResolutionopen => no change required
2015-01-23 07:10WaTaKiDNote Added: 0011511
2015-01-23 07:10WaTaKiDStatusclosed => feedback
2015-01-23 07:10WaTaKiDResolutionno change required => reopened
2015-01-23 10:26Edward-sanNote Added: 0011513
2015-01-23 11:05Edward-sanNote Edited: 0011513bug_revision_view_page.php?bugnote_id=11513#r6510
2015-01-23 11:11Edward-sanNote Edited: 0011513bug_revision_view_page.php?bugnote_id=11513#r6511
2015-01-23 11:12Edward-sanNote Edited: 0011513bug_revision_view_page.php?bugnote_id=11513#r6512
2015-02-15 21:08DuskTarget Version => 2.0
2015-02-22 11:25DuskAssigned To => Dusk
2015-02-22 11:25DuskStatusfeedback => assigned
2015-03-08 19:16cobaltStatusassigned => needs testing
2015-03-08 19:16cobaltSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=6723#r6723
2015-03-08 19:16cobaltAdditional Information Updatedbug_revision_view_page.php?rev_id=6725#r6725
2015-03-08 19:16cobaltNote Added: 0011784
2015-03-08 21:41WaTaKiDNote Added: 0011793
2015-03-09 04:50DuskStatusneeds testing => resolved
2015-03-09 04:50DuskFixed in Version => 2.0
2015-03-09 04:50DuskResolutionreopened => fixed
2018-09-30 22:58Blzut3Statusresolved => closed

Notes
(0010031)
DevilHunter   
2014-07-21 22:56   
(edited on: 2014-07-22 23:19)
I can confirm this. However, it seems that during the 3rd punch, it will be like I'm punching right though the Dragon, and cannot hit him anymore.

The only way to kill the loud ass dragon.. is to do kill monsters in Rcon.

EDIT: ok I feel stupid. The same happens for me. Backed a Dragon up to a piller, punched it a few times.. No Grunt after 3rd Punch, and some Punch's don't connect
(0011149)
Torr Samaho   
2014-12-31 11:30   
Works fine for me in the latest 2.0 version. Can somebody check whether this still happens in 2.0 (141231-1055 or newer)?
(0011155)
WaTaKiD   
2014-12-31 14:46   
no longer an issue for me as of 2.0-141231-1114
(0011511)
WaTaKiD   
2015-01-23 07:10   
after testing 2.0-r150119-2001, this issue came up again

i dont know when this was fixed before, but i think'https://bitbucket.org/Torr_Samaho/zandronum/commits/839cd8f167c83a702c1e6b46d8931d39d3a76d05 [^]' might be the recent cause for this issue
although when i tried to update and build this, it came out as 1.4 and the issue wasnt present, but when i updated and built'https://bitbucket.org/Torr_Samaho/zandronum/commits/2acec5d85c83aeede5a18581f2d5f4455956b86b [^]'
it came out as 2.0 and the issue was present, and doing cl_hitscandecalhack 0 fixes the issue
(0011513)
Edward-san   
2015-01-23 10:26   
(edited on: 2015-01-23 11:12)
It seems you need to find the revision which fixed the desync first.

[edit]Nevermind. This happens because since the mentioned change, clients could not set the victim parameter of P_LineAttack anymore, hence in A_FPunchAttack, linetarget, whose pointer is passed as argument of P_LineAttack, remains NULL and makes the clients skip the code referred later.
(0011784)
cobalt   
2015-03-08 19:16   
Issue addressed by commit a6ae75a6bd6d: - fixed: Baratus's punch attack would not set linetarget on the client, causing desyncs, due to the ZDoom upgrade interfering with 839cd8f. (fixes 1894)
Committed by Teemu Piippo [Dusk] on Saturday 28 February 2015 16:24:47

Changes in files:
 src/p_map.cpp | 3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)
(0011793)
WaTaKiD   
2015-03-08 21:41   
after testing with 2.0-r150308-2039, issue seems fixed