MantisBT - Zandronum
View Issue Details
0001823Zandronum[All Projects] Bugpublic2014-06-08 23:212018-09-30 22:38
Watermelon 
Watermelon 
normalminorN/A
closedfixed 
1.3 
1.3 
0001823: Installer perl script update
The script can be optimized in how it handles directories. I want to do this so when the win32 installer is needed, that can be done.
No tags attached.
Issue History
2014-06-08 23:21WatermelonNew Issue
2014-06-08 23:21WatermelonStatusnew => assigned
2014-06-08 23:21WatermelonAssigned To => Watermelon
2014-06-15 22:20WatermelonNote Added: 0009494
2014-06-15 22:20WatermelonAssigned ToWatermelon =>
2014-06-15 22:20WatermelonStatusassigned => needs review
2014-06-15 22:21WatermelonAssigned To => Watermelon
2014-06-15 22:21WatermelonStatusneeds review => assigned
2014-06-15 22:21WatermelonStatusassigned => needs review
2014-06-21 14:00Torr SamahoNote Added: 0009614
2014-06-21 14:00Torr SamahoNote Edited: 0009614
2014-06-21 14:01Torr SamahoNote Edited: 0009614bug_revision_view_page.php?bugnote_id=9614#r5090
2014-06-21 14:01Torr SamahoNote Revision Dropped: 9614: 0005088
2014-06-21 14:01Torr SamahoNote Revision Dropped: 9614: 0005089
2014-06-21 14:01Torr SamahoStatusneeds review => feedback
2014-06-22 22:08WatermelonNote Added: 0009684
2014-06-22 22:08WatermelonStatusfeedback => assigned
2014-06-22 22:09WatermelonStatusassigned => needs review
2014-06-22 22:09WatermelonNote Edited: 0009684bug_revision_view_page.php?bugnote_id=9684#r5141
2014-06-22 22:13WatermelonNote Edited: 0009684bug_revision_view_page.php?bugnote_id=9684#r5142
2014-06-22 22:20WatermelonNote Edited: 0009684bug_revision_view_page.php?bugnote_id=9684#r5143
2014-06-23 19:12Torr SamahoNote Added: 0009716
2014-06-23 19:14Torr SamahoStatusneeds review => feedback
2014-10-06 03:46WatermelonNote Added: 0010362
2014-10-06 03:46WatermelonStatusfeedback => assigned
2014-10-06 03:46WatermelonStatusassigned => resolved
2014-10-06 03:46WatermelonResolutionopen => fixed
2018-09-30 22:38Blzut3Statusresolved => closed

Notes
(0009494)
Watermelon   
2014-06-15 22:20   
'https://bitbucket.org/ChrisKOmg/zandronum-installer/commits/all [^]'

Are we fine with the installer using Perl to generate the file?

This makes it ULTRA easy to create installers between different versions. You just follow the instructions from the readme.txt and all is well.

Windows only.
(0009614)
Torr Samaho   
2014-06-21 14:00   
(edited on: 2014-06-21 14:01)
As long as it still works and allows us to conveniently I'm surely fine with using Perl. I did a quick test and your script seems to work nicely for me.

The readme.txt seems somewhat misleading to me though: It refers to the /files/ folder (which is a valid unix absolute path name, although a path one wouldn't want to use), but actually means the subfolder called "files".

Additional remarks for the readme:
- A convenient way to temporarily add a path to the PATH variable in a Windows shell is:
set PATH=%PATH%;d:\SPIELE\ZandroDev\installer\nsis\
Wouldn't hurt to have this in the readme.
- It would also be helpful if the readme mentioned which files are included in the current version. This information is still stored in legacy/zandronum_readme.txt.

(0009684)
Watermelon   
2014-06-22 22:08   
(edited on: 2014-06-22 22:20)
Added the above.

Since it worked for you, does this just go to 'resolved'?


ALSO:
'https://bitbucket.org/ChrisKOmg/zandronum-installer/commits/ee180b6a22cce24c6a12d8744f158818a0203638 [^]'

Since you made the 1.2.2 installer, if you wanted to add the files you put in, feel free.

(0009716)
Torr Samaho   
2014-06-23 19:12   
Yes, this is resolved.

Regarding the files, I used exactly the ones mentioned in legacy/zandronum_readme.txt. Can you copy and paste the list?
(0010362)
Watermelon   
2014-10-06 03:46   
Updated and in the repo.