MantisBT - Zandronum
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0001793Zandronum[All Projects] Suggestionpublic2014-05-04 02:052018-09-30 23:14
ReporterDusk 
Assigned ToDusk 
PrioritynormalSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOSOS Version
Product Version2.0-beta 
Target Version2.0Fixed in Version2.0 
Summary0001793: Conversion of sv_commands.cpp to NetCommand
Descriptionlast time on Zandronum Developer Network (cue theme music):

Quote from Dusk

As a collaboration between Water and I we're going through sv_commands.cpp right now and updating the server commands to NetCommand.


Quote from Dusk

It's done, I think. I tested it as well as I could, played some russian overkill against bots and ran some zpack and tested the manipulator function stuff more intricately. I can't really test it myself any better than that.


Quote from Torr Samaho

Thanks! That's definitely massive. I'll skim through the diff, make some local tests and then (assuming all goes well) pull it.


old pull request:'https://bitbucket.org/Torr_Samaho/zandronum/pull-request/34/dusk-watermelon-converted-all-server [^]' (warning, mega-lag page)
basically, stuff still needed to be done.
Steps To Reproduce
Additional Information
TagsNo tags attached.
Relationships
child of 0001777new Dusk Serverside demos 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2014-05-04 02:05DuskNew Issue
2014-05-04 02:05DuskStatusnew => assigned
2014-05-04 02:05DuskAssigned To => Dusk
2014-05-04 02:09DuskNote Added: 0008682
2014-05-04 02:09DuskStatusassigned => needs review
2014-05-04 02:16DuskRelationship addedparent of 0001777
2014-05-04 02:16DuskRelationship replacedchild of 0001777
2014-05-04 08:28Torr SamahoNote Added: 0008683
2014-05-04 08:31Torr SamahoStatusneeds review => feedback
2014-05-04 12:31DuskNote Added: 0008690
2014-05-04 12:31DuskStatusfeedback => assigned
2014-05-04 12:31DuskStatusassigned => needs review
2014-05-04 13:05Torr SamahoNote Added: 0008691
2014-05-04 13:34DuskStatusneeds review => needs testing
2014-07-09 02:05StrikerMan780Note Added: 0009913
2014-07-09 07:37Konar6Note Added: 0009915
2014-07-09 11:53StrikerMan780Note Added: 0009917
2014-07-09 20:38Torr SamahoNote Added: 0009922
2014-07-09 20:45StrikerMan780Note Added: 0009925
2014-07-09 20:45StrikerMan780Note Edited: 0009925bug_revision_view_page.php?bugnote_id=9925#r5308
2014-07-15 23:57ArcoNote Added: 0009976
2014-07-15 23:57ArcoStatusneeds testing => resolved
2014-07-15 23:57ArcoResolutionopen => fixed
2014-07-15 23:57ArcoProduct Version => 2.0-beta
2014-07-15 23:57ArcoFixed in Version => 2.0
2018-09-30 23:14Blzut3Statusresolved => closed

Notes
(0008682)
Dusk   
2014-05-04 02:09   
These commits should address the concerns mentioned in the initial bitbucket pull request
'https://bitbucket.org/CrimsonDusk/zandronum/commits/74654d7b33cc92baf0ea09454b55daa06dd295e8 [^]'
'https://bitbucket.org/CrimsonDusk/zandronum/commits/90aa9ea5f9b58516576168230efa35ed72247ec7 [^]'
(0008683)
Torr Samaho   
2014-05-04 08:28   
Great, I think that's much nicer than the manipulators!

I briefly went through the whole diff and only noticed minor things:
- SERVERCOMMANDS_SetPlayerStatus, SERVERCOMMANDS_UpdatePlayerPing and SERVERCOMMANDS_UpdatePlayerTime also lost their validity check.
- You added sendCommandToOneClient, but at some places you still added "command.sendCommandToClients ( ulClient, SVCF_ONLYTHISCLIENT )". I suggest to search for SVCF_ONLYTHISCLIENT and use sendCommandToOneClient where possible.

Other than that the patch looks fine (at least from a brief diff, the changes are way too massive to be read in full detail).
(0008690)
Dusk   
2014-05-04 12:31   
'https://bitbucket.org/CrimsonDusk/zandronum/commits/77199858b4be06c002765852041c96963869c13a [^]'
'https://bitbucket.org/CrimsonDusk/zandronum/commits/595cb981581c1e706fa513927e8d7cff2684b956 [^]'
'https://bitbucket.org/CrimsonDusk/zandronum/commits/dc00a1b8f2e1160b5897e233a35e6257097da6a0 [^]'
(0008691)
Torr Samaho   
2014-05-04 13:05   
Looks good!
(0009913)
StrikerMan780   
2014-07-09 02:05   
What specifically needs to be tested here?
(0009915)
Konar6   
2014-07-09 07:37   
I assume a normal client/server gameplay is to be thoroughly tested here, since the fundamental server-to-clients command sending system was modified.
(0009917)
StrikerMan780   
2014-07-09 11:53   
As in console commands, or sending/receiving data? (General Netcode)
(0009922)
Torr Samaho   
2014-07-09 20:38   
The general net code that handles sending information from the server to the clients.
(0009925)
StrikerMan780   
2014-07-09 20:45   
Alrighty. Sounds pretty cool. Gonna guess this really helps clean up/simplify the netcode? I'll see about hosting some games perhaps.
(0009976)
Arco   
2014-07-15 23:57   
I tested all the server commands available in v2.0 r140712-0929 and below and nothing seems broken.