MantisBT - Zandronum |
| View Issue Details |
|
| ID | Project | Category | View Status | Date Submitted | Last Update |
| 0001787 | Zandronum | [All Projects] Bug | public | 2014-04-22 21:40 | 2024-03-11 08:10 |
|
| Reporter | Klofkac | |
| Assigned To | Kaminsky | |
| Priority | normal | Severity | minor | Reproducibility | always |
| Status | resolved | Resolution | fixed | |
| Platform | | OS | | OS Version | |
| Product Version | 1.2 | |
| Target Version | 3.1 | Fixed in Version | 3.1 | |
|
| Summary | 0001787: Sector_SetColor not working in clientside scripting |
| Description | Not sure if this is bug or intended behaviour, but I am trying to create a "drugged" effect by doing sector_setcolor clientsidely on a player who activated certain trigger. It works offline as intended, but when connecting online it does nothing. I have ensured the script runs by printing a message.
Other graphical functions like ChangeFloor, ChangeCeiling, LightFade or SetLineTexture work. |
| Steps To Reproduce | Use the script below in a random map, then create a server, join a game and puke it.
You will see the sectors will not change their colours.
It will work offline, though. |
| Additional Information | #include "zcommon.acs"
script 1 (void) net clientside
{
int r,g,b;
switch(random(1,6))
{
case 1:
r = 255;g = 0;b = 0;
break;
case 2:
r = 0;g = 255;b = 0;
break;
case 3:
r = 0;g = 255;b = 255;
break;
case 4:
r = 255;g = 0;b = 255;
break;
case 5:
r = 255;g = 255;b = 0;
break;
case 6:
r = 127;g = 0;b = 255;
break;
}
Sector_SetColor(0,r,g,b);
delay(random(105,175));
restart;
} |
| Tags | No tags attached. |
| Relationships | |
| Attached Files |  sector_setcolor_clientside.zip (1,153) 2014-07-06 17:43
/tracker/file_download.php?file_id=1243&type=bug |
|
| Issue History |
| Date Modified | Username | Field | Change |
| 2014-04-22 21:40 | Klofkac | New Issue | |
| 2014-06-15 16:19 | Watermelon | Note Added: 0009446 | |
| 2014-06-15 16:19 | Watermelon | Status | new => feedback |
| 2014-06-15 17:53 | Klofkac | Note Added: 0009472 | |
| 2014-06-15 17:53 | Klofkac | Status | feedback => new |
| 2014-06-15 22:08 | Watermelon | Note Added: 0009489 | |
| 2014-06-15 22:08 | Watermelon | Status | new => needs review |
| 2014-06-21 14:13 | Torr Samaho | Note Added: 0009615 | |
| 2014-06-21 14:14 | Torr Samaho | Note Edited: 0009615 | bug_revision_view_page.php?bugnote_id=9615#r5092 |
| 2014-06-21 14:14 | Torr Samaho | Note Revision Dropped: 9615: 0005091 | |
| 2014-06-21 14:14 | Torr Samaho | Assigned To | => Torr Samaho |
| 2014-06-21 14:14 | Torr Samaho | Status | needs review => assigned |
| 2014-06-21 14:14 | Torr Samaho | Status | assigned => feedback |
| 2014-07-05 10:20 | Torr Samaho | Note Added: 0009844 | |
| 2014-07-05 20:05 | Torr Samaho | Product Version | 2.0-beta => 1.2 |
| 2014-07-06 02:51 | Catastrophe | Note Added: 0009869 | |
| 2014-07-06 07:53 | Torr Samaho | Note Added: 0009875 | |
| 2014-07-06 17:43 | Dusk | File Added: sector_setcolor_clientside.zip | |
| 2014-07-06 17:44 | Dusk | Note Added: 0009881 | |
| 2014-07-06 17:44 | Dusk | Status | feedback => assigned |
| 2014-07-06 17:48 | Dusk | Note Edited: 0009881 | bug_revision_view_page.php?bugnote_id=9881#r5283 |
| 2014-07-07 06:09 | Torr Samaho | Note Added: 0009883 | |
| 2014-07-07 06:10 | Torr Samaho | Note Edited: 0009883 | bug_revision_view_page.php?bugnote_id=9883#r5287 |
| 2014-07-07 06:10 | Torr Samaho | Note Revision Dropped: 9883: 0005286 | |
| 2014-07-07 07:02 | Catastrophe | Note Added: 0009884 | |
| 2014-07-07 09:33 | Dusk | Note Added: 0009886 | |
| 2014-07-07 17:02 | Torr Samaho | Note Added: 0009887 | |
| 2021-07-26 12:45 | Kaminsky | Note Added: 0021639 | |
| 2021-07-26 12:45 | Kaminsky | Assigned To | Torr Samaho => Kaminsky |
| 2021-07-26 12:45 | Kaminsky | Status | assigned => needs testing |
| 2021-07-26 12:47 | Kaminsky | Target Version | => 3.1 |
| 2024-03-11 08:10 | unknownna | Note Added: 0023351 | |
| 2024-03-11 08:10 | unknownna | Status | needs testing => resolved |
| 2024-03-11 08:10 | unknownna | Resolution | open => fixed |
| 2024-03-11 08:10 | unknownna | Fixed in Version | => 3.1 |
|
Notes |
|
|
|
|
Is this supposed to be used clientside? |
|
|
|
|
I don't see a problem why it should not. It's purely graphical function and using it clientsidely would create some interesting effects, like:
- Changing certain sector colours depending on which team player is at
- Making a single player with "weak vision", where just for the players some sectors are darkened
- The above mentioned drugged effect
- Make the map look slightly different for each player
- And so on...
The other graphical functions work, for example changing sector brightness, setting the textures, etc.
Making these (not just) graphical changes clientsidely just to desired ConsolePlayer is the power of clientside scripting without which some effects would not be possible at all. There are actually some mods around which benefit from it. |
|
|
|
|
|
Requiring comment on if they're okay with this being added and/or fixed |
|
|
|
(0009615)
|
|
Torr Samaho
|
2014-06-21 14:13
(edited on: 2014-06-21 14:14) |
|
CLIENTSIDE scripts are not really intended to desynchronize sector properties, but since this is a purely visual effect, we can just go ahead and do so.
The fix is trivial. We only have to change
sectors[secnum].SetColor(arg1, arg2, arg3, arg4, false);
to
sectors[secnum].SetColor(arg1, arg2, arg3, arg4, false, true);
in FUNC(LS_Sector_SetColor). If you post a minimal example wad, I'll fix this.
|
|
|
|
|
|
No minimal example wad in sight after about two weeks of waiting. If nobody posts a minimal example wad soon, I'll close this ticket. |
|
|
|
|
|
I'll make one, so a wad doing sector_setcolor on a clientside script correct? |
|
|
|
|
|
|
|
(0009881)
|
|
Dusk
|
2014-07-06 17:44
(edited on: 2014-07-06 17:48) |
|
compiled the ACS posted in the description into an example WAD.
yay automation
|
|
|
|
(0009883)
|
|
Torr Samaho
|
2014-07-07 06:09
(edited on: 2014-07-07 06:10) |
|
Unfortunately, without a map with properly tagged sectors, the wad with just the script is not of much use: I didn't see any effects when just running the example wad with Doom2 map01.
|
|
|
|
|
|
Strange, using sector_setcolor with 0 as a tag should be working on all sectors tagged as 0, I've done it before. |
|
|
|
(0009886)
|
|
Dusk
|
|
2014-07-07 09:33
|
|
|
Works fine for me offline when using it on map01... |
|
|
|
|
Weird. When I start Zandronum 1.2.2 under Windows with
zandronum.exe -file sector_setcolor_clientside.zip +map map01
I don't experience any sector color changes. |
|
|
|
|
|
Sector_SetColor (as well as Sector_SetFade) now work, and only work, inside CLIENTSIDE ACS scripts in 3.1. A client cannot execute these specials if they're called from outside an ACS script, like on a line or an actor. |
|
|
|
|
Quote from Torr Samaho
I don't experience any sector color changes.
It seems that one has to manually puke script 1 in the console.
Anyway, the example wad works online in 3.1 now. Great job, Kaminsky! |
|