MantisBT - Zandronum
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0001676Zandronum[All Projects] Suggestionpublic2014-01-19 11:172022-10-15 20:41
ReporterKlofkac 
Assigned To 
PrioritynormalSeveritytweakReproducibilityN/A
StatusclosedResolutionno change required 
PlatformOSOS Version
Product Version 
Target VersionFixed in Version 
Summary0001676: Make kick votes use player ID rather than player's name
DescriptionThere is a callvote kick issue when two or more players are using same name. It will always kick the player with the lowest player ID.
Example is when a troll joins server later, thus gets higher ID, and changes name to someone else's. Then players decide to callvote kick the troll out of the server, but the vote kicks the real player instead and troll has been fed.
Changing the callvote kick behaviour to use player's ID instead of name would prevent these conflicts.
Steps To Reproduce
Additional InformationIn the kick voting menu there could also be shown player's ID in parentheses beside their name for information purposes.
TagsNo tags attached.
Relationships
related to 0000144closed Torr Samaho Disallow duplicate names (use pseudo-aliases such as Player2, Player3, etc) 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2014-01-19 11:17KlofkacNew Issue
2014-01-19 11:44DuskNote Added: 0008083
2014-01-19 12:09KlofkacNote Added: 0008085
2014-01-19 12:42DuskNote Added: 0008086
2014-01-19 12:42DuskNote Edited: 0008086bug_revision_view_page.php?bugnote_id=8086#r4438
2014-01-19 12:54WirtualnoscNote Added: 0008087
2014-01-19 13:16HexaDokenNote Added: 0008088
2014-01-19 13:29LeonardNote Added: 0008089
2014-01-19 13:42KlofkacNote Added: 0008090
2014-01-19 13:48KlofkacNote Edited: 0008090bug_revision_view_page.php?bugnote_id=8090#r4440
2014-01-19 14:37LeonardNote Added: 0008091
2014-01-19 15:02FritsNote Added: 0008092
2014-01-19 15:04FritsNote Edited: 0008092bug_revision_view_page.php?bugnote_id=8092#r4442
2014-01-19 15:17MatiNote Added: 0008094
2014-01-19 15:18KlofkacNote Added: 0008095
2014-01-19 15:20KlofkacNote Edited: 0008095bug_revision_view_page.php?bugnote_id=8095#r4444
2014-01-19 15:39LeonardNote Added: 0008097
2014-01-19 16:01ZzZomboNote Added: 0008099
2014-01-19 16:37Torr SamahoNote Added: 0008100
2014-01-19 17:30DuskNote Added: 0008103
2014-03-07 06:01Dark-AssassinNote Added: 0008349
2014-06-15 15:55WatermelonStatusnew => acknowledged
2022-10-15 20:40WaTaKiDNote Added: 0022463
2022-10-15 20:41WaTaKiDRelationship addedrelated to 0000144
2022-10-15 20:41WaTaKiDStatusacknowledged => closed
2022-10-15 20:41WaTaKiDResolutionopen => no change required

Notes
(0008083)
Dusk   
2014-01-19 11:44   
I think the proper solution would be to simply prevent multiple people from using the same name.
(0008085)
Klofkac   
2014-01-19 12:09   
But what if a troll comes first with name of someone else and then it would not let the real player join later? And, what about the default name "Player"? I once have seen 4 "Player"s in one server, in other case there were 5 "Player"s but every "Player" had different colour.
I think preventing same names was discussed before but scrapped.

The votekicking also ignores the player's colour scheme of name so there could just be 2 people with different colours but the one with lower ID would be kicked again. Forgot to add this information earlier.
(0008086)
Dusk   
2014-01-19 12:42   
Maybe conficts could be resolved by appending a number after the player name if the conflict happens on connect? First player would be "Player", second one "Player (2)", third one "Player (3)"?
(0008087)
Wirtualnosc   
2014-01-19 12:54   
What about players with long names? My own nickname including colours gets close to limit, so that wouldn't help me at all, for example. Besides, I prefer Klofkac's method myself than the one of preventing duplicate nicknames from happening, although that's mostly my personal preference (I have nothing against duplicate nicknames themselves sooo...).
(0008088)
HexaDoken   
2014-01-19 13:16   
Players with ridiculously long names are highly unlikely to get nickname duplications unless intentional. In which case you call admins and issue a masterban for nickname stealing attempt.

Also, kicking by ID doesn't really help the issue at all. We have two players with same nicknames. Woe, for we also have their different IDs! But alas, for we still have no idea which of them is genuine and which of them is troll. Before you say "its the one who joined first/last", I don't feel like closely watching the join order all the time, nor am I on server 24/7, and if I remember correctly the player who joins latest does not always get the highest ID.

I'm with Dusk here. Do not allow identical nicknames, resolve nickname conflicts by appending a number or something upon connect. It's very annoying anyway to have like 6 "Players" on the server and have no idea who the hell is who.
(0008089)
Leonard   
2014-01-19 13:29   
I agree, numbers should definitely be used.
(0008090)
Klofkac   
2014-01-19 13:42   
(edited on: 2014-01-19 13:48)
Still, using kick vote for ID is better, because the name kickvoting ignores colours, which can again lead to miskick, and callvoting kick from console would be easier - I prefer using ignore_idx instead of ignore, because extremely long names with special symbols could be pain to rewrite in console, whereas ID is just a number you can check from playerinfo.
I think there should be another ticket about restricting the names in server, this is a ticket about call vote issue after all.
(0008091)
Leonard   
2014-01-19 14:37   
Or you could just use the multiplayer menu which is much easier to kick with..
(0008092)
Frits   
2014-01-19 15:02   
(edited on: 2014-01-19 15:04)
With kpatch I don't usually have problems with aliasing because playerinfo also reveals the location of that player.

Leonard: Multiplayer menu isn't an option if they both have the same name.

Also join order isn't a good way of knowing someone's id. For example if there are 3 players and the player with id:1 leaves, a newly connected client will take that id.
(0008094)
Mati   
2014-01-19 15:17   
The problem is on some servers without any moderation or BestEver where current server hoster might be away, in cases of multiple nicks you are quite in trouble of kicking your friend instead of trouble causer. Kicking through player ID would not only make things easier but would also be quite helpful in cases like that. In other words, it would be very good if we, normal players, had such feature at our disposal.
(0008095)
Klofkac   
2014-01-19 15:18   
(edited on: 2014-01-19 15:20)
About using multiplayer menu, it can be too slow to find the name in a list by pressing left/right keys before something happens, and some players prefer to use console instead of menu due to its potential speed (you can autocomplete commands).
Also, there is that annoyance in menu that when someone disconnects in split second before confirming the kick, the list shifts to right to fill in the gap and I end up in votekicking someone else. Then I have to wait another 10 minutes and feel the embarrassement from it. Forgot to tell this before too.
(0008097)
Leonard   
2014-01-19 15:39   
Frits I was talking to klofkac also the menu might be faster in the case of long names like you mentioned
(0008099)
ZzZombo   
2014-01-19 16:01   
Source engine solves the problem w/ nicknames by renaming in the following pattern: "(1) Player" so long names will be still different. It also discourages wearing the same nickname I believe.
(0008100)
Torr Samaho   
2014-01-19 16:37   
Quote from Dusk
I think the proper solution would be to simply prevent multiple people from using the same name.

Wirtualnosc has a good point here. If the name is too long, would one just erase the end of the name to make room for a number?
Quote from Frits
With kpatch I don't usually have problems with aliasing because playerinfo also reveals the location of that player.

Since 1.1, Zandronum itself does this too. You just need to use GeoIP.
(0008103)
Dusk   
2014-01-19 17:30   
Quote
Wirtualnosc has a good point here. If the name is too long, would one just erase the end of the name to make room for a number?

I guess that's the only way to handle such a case.

I still firmly stand that kickvoting by index is not necessary and a regular player shouldn't need to mess their heads with indices. What is wanted here is a way to tell two players with the same nickname apart and the only solution that does not result in players needing to mess with indices I see is making them not have the same nickname.

Do note that I think that different colors is not different enough here.
(0008349)
Dark-Assassin   
2014-03-07 06:01   
Back in the Skulltag ear, I did make a suggestion to disallow similar/same names, though unfortunately, nothing was done about it.

Also, if something does get done to disallow similar/same names, have the checks strip the colour completely.
(0022463)
WaTaKiD   
2022-10-15 20:40   
since duplicate player names are no longer allowed as per 0000144 , and thus one cannot confuse who is being picked for a vote, ill close this ticket