MantisBT - Zandronum
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0001647Zandronum[All Projects] Bugpublic2014-01-07 03:382018-09-30 22:41
Reportertrayness 
Assigned ToDusk 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformMicrosoftOSWindowsOS VersionXP/Vista/7
Product Version1.2 
Target Version1.3Fixed in Version 
Summary0001647: Strange Line_SetBlocking behavior when using BLOCKF_EVERYTHING online
DescriptionWhen you use the Line_SetBlocking function to clear the BLOCKF_EVERYTHING flag on a line (that's already set to block everything) while online, the line will continue to block railgun shots and grenades; as far as I'm aware, everything else (rockets, normal hitscan attacks, etc.) passes through just fine.

Something similar happens when the line is set to block nothing by default and you try to use Line_SetBlocking to set the blockf_everything flag; the line will not block railgun shots or grenades, but it will block everything else.

This does not happen offline. This does happen in the latest developmental build.
Steps To Reproduce1) Start up a server using the attached WAD file and go to Map01.
2) Hit the switch to activate the script that clears the BLOCKF_EVERYTHING flag from the line.
3) Now try shooting the line with the grenade launcher and the railgun. Neither grenades nor railgun shots will pass through. Everything else will.

Additional InformationPerhaps related: When you run over the line after Line_SetBlocking has been used to clear the BLOCKF_EVERYTHING flag, it will allow you to pass through, but you'll experience noticeable lag.

SetLineBlocking works just fine.
TagsNo tags attached.
Relationships
Attached Files? line_setblocking_test.wad (3,229) 2014-01-07 03:38
/tracker/file_download.php?file_id=1140&type=bug
diff line_setblocking_fix.diff (473) 2014-01-10 07:16
/tracker/file_download.php?file_id=1143&type=bug
Issue History
Date ModifiedUsernameFieldChange
2014-01-07 03:38traynessNew Issue
2014-01-07 03:38traynessFile Added: line_setblocking_test.wad
2014-01-10 07:15DuskNote Added: 0007936
2014-01-10 07:15DuskAssigned To => Dusk
2014-01-10 07:15DuskStatusnew => confirmed
2014-01-10 07:15DuskStatusconfirmed => needs testing
2014-01-10 07:15DuskStatusneeds testing => needs review
2014-01-10 07:16DuskFile Added: line_setblocking_fix.diff
2014-01-11 11:59Torr SamahoNote Added: 0007949
2014-01-11 12:00Torr SamahoStatusneeds review => feedback
2014-01-11 12:00Torr SamahoNote Edited: 0007949bug_revision_view_page.php?bugnote_id=7949#r4394
2014-01-11 12:01Torr SamahoNote Revision Dropped: 7949: 0004393
2014-06-08 16:45DuskNote Added: 0008926
2014-06-08 16:45DuskStatusfeedback => needs review
2014-06-08 19:21Torr SamahoNote Added: 0008933
2014-06-08 19:21Torr SamahoStatusneeds review => needs testing
2014-06-08 19:22Torr SamahoTarget Version => 1.3
2014-06-08 22:19ArcoNote Added: 0008940
2014-06-08 22:19ArcoStatusneeds testing => resolved
2014-06-08 22:19ArcoResolutionopen => fixed
2018-09-30 22:41Blzut3Statusresolved => closed

Notes
(0007936)
Dusk   
2014-01-10 07:15   
classic case of a simple desync - Line_SetBlocking doesn't update the line flags on the client. if you spawn an imp on the other side of the structure you can kill it with the railgun/grenade launcher even though the grenades appear to bounce away.
(0007949)
Torr Samaho   
2014-01-11 11:59   
(edited on: 2014-01-11 12:00)
The patch looks good. If you create a pull request that also includes a history entry, I'll pull it.
(0008926)
Dusk   
2014-06-08 16:45   
'https://bitbucket.org/Torr_Samaho/zandronum-stable/pull-request/47/fixed-line_setblocking-online [^]'
(0008933)
Torr Samaho   
2014-06-08 19:21   
Transplanted.
(0008940)
Arco   
2014-06-08 22:19   
Works correctly in r140608-2119.