MantisBT - Zandronum
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0001642Zandronum[All Projects] Bugpublic2014-01-05 17:322018-09-30 23:00
ReporterTorr Samaho 
Assigned ToBlzut3 
PrioritylowSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOSOS Version
Product Version2.0-beta 
Target Version2.0Fixed in Version2.0 
Summary0001642: SBARINFO's gamemode detection is confusing
DescriptionPreviously: Backwards compatibility broken.

Samsara 0.3 demonstrated confusion in regards to teamgame being team deathmatch (ZDoom keyword). There is currently no way to detect a custom team game, but more importantly the interface should probably reworked to detect features of the game mode and not the game modes themselves.
Steps To Reproduce
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2014-01-05 17:32Torr SamahoNew Issue
2014-01-05 17:34Torr SamahoNote Added: 0007891
2014-01-05 17:34Torr SamahoAssigned To => Blzut3
2014-01-05 17:34Torr SamahoStatusnew => assigned
2014-01-05 17:34Torr SamahoProduct Version => 2.0-beta
2014-01-05 17:34Torr SamahoTarget Version => 2.0
2014-01-05 17:35Torr SamahoNote Edited: 0007891
2014-01-07 20:16Torr SamahoNote Added: 0007913
2014-01-07 20:16Torr SamahoNote Deleted: 0007891
2014-01-07 20:17Torr SamahoView Statusprivate => public
2014-01-07 20:17Torr SamahoNote Edited: 0007913bug_revision_view_page.php?bugnote_id=7913#r4382
2014-01-07 20:17Torr SamahoNote Revision Dropped: 7913: 0004381
2014-01-07 20:17Torr SamahoNote Revision Dropped: 7891: 0004364
2014-01-07 20:17Torr SamahoNote Revision Dropped: 7891: 0004365
2014-01-07 21:15Blzut3Note Added: 0007915
2014-01-08 07:09Torr SamahoNote Added: 0007917
2014-01-08 11:16DuskNote Added: 0007918
2014-01-08 18:06Torr SamahoNote Added: 0007919
2014-01-08 19:09DuskNote Added: 0007920
2014-01-08 21:21Torr SamahoNote Added: 0007921
2014-01-08 21:30Blzut3Note Added: 0007922
2014-01-08 21:55Torr SamahoNote Added: 0007923
2014-01-14 20:14DuskRelationship addedchild of 0001604
2014-01-14 20:15DuskRelationship deletedchild of 0001604
2014-11-28 18:29Blzut3SummaryZDoom 2.5.0's SBARINFO parser is not backwards compatible with the one from Zandronum 1.2 => SBARINFO's gamemode detection is confusing
2014-11-28 18:29Blzut3Description Updatedbug_revision_view_page.php?rev_id=6049#r6049
2014-11-28 18:30Blzut3Note Added: 0010990
2014-11-29 02:45Blzut3Priorityhigh => low
2014-11-29 02:45Blzut3Severitymajor => minor
2015-01-03 15:20Torr SamahoNote Added: 0011240
2015-01-06 02:07Blzut3Note Added: 0011311
2015-01-06 02:07Blzut3Statusassigned => needs testing
2015-03-29 20:20DuskStatusneeds testing => resolved
2015-03-29 20:20DuskFixed in Version => 2.0
2015-03-29 20:20DuskResolutionopen => fixed
2018-09-30 23:00Blzut3Statusresolved => closed

Notes
(0007913)
Torr Samaho   
2014-01-07 20:16   
(edited on: 2014-01-07 20:17)
After I backported Blzut3 ZDoom fix for this, Samsara 0.3 does work, but I get the warning: "Ignoring unknown gamemode Teamplay". I had a quick look at the SBARINFO code and it seems that "Teamplay" was never a valid gamemode for SBARINFO, even though the gamemode GAMEMODE_TEAMPLAY (aka team dm) exists.
(0007915)
Blzut3   
2014-01-07 21:15   
Team DM is detectable through "TeamGame" since it's a ZDoom game mode and for some reason that's the identifier I picked for it.

It's our custom team game mode that seems to be missing.
(0007917)
Torr Samaho   
2014-01-08 07:09   
I see. That's rather confusing if you look at our CVAR names. Do you have a suggestion to resolve this?
(0007918)
Dusk   
2014-01-08 11:16   
Make a TeamDeathmatch alias for it, use CustomTeamGame for our teamgames and print a warning if TeamGame is used?
(0007919)
Torr Samaho   
2014-01-08 18:06   
In this case, code that is perfectly fine in ZDoom would generate a warning in Zandronum and it would be impossible to fix the warning without breaking ZDoom compatibility or at least generating a warning in ZDoom. This could be fixed by adding the TeamDeathmatch alias also to ZDoom.
(0007920)
Dusk   
2014-01-08 19:09   
Another option would be to specifically name the teamgame "custom team game" all across the board on Zandronum, though this would require changing the CVAR (we're already forcing server hosts to update configs so this is not a problem) and changing strings.

The change of meaning of "team game" to actually mean team deathmatch might come off confusing at first but honestly it's very confusing to begin with. If we add "custom" to the name we would provide some well needed clarity over what is what.
(0007921)
Torr Samaho   
2014-01-08 21:21   
Mods that rely on the value of the CVAR teamgame would break if we rename it, wouldn't they?
(0007922)
Blzut3   
2014-01-08 21:30   
Right, I would just call the game customteamgame in SBarInfo and be done with it. No sense trying to clean up the confusion there since I'm not sure detecting the game mode outright is the best way to do things. Especially since we do support game mode configuration, gamemode needs to be extended to allow detecting what type of game (points? frags? teams?) is being played rather than what precisely is being played.
(0007923)
Torr Samaho   
2014-01-08 21:55   
Good point.
(0010990)
Blzut3   
2014-11-28 18:30   
Changed the ticket information since after the first note it stopped being about backwards compatibility and it confused Dusk.
(0011240)
Torr Samaho   
2015-01-03 15:20   
customteamgame sounds like a reasonable compromise. Are you going to add it, Blzut3?
(0011311)
Blzut3   
2015-01-06 02:07   
Marking as needs testing per:'https://bitbucket.org/Torr_Samaho/zandronum/commits/f5fa9ddda9f19c0f00942fd1ed2a89e440832d4c [^]'

However, I would not consider that a complete solution to the issue, so after that change is confirmed working I recommend removing this ticket from 2.0 target instead of marking as resolved.