MantisBT - Zandronum
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0001622Zandronum[All Projects] Bugpublic2013-12-27 21:252014-06-03 17:54
ReporterCatastrophe 
Assigned ToTorr Samaho 
PrioritynormalSeveritymajorReproducibilityhave not tried
StatusclosedResolutionno change required 
PlatformMicrosoftOSWindowsOS VersionXP/Vista/7
Product Version2.0-beta 
Target Version2.0Fixed in Version 
Summary0001622: Server crash in survival while playing Russian Overkill
DescriptionBasically myself and a friend of mine were playing Russian Overkill and whenever we switched to survival it crashed either the client or overloaded the server, I only managed to save these crashes:

'http://www.sendspace.com/file/wnw7xu [^]'
'http://www.sendspace.com/file/cnxpf2 [^]'
'http://www.sendspace.com/file/uaesni [^]'

It -appears- to be more stable in cooperative
Steps To ReproducePlay survival with a buddy using this wad:'http://www.sendspace.com/file/le1r68 [^]'
Additional InformationSorry I can't make a minimal example wad out of this because I don't know what's causing it.
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2013-12-27 21:25CatastropheNew Issue
2013-12-27 21:26CatastropheNote Added: 0007745
2013-12-28 09:35Torr SamahoAssigned To => Torr Samaho
2013-12-28 09:35Torr SamahoStatusnew => assigned
2013-12-28 11:04Torr SamahoNote Added: 0007750
2013-12-28 11:04Torr SamahoStatusassigned => needs testing
2013-12-28 18:51CatastropheNote Added: 0007751
2013-12-28 19:26Torr SamahoNote Added: 0007752
2013-12-28 20:33CatastropheNote Added: 0007753
2013-12-30 11:31Torr SamahoNote Added: 0007767
2014-01-06 18:00DuskTarget Version => 2.0
2014-02-09 19:01QentNote Added: 0008181
2014-04-24 22:35ArcoNote Added: 0008642
2014-06-03 17:53ArcoNote Edited: 0008642bug_revision_view_page.php?bugnote_id=8642#r4792
2014-06-03 17:54ArcoStatusneeds testing => closed
2014-06-03 17:54ArcoResolutionopen => no change required

Notes
(0007745)
Catastrophe   
2013-12-27 21:26   
Additionally, the wad works perfectly fine if I'm alone in the server or I am in single player.
(0007750)
Torr Samaho   
2013-12-28 11:04   
There are actually (at least) two problems here. One is a spectator related bug in the server. This should be fixed now. The other is that the mod uses script numbers bigger than 999 which Zandronum and ZDoom 2.5.0 do not support. I added a check that will cause an error when invalid script numbers are used. This contains both changes.
(0007751)
Catastrophe   
2013-12-28 18:51   
"I added a check that will cause an error when invalid script numbers are used."

So is getting kicked from the server upon joining intentional? Because now whenever I try to join using that mod it just kicks me from the server. On the console though, it says:

catastrophe joined the game.
Warning: 'Object' is freed outside the GC process.
*** ERROR: Error: Script number 65535 exceeds 999!

catastrophe was kicked from the server! Reason: Server encountered an error.
client catastrophe disconnected.

It doesn't give me a crash report either, would it be ok to just simply ignore scripts higher than 999? Or would that break something?
(0007752)
Torr Samaho   
2013-12-28 19:26   
Quote from Catastrophe
So is getting kicked from the server upon joining intentional?
Yes, it is.

Quote from Catastrophe
would it be ok to just simply ignore scripts higher than 999?
No. We have to assume that a mod doesn't include useless scripts. If you just ignore a script from a mod, something will not work as intended. The mod needs to be fixed not to include scripts Zandronum cannot run.
(0007753)
Catastrophe   
2013-12-28 20:33   
Alright, then it works as intended. (Though I would recommend changing the kick reason to something less vague)
(0007767)
Torr Samaho   
2013-12-30 11:31   
I refined the error handling: This build should already error out when loading the map and not wait till a client connects.
(0008181)
Qent   
2014-02-09 19:01   
What is the spectator related bug, and how should we test it, since fix for high script numbers prevents Zandronum 2.0 from loading the map?
(0008642)
Arco   
2014-04-24 22:35   
(edited on: 2014-06-03 17:53)
I think the problem here is that Russian Overkill is using named scripts in it's code which Zandronum does not support, but the latest versions of Zdoom and Gzdoom do. The high script number error does not actually pertain to what's happening and it doesn't say which script is causing the error, however.

EDIT: The spectator bug is a separate issue, so I think it's okay if I close this ticket.