|
Notes |
|
|
|
|
The patch looks fine. Since it doesn't fix any bugs, but is solely intended to improve the code quality, I suggest to add this to 2.0. |
|
|
|
(0007391)
|
|
Dusk
|
|
2013-10-13 09:24
|
|
|
Why to 2.0? If it's pushed to 1.3 we'll get less differences in medal.cpp and any bugfixes to the file in 1.3 would possibly cause less conflicts when merging to 2.0. |
|
|
|
|
|
As far I can tell, your cleanup is not intended to fix any issues with the behavior of the code, but is solely meant to increase the quality and future maintainability of the code. Changing proven code always risks introducing new issues (I have witnessed unexpected issues popping up with code rewrites often enough) and without getting something tangible in return (like a bug fix or new feature) I'd prefer not to risk 1.3's stability. |
|
|
|
|
|