MantisBT - Zandronum
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0001425Zandronum[All Projects] Bugpublic2013-07-22 18:422014-06-21 01:36
ReporterRusselCS 
Assigned To 
PrioritylowSeverityminorReproducibilityN/A
StatusnewResolutionopen 
PlatformOSOS Version
Product Version1.1.1 
Target VersionFixed in Version 
Summary0001425: Morphed players do not transfer their skin
DescriptionMore accurately, skins on morphed player classes are not kept at all.
Previously, in Skulltag, morphed player classes kept the skin that they previously held upon morphing unless the morphed class had +NOSKIN. Currently, morphed classes lose their skin entirely.
While this may not seem like much of an issue, the class still retains other features the skin had, such as the taunt, jump, pain, landing, grunting, use fail, gibbed, and death sounds.

My primary concern is whether or not this functionality was intended. If it was, then the ticket can be closed here and now. Otherwise, this is just a small issue that may need to be addressed at some point.
Steps To Reproduce
Additional Information
TagsNo tags attached.
Relationships
Attached Files? morphtest.wad (903) 2013-07-25 19:58
https://zandronum.com/tracker/file_download.php?file_id=1027&type=bug
Issue History
Date ModifiedUsernameFieldChange
2013-07-22 18:42RusselCSNew Issue
2013-07-22 18:57Torr SamahoNote Added: 0006753
2013-07-22 20:47RusselCSNote Added: 0006756
2013-07-25 18:36Torr SamahoNote Added: 0006793
2013-07-25 18:36Torr SamahoStatusnew => feedback
2013-07-25 19:58RusselCSFile Added: morphtest.wad
2013-07-25 19:59RusselCSNote Added: 0006800
2013-07-25 19:59RusselCSStatusfeedback => new
2013-07-25 20:11RusselCSNote Edited: 0006800bug_revision_view_page.php?bugnote_id=6800#r3793
2013-07-25 20:16RusselCSNote Edited: 0006800bug_revision_view_page.php?bugnote_id=6800#r3794
2013-07-25 23:03Edward-sanNote Added: 0006803
2013-07-26 01:48RusselCSNote Added: 0006806
2014-06-14 17:30WatermelonNote Added: 0009308
2014-06-14 17:30WatermelonStatusnew => feedback
2014-06-14 19:05RusselCSNote Added: 0009341
2014-06-14 19:05RusselCSStatusfeedback => new
2014-06-14 21:41WatermelonNote Added: 0009343
2014-06-14 21:41WatermelonStatusnew => feedback
2014-06-20 20:47RusselCSNote Added: 0009607
2014-06-20 20:47RusselCSStatusfeedback => new
2014-06-21 01:36StrikerMan780Note Added: 0009608
2014-06-21 01:38StrikerMan780Note Deleted: 0009608

Notes
(0006753)
Torr Samaho   
2013-07-22 18:57   
The old behavior was a bug fixed in changeset b5f974e3d6ac6bda5e51e28809fab6921d8e1c42.

I'd say morphed class should also not use any sounds of the skin. How does ZDoom handle this?
(0006756)
RusselCS   
2013-07-22 20:47   
I am honestly unsure, until now I never even realized ZDoom had effective skin support.
(0006793)
Torr Samaho   
2013-07-25 18:36   
Can you test how ZDoom handles this?
(0006800)
RusselCS   
2013-07-25 19:59   
(edited on: 2013-07-25 20:16)
Dang, I was dumb and thought SKININFO in ZDoom actually worked...let me fix that by using S_SKIN instead.

EDIT: Alright, the old behavior Skulltag held was the correct behavior. Skins should be preserved when morphed.
I will continue experimentation, however, as I am unsure whether this only occurs under certain circumstances such as the morphed class having the same base skin, or whatever.

EDIT 2:As of ZDoom 2.7.1, the morphing is handled in such a way that regardless of the base skin sprites of the destination actor, the morphed class preserves the skin set by the player. In the instance of NOSKIN, this behavior is nullified.
(0006803)
Edward-san   
2013-07-25 23:03   
Quote

Skins should be preserved when morphed.

doesn't this mean "goodbye Zombie Horde"? Just sayin'.
(0006806)
RusselCS   
2013-07-26 01:48   
I already mentioned, if +NOSKIN is added to the morphed class in ZDoom, then the class will then just use the base class skin.

Not to mention, this was the functionality of older skulltag versions, which I have stated at least three times now.
(0009308)
Watermelon   
2014-06-14 17:30   
Does this still happen in 2.0?
(0009341)
RusselCS   
2014-06-14 19:05   
Unchanged on Zandronum 2.0-alpha-140112-1124.
(0009343)
Watermelon   
2014-06-14 21:41   
Now the big important one:
Does it happen in zdoom latest?

If it is fine in zdoom 2.7.1 (most recent version)... check 2.5.0 (to see if it's broken in zandronum)


2.7.1:'http://www.zdoom.org/files/zdoom/2.7/zdoom-2.7.1.zip [^]'
2.5.0:'http://www.zdoom.org/files/zdoom/2.5/zdoom-2.5.0.zip [^]'
(0009607)
RusselCS   
2014-06-20 20:47   
I mentioned in an earlier note that in ZDoom 2.7.1 players transfer their skin to morphed classes assuming the morphed class lacks the NOSKIN actor flag.
This behavior is the same in ZDoom 2.5.0.

My apologies for the late response and thank you for your attention.