MantisBT - Zandronum
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0001410Zandronum[All Projects] Bugpublic2013-07-17 22:222018-09-30 21:33
ReporterWatermelon 
Assigned ToDusk 
PriorityimmediateSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOSOS Version
Product Version1.1 
Target Version1.1.1Fixed in Version1.1.1 
Summary0001410: Teamchat can be heard by the other team
DescriptionAs the topic says, Blue can see Red's team chat...etc
Steps To Reproduce
Additional Information
TagsNo tags attached.
Relationships
Attached Filesdiff teamchat.diff (647) 2013-07-17 22:37
https://zandronum.com/tracker/file_download.php?file_id=1020&type=bug
Issue History
Date ModifiedUsernameFieldChange
2013-07-17 22:22WatermelonNew Issue
2013-07-17 22:25DuskAssigned To => Dusk
2013-07-17 22:25DuskPriorityurgent => immediate
2013-07-17 22:25DuskStatusnew => assigned
2013-07-17 22:37DuskFile Added: teamchat.diff
2013-07-17 22:37DuskNote Added: 0006687
2013-07-17 22:38Edward-sanNote Added: 0006688
2013-07-17 22:38Edward-sanNote Deleted: 0006688
2013-07-17 22:38WatermelonNote Added: 0006689
2013-07-17 22:38DuskStatusassigned => needs review
2013-07-17 22:38WatermelonNote Deleted: 0006689
2013-07-17 22:50Edward-sanNote Added: 0006690
2013-07-18 00:14DuskTarget Version1.1 => 1.1.1
2013-07-18 07:04Torr SamahoNote Added: 0006695
2013-07-18 07:08Torr SamahoNote Edited: 0006695bug_revision_view_page.php?bugnote_id=6695#r3724
2013-07-18 07:08Torr SamahoNote Revision Dropped: 6695: 0003723
2013-07-18 10:25Edward-sanNote Added: 0006696
2013-07-18 16:40Torr SamahoNote Added: 0006703
2013-07-18 16:41Torr SamahoStatusneeds review => needs testing
2013-07-18 17:14ArcoNote Added: 0006705
2013-07-18 17:25DuskStatusneeds testing => resolved
2013-07-18 17:25DuskFixed in Version => 1.1.1
2013-07-18 17:25DuskResolutionopen => fixed
2013-07-18 17:32DuskStatusresolved => feedback
2013-07-18 17:32DuskResolutionfixed => reopened
2013-07-18 22:00DuskStatusfeedback => resolved
2013-07-18 22:00DuskResolutionreopened => fixed
2018-09-30 21:33Blzut3Statusresolved => closed

Notes
(0006687)
Dusk   
2013-07-17 22:37   
fixedddddddddddddddddd

o/
(0006690)
Edward-san   
2013-07-17 22:50   
Just saying, it was broken starting from changeset db11a4687ab3.
(0006695)
Torr Samaho   
2013-07-18 07:04   
(edited on: 2013-07-18 07:08)
From what I can tell your patch break may break team chat for spectators if the spectators were on different teams before.

From the top of my head I'd say

( PLAYER_IsTrueSpectator ( &players[ulIdx] ) != PLAYER_IsTrueSpectator ( &players[ulPlayer] )

has to be replaced by

( ( PLAYER_IsTrueSpectator ( &players[ulIdx] ) != PLAYER_IsTrueSpectator ( &players[ulPlayer] ) || PLAYER_IsTrueSpectator ( &players[ulIdx] ) = false )
(0006696)
Edward-san   
2013-07-18 10:25   
Quote

PLAYER_IsTrueSpectator ( &players[ulIdx] ) = false


I suppose it's '==', not '='.
(0006703)
Torr Samaho   
2013-07-18 16:40   
Yes, that was a typo, the code wouldn't have compiled as is. Here is a testing binary with my proposed fix. Please confirm that it works and also check that spectator chat still works regardless on which team the spectators may have been before.
(0006705)
Arco   
2013-07-18 17:14   
Conformed fixed. Spectators and players alike of different teams cannot see their enemies nor other spectator team chat.