MantisBT - Zandronum
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0001296Zandronum[All Projects] Suggestionpublic2013-03-10 23:492015-05-26 00:48
ReporterDusk 
Assigned To 
PrioritynormalSeverityminorReproducibilityN/A
StatusclosedResolutiondenied 
PlatformOSOS Version
Product Version 
Target VersionFixed in Version 
Summary0001296: Multiplayer menu updates
Description'https://bitbucket.org/CrimsonDusk/neurosphere/commits/6c7f4513171d7ac7a8694874513e0704e0d92dc1 [^]'

- Added cl_hidecountry to multiplayer options
- Hid the internal server browser from release builds, checked with BUILD_ID
- Added message to the switch teams entry for consistency factor. The other action entries do so too.

Why are cl_medals and cl_icons commented out? If some separators were removed they'd fit in neatly.
Steps To Reproduce
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2013-03-10 23:49DuskNew Issue
2013-03-10 23:49DuskStatusnew => assigned
2013-03-10 23:49DuskAssigned To => Dusk
2013-03-10 23:49DuskStatusassigned => needs review
2013-03-10 23:50DuskDescription Updatedbug_revision_view_page.php?rev_id=3366#r3366
2013-03-10 23:53DuskDescription Updatedbug_revision_view_page.php?rev_id=3367#r3367
2013-03-17 19:22Torr SamahoNote Added: 0006137
2013-04-05 13:04DuskNote Added: 0006228
2013-04-07 11:18Torr SamahoNote Added: 0006267
2013-04-28 19:06Torr SamahoStatusneeds review => feedback
2015-05-26 00:48DuskNote Added: 0012399
2015-05-26 00:48DuskStatusfeedback => assigned
2015-05-26 00:48DuskStatusassigned => closed
2015-05-26 00:48DuskAssigned ToDusk =>
2015-05-26 00:48DuskResolutionopen => denied

Notes
(0006137)
Torr Samaho   
2013-03-17 19:22   
The patch looks good. If you add a zandronum-history.txt entry and rebase it, I'll pull it.

Quote from Dusk

Why are cl_medals and cl_icons commented out? If some separators were removed they'd fit in neatly.

I have no idea.
(0006228)
Dusk   
2013-04-05 13:04   
Added, history entry, also re-enabled cl_medals and cl_icons. Pull request created.
(0006267)
Torr Samaho   
2013-04-07 11:18   
I pulled your code, but it doesn't link, so I can't push it. cl_hidecountry is a flag extending cl_connect_flags, so EXTERN_CVAR( Bool, cl_hidecountry ) can't be used, but EXTERN_CVAR( Flag, cl_hidecountry ) should work. While you are at it, I propose to put the extern into cl_main.h alongside the extern declarations of the other connect flags.
(0012399)
Dusk   
2015-05-26 00:48   
This got obsoleted by the menu rebuild in 3.0.