MantisBT - Zandronum
View Issue Details
0001279Zandronum[All Projects] Bugpublic2013-02-10 22:022018-09-30 22:11
Balrog 
Torr Samaho 
normalcrashalways
closedfixed 
1.0 
3.03.0 
0001279: Trying to morph a player with MorphActor from an OPEN script makes the game crash
The title pretty much sums it up. This is a bit of a problem for "boss" mods that morph a random player. Crashes in both 1.0 and 1.1-alpha-130120-0905.
1. Load the example wad
2. Wait 5 seconds
3. Crash
The switch will morph you into a ChickenPlayer without crashing; if you press the switch before the 5 seconds are up, you will not crash, presumably because the OPEN morph failed.

The crash only seems to occur when MorphActor actually tries to morph a player; setting the tid argument to a nonsense tid that isn't actually present won't cause a crash.

The style of the morph seems to have no effect.
No tags attached.
child of 0002172closed Torr Samaho Upgrade GZDoom base to 1.8.6 
? morphcrash.wad (1,909) 2013-02-10 22:02
https://zandronum.com/tracker/file_download.php?file_id=936&type=bug
zip MorphActorTest.wad.zip (305) 2013-02-17 11:55
https://zandronum.com/tracker/file_download.php?file_id=939&type=bug
Issue History
2013-02-10 22:02BalrogNew Issue
2013-02-10 22:02BalrogFile Added: morphcrash.wad
2013-02-11 04:59WatermelonNote Added: 0005994
2013-02-11 04:59WatermelonNote Edited: 0005994bug_revision_view_page.php?bugnote_id=5994#r3308
2013-02-11 08:31ZzZomboNote Added: 0005996
2013-02-11 09:29Torr SamahoNote Added: 0005997
2013-02-11 09:29Torr SamahoAssigned To => Torr Samaho
2013-02-11 09:29Torr SamahoStatusnew => assigned
2013-02-12 21:50BalrogNote Added: 0006016
2013-02-17 09:16Torr SamahoNote Added: 0006041
2013-02-17 09:16Torr SamahoStatusassigned => feedback
2013-02-17 11:55DuskFile Added: MorphActorTest.wad.zip
2013-02-17 11:56DuskNote Added: 0006044
2013-02-17 11:58DuskNote Edited: 0006044bug_revision_view_page.php?bugnote_id=6044#r3338
2013-02-17 11:58DuskStatusfeedback => acknowledged
2013-02-17 11:58DuskResolutionopen => waiting for zdoom
2013-02-19 20:02DuskNote Added: 0006055
2013-02-19 20:02DuskStatusacknowledged => feedback
2016-02-06 12:40Edward-sanNote Added: 0014358
2016-02-06 12:40Edward-sanStatusfeedback => needs testing
2016-02-06 12:40Edward-sanResolutionwaiting for zdoom => open
2016-02-06 12:40Edward-sanTarget Version => 3.0
2016-02-06 12:45Edward-sanRelationship addedchild of 0002172
2016-02-06 18:15Ru5tK1ngNote Added: 0014372
2016-02-06 18:16Ru5tK1ngStatusneeds testing => resolved
2016-02-06 18:16Ru5tK1ngResolutionopen => fixed
2016-02-06 18:16Ru5tK1ngFixed in Version => 3.0
2018-09-30 22:11Blzut3Statusresolved => closed

Notes
(0005994)
Watermelon   
2013-02-11 04:59   
Does it happen in ZDoom 2.6.1?

(0005996)
ZzZombo   
2013-02-11 08:31   
OPEN? Not ENTER? O_o

How is that even supposed to work? OPEN is executed in multiplayer when no players are actually connected to server. Use ENTER instead.
(0005997)
Torr Samaho   
2013-02-11 09:29   
Yeah, you can't morph players that are not in the game. Nevertheless, Zandronum shouldn't crash if you try to. I'll see if I can fix the crash, most likely you will still have to adapt your scripts to make it work as intended.
(0006016)
Balrog   
2013-02-12 21:50   
> Yeah, you can't morph players that are not in the game.

I agree. However, the problem is that it's crashing when trying to morph players that ARE in the game. I wasn't able to test this online, but the MorphActor call should fail silently when you try to morph a player that isn't in game because their TID isn't assigned to anything.
(0006041)
Torr Samaho   
2013-02-17 09:16   
This seems to be a ZDoom bug. If MorphActor is called with NULL as activator, i.e. the world as activator, it's going to crash when trying to morph a player. Can somebody confirm this in the latest ZDoom version?
(0006044)
Dusk   
2013-02-17 11:56   
(edited on: 2013-02-17 11:58)
Does crash with latest ZDoom, example wad attached.

Reported.

(0006055)
Dusk   
2013-02-19 20:02   
'http://forum.zdoom.org/viewtopic.php?p=669905#p669905 [^]'
(0014358)
Edward-san   
2016-02-06 12:40   
The fix should be present in latest zandronum 3.0 beta. Please check it out.
(0014372)
Ru5tK1ng   
2016-02-06 18:15   
Using the latest beta I didn't crash as a player or a spectator. Seems fixed.