MantisBT - Zandronum
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0001275Zandronum[All Projects] Bugpublic2013-02-09 16:392024-03-12 05:19
ReporterMonsterovich 
Assigned ToDusk 
PrioritynormalSeverityminorReproducibilityalways
StatusresolvedResolutionfixed 
PlatformOSOS Version
Product Version1.0 
Target VersionFixed in Version 
Summary0001275: Line_SetTextureOffset doesn't work in multiplayer
DescriptionCalls to Line_SetTextureOffset are ignored when it is called in a serverside script in multiplayer. It works in singleplayer and in clientside scripts.
Steps To Reproduce1. Create a serverside script which uses Line_SetTextureOffset.
2. Run it in multiplayer.
3. Texture offset won't change at all.
Additional InformationIt works in clientside scripts but (obviously) newly connected clients don't see the offset.
TagsNo tags attached.
Relationships
Attached Files? aligntest-fixed.wad (1,879) 2013-02-09 16:39
https://zandronum.com/tracker/file_download.php?file_id=934&type=bug
patch 3854.patch (14,022) 2024-03-10 01:56
https://zandronum.com/tracker/file_download.php?file_id=2925&type=bug
patch 3855.patch (5,295) 2024-03-10 01:56
https://zandronum.com/tracker/file_download.php?file_id=2926&type=bug
patch 3856.patch (603) 2024-03-10 01:56
https://zandronum.com/tracker/file_download.php?file_id=2927&type=bug
patch 3857.patch (975) 2024-03-10 01:56
https://zandronum.com/tracker/file_download.php?file_id=2928&type=bug
Issue History
Date ModifiedUsernameFieldChange
2013-02-09 16:39MonsterovichNew Issue
2013-02-09 16:39MonsterovichFile Added: aligntest-fixed.wad
2013-02-10 19:34DuskAssigned To => Dusk
2013-02-10 19:34DuskPriorityhigh => normal
2013-02-10 19:34DuskSeveritytweak => major
2013-02-10 19:34DuskStatusnew => assigned
2013-02-10 19:34DuskSeveritymajor => minor
2013-02-10 23:56DuskNote Added: 0005989
2013-02-10 23:56DuskStatusassigned => needs review
2013-02-10 23:58DuskNote Edited: 0005989bug_revision_view_page.php?bugnote_id=5989#r3305
2013-02-11 00:01DuskNote Edited: 0005989bug_revision_view_page.php?bugnote_id=5989#r3306
2013-02-11 16:19DuskNote Edited: 0005989bug_revision_view_page.php?bugnote_id=5989#r3314
2013-10-29 08:49MonsterovichNote Added: 0007488
2013-11-01 09:15DuskNote Deleted: 0007488
2013-11-01 09:15DuskNote Edited: 0005989bug_revision_view_page.php?bugnote_id=5989#r4189
2016-02-11 16:40djskaarjNote Added: 0014421
2017-10-14 08:10Edward-sanNote Added: 0018553
2017-10-14 08:10Edward-sanStatusneeds review => feedback
2019-03-22 00:51buu342Note Added: 0020451
2024-03-10 01:56Ru5tK1ngFile Added: 3854.patch
2024-03-10 01:56Ru5tK1ngFile Added: 3855.patch
2024-03-10 01:56Ru5tK1ngFile Added: 3856.patch
2024-03-10 01:56Ru5tK1ngFile Added: 3857.patch
2024-03-10 01:58Ru5tK1ngNote Added: 0023325
2024-03-12 05:19Ru5tK1ngNote Added: 0023369
2024-03-12 05:19Ru5tK1ngStatusfeedback => resolved
2024-03-12 05:19Ru5tK1ngResolutionopen => fixed

Notes
(0005989)
Dusk   
2013-02-10 23:56   
(edited on: 2013-11-01 09:15)
OK so to make this work I had to establish texture offset networking in general.

'https://bitbucket.org/slatenails/neurosphere/commits/3854 [^]'
'https://bitbucket.org/slatenails/neurosphere/commits/3855 [^]'
(https://bitbucket.org/slatenails/neurosphere/commits/3856)
'https://bitbucket.org/slatenails/neurosphere/commits/3857 [^]'

Here is how it works:
- Saved offsets are stored in side_t::part (3 pairs for each sidedef)
- Whenever offsets are changed, a callback function is called to handle the offset change and sync the offsets if needed. A global variable is used as a toggle so as not to make for instance scrollers constantly trigger this and waste bandwidth like no tomorrow.
- On map reset, the server and client both restore the offsets. No network traffic is used here.
(0014421)
djskaarj   
2016-02-11 16:40   
Sorry for making a pointless post, but may I ask, will be this merged in Zandronum in future? Dusk made a patch a long time ago, but the links are broken and this bug doesn't seem to be fixed now.
(0018553)
Edward-san   
2017-10-14 08:10   
Is it possible to recover these patches, Dusk?
(0020451)
buu342   
2019-03-22 00:51   
This would be really nice to get fixed.
(0023325)
Ru5tK1ng   
2024-03-10 01:58   
Patches have been recovered. Unsure if Dusk wants to redo/reimplement the patches or if the changes can be tossed onto a topic and reviewed there.
(0023369)
Ru5tK1ng   
2024-03-12 05:19   
Not sure when this was fixed, but it seems Kaminsky added code that allows the test wad to have the offset change online. The texture still offsets for new clients that connect after the switch has been pressed.