MantisBT - Zandronum
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0001265Zandronum[All Projects] Bugpublic2013-01-28 14:402018-09-30 20:20
ReporterDusk 
Assigned ToDusk 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOSOS Version
Product Version1.0 
Target Version1.1Fixed in Version1.1 
Summary0001265: Strife phosphorus fire fix
Description'https://bitbucket.org/CrimsonDusk/neurosphere/commits/3829 [^]'

I really hate mercurial's commit bureocracy, makes correcting fixes really convulted...
Steps To Reproduce
Additional Information
TagsNo tags attached.
Relationships
has duplicate 0001311closed  Strife's Phosphorous Grenade flames never go out online 
has duplicate 0001326closed Dusk Strife phosphorus grenades fire does not die 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2013-01-28 14:40DuskNew Issue
2013-01-28 14:40DuskAssigned To => Dusk
2013-01-28 14:40DuskStatusnew => needs review
2013-01-28 20:36Torr SamahoNote Added: 0005845
2013-01-28 20:37Torr SamahoStatusneeds review => feedback
2013-01-29 11:30DuskNote Added: 0005858
2013-01-29 11:30DuskStatusfeedback => assigned
2013-01-29 11:30DuskStatusassigned => needs review
2013-01-30 06:26Torr SamahoNote Added: 0005867
2013-01-30 06:29Torr SamahoStatusneeds review => needs testing
2013-01-30 06:29Torr SamahoProduct Version => 1.0
2013-01-30 06:29Torr SamahoTarget Version => 1.1
2013-03-20 04:17WatermelonNote Added: 0006148
2013-03-20 10:29DuskNote Added: 0006154
2013-03-29 13:34DuskRelationship addedhas duplicate 0001311
2013-04-06 21:17QentNote Added: 0006261
2013-04-06 21:17QentNote Edited: 0006261bug_revision_view_page.php?bugnote_id=6261#r3454
2013-04-06 21:34QentNote Edited: 0006261bug_revision_view_page.php?bugnote_id=6261#r3455
2013-04-07 11:58DuskNote Added: 0006268
2013-04-07 11:58DuskStatusneeds testing => resolved
2013-04-07 11:58DuskFixed in Version => 1.1
2013-04-07 11:58DuskResolutionopen => fixed
2013-04-19 12:18DuskRelationship addedhas duplicate 0001326
2018-09-30 20:20Blzut3Statusresolved => closed

Notes
(0005845)
Torr Samaho   
2013-01-28 20:36   
The patch still uses SERVERCOMMANDS_MoveThing instead of SERVERCOMMANDS_MoveThingExact (or SERVER_UpdateThingMomentum if resyncing is necessary) on self.
(0005858)
Dusk   
2013-01-29 11:30   
'https://bitbucket.org/CrimsonDusk/neurosphere/commits/3833 [^]'
(0005867)
Torr Samaho   
2013-01-30 06:26   
Thanks! Pulled and rebased.

BTW: One thing I just noticed: Did you test that it's not necessary to inform the client of drop's reactiontime with SERVERCOMMANDS_SetThingReactionTime?
(0006148)
Watermelon   
2013-03-20 04:17   
What should I do to confirm this working in 1.1? Test it online with myself with ping emulation?
(0006154)
Dusk   
2013-03-20 10:29   
In 1.0 the flames never seemed to cease existance IIRC.
(0006261)
Qent   
2013-04-06 21:17   
(edited on: 2013-04-06 21:34)
The bug occurred online in 1.0 without any ping emulation. The flames disappear in 1.1 with and without latency and packetloss.
(0006268)
Dusk   
2013-04-07 11:58   
Quote
BTW: One thing I just noticed: Did you test that it's not necessary to inform the client of drop's reactiontime with SERVERCOMMANDS_SetThingReactionTime?

reactiontime is used for A_Countdown, which is server-managed. Thus I don't think the client needs it.

Since testing revealed no problems I'll mark this fixed.