MantisBT - Zandronum
View Issue Details
0001264Zandronum[All Projects] Suggestionpublic2013-01-28 14:002018-09-30 23:08
ZzZombo 
Dusk 
normalminorN/A
closedfixed 
 
2.02.0 
0001264: Option for sv_unblockplayers to work only for allies
I suggest yo use the value of 2 of the CVAR to allow players to pass only through allies, this especially handy for team based games.
No tags attached.
related to 0001318closed  sv_unblockplayers doesn't work with different classes 
Issue History
2013-01-28 14:00ZzZomboNew Issue
2013-01-28 14:26DuskNote Added: 0005844
2013-07-22 14:42DuskRelationship addedrelated to 0001318
2014-06-14 17:27WatermelonStatusnew => confirmed
2014-08-15 07:05LeonardNote Added: 0010207
2014-08-17 18:42DuskStatusconfirmed => needs review
2014-12-28 16:08Torr SamahoNote Added: 0011104
2014-12-28 16:08Torr SamahoAssigned To => Torr Samaho
2014-12-28 16:08Torr SamahoStatusneeds review => feedback
2014-12-28 16:08Torr SamahoAssigned ToTorr Samaho =>
2015-01-01 21:36LeonardNote Added: 0011195
2015-01-08 15:15DuskAssigned To => Dusk
2015-01-08 15:15DuskStatusfeedback => assigned
2015-01-08 18:52CatastropheNote Added: 0011335
2015-01-08 20:03Edward-sanNote Added: 0011336
2015-01-08 21:03Torr SamahoNote Added: 0011338
2015-01-08 21:04Torr SamahoNote Edited: 0011338bug_revision_view_page.php?bugnote_id=11338#r6361
2015-01-08 21:05Torr SamahoNote Revision Dropped: 11338: 0006360
2015-01-09 01:12Edward-sanNote Added: 0011341
2015-01-09 16:03DuskNote Added: 0011343
2015-01-09 16:03DuskStatusassigned => needs review
2015-01-10 11:20Torr SamahoStatusneeds review => needs testing
2015-01-10 12:36cobaltTarget Version => 2.0
2015-01-10 12:37cobaltNote Added: 0011350
2015-01-18 03:16StrikerMan780Note Added: 0011420
2015-01-18 10:49DuskStatusneeds testing => resolved
2015-01-18 10:49DuskFixed in Version => 2.0
2015-01-18 10:49DuskResolutionopen => fixed
2018-09-30 23:08Blzut3Statusresolved => closed

Notes
(0005844)
Dusk   
2013-01-28 14:26   
I think this was an oversight and this should've been default behavior..
(0010207)
Leonard   
2014-08-15 07:05   
'https://bitbucket.org/Torr_Samaho/zandronum-stable/pull-request/66/sv_unblockplayers-now-works-with-different/diff [^]'
(0011104)
Torr Samaho   
2014-12-28 16:08   
0001318:0011103
(0011195)
Leonard   
2015-01-01 21:36   
I'm not sure what should be done about this.
Should we create a new dmflag (or zadmflag)?
If so how would it behave if both sv_unblockallies and sv_unblockplayers are set?
(0011335)
Catastrophe   
2015-01-08 18:52   
sv_unblockplayers 1 (unblocks all)
sv_unblockplayers 2 (unblocks team players)
(0011336)
Edward-san   
2015-01-08 20:03   
I'm with ^. It would make no sense to add sv_unblockallies. What happens if sv_unblockallies were not set and sv_unblockplayers were set? Block the allies and not the enemies? Sounds displeasing.
(0011338)
Torr Samaho   
2015-01-08 21:03   
(edited on: 2015-01-08 21:04)
It's straight forward to reasonably define sv_unblockplayers and sv_unblockallies by just letting them do what their name implies. The former turns of all player-player blocking, the latter just the player-player blocking of allied players. In particular, this means that if sv_unblockplayers is set, the value of sv_unblockallies has no effect.

Note that sv_unblockplayers is a dmflag. As a flag it can only have the values true or false. If you want sv_unblockplayers to respect 0, 1 and 2 it has to be removed from the dmflags and converted to an int CVAR.

(0011341)
Edward-san   
2015-01-09 01:12   
Uh indeed... anyways, since we need a new flag for sv_unblockallies, and since there are flag changes between 1.3 and 2.0, should this code addition be made into 2.0?
(0011343)
Dusk   
2015-01-09 16:03   
'https://bitbucket.org/Torr_Samaho/zandronum/pull-request/57 [^]'
(0011350)
cobalt   
2015-01-10 12:37   
Issue addressed by commit 45f2c5e: - added dmflag sv_unblockallies which is like sv_unblockplayers except only unblocks ally players (addreses 1264)
Committed by Teemu Piippo [Dusk] on Friday 09 January 2015 05:10:39

Changes in files:
 docs/zandronum-history.txt | 1 +
 src/d_main.cpp | 1 +
 src/doomdef.h | 3 +++
 src/p_interaction.cpp | 11 ++++++++---
 src/p_local.h | 3 +++
 src/p_map.cpp | 23 ++++++++++++++++++-----
 6 files changed, 34 insertions(+), 8 deletions(-)
(0011420)
StrikerMan780   
2015-01-18 03:16   
This is working great.