MantisBT - Zandronum
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0001262Zandronum[All Projects] Bugpublic2013-01-28 00:102018-09-30 20:25
ReporterDusk 
Assigned ToDusk 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOSOS Version
Product Version 
Target Version1.1Fixed in Version1.1 
Summary0001262: Freeze hue stays after joining spectators
DescriptionIf the player dies by freezing and spectates before respawning, the blue freeze hue will stay indefinitely. If the player then respawns, the hue is cleared.

Happens both in offline and online.
Steps To Reproduce- Load up example wad
- Move to the blue pad, which triggers an ice rocket trap
- Once dead to the ice rocket, join spectators
Additional Information
TagsNo tags attached.
Relationships
Attached Fileszip FreezeHueTest.wad.zip (1,847) 2013-01-28 00:10
/tracker/file_download.php?file_id=927&type=bug
Issue History
Date ModifiedUsernameFieldChange
2013-01-28 00:10DuskNew Issue
2013-01-28 00:10DuskFile Added: FreezeHueTest.wad.zip
2013-01-28 00:10DuskStatusnew => confirmed
2013-01-28 13:54DuskAssigned To => Dusk
2013-01-28 13:54DuskStatusconfirmed => assigned
2013-01-28 14:24DuskNote Added: 0005843
2013-01-28 14:24DuskStatusassigned => needs review
2013-01-28 20:42Torr SamahoNote Added: 0005847
2013-01-28 20:43Torr SamahoStatusneeds review => feedback
2013-01-29 06:15Torr SamahoNote Added: 0005854
2013-01-29 11:28DuskNote Added: 0005857
2013-01-29 11:28DuskStatusfeedback => assigned
2013-01-29 11:28DuskStatusassigned => needs review
2013-01-30 06:18Torr SamahoNote Added: 0005866
2013-01-30 06:20Torr SamahoStatusneeds review => needs testing
2013-01-30 06:20Torr SamahoTarget Version => 1.1
2013-01-30 12:01DuskNote Added: 0005869
2013-04-05 17:52ArcoNote Added: 0006232
2013-04-05 19:33DuskStatusneeds testing => resolved
2013-04-05 19:33DuskFixed in Version => 1.1
2013-04-05 19:33DuskResolutionopen => fixed
2018-09-30 20:25Blzut3Statusresolved => closed

Notes
(0005843)
Dusk   
2013-01-28 14:24   
'https://bitbucket.org/CrimsonDusk/neurosphere/commits/7661d86c278d9c3381a4a7036d7b4aded8c7d16e [^]'
(0005847)
Torr Samaho   
2013-01-28 20:42   
Your patch should work, but it may be better to reset DamageType in PLAYER_SetDefaultSpectatorValues. That's where all the other special conditions (like the green and red screen tints) are reset and that function should cover all possible ways how a player can turn into a spectator.
(0005854)
Torr Samaho   
2013-01-29 06:15   
BTW: I can make these kind of tiny adjustments on my own and still make the commits in your name, if you'd like me to.
(0005857)
Dusk   
2013-01-29 11:28   
'https://bitbucket.org/CrimsonDusk/neurosphere/commits/3831 [^]'
Is this better?
(0005866)
Torr Samaho   
2013-01-30 06:18   
Thanks! The code is now perfect. Pulled.

Just a small remark for future collapsing: It would be nice if the log message only contained what actually happened in the end and not the intermediate steps (like Moved the damagetype clearing to player_setdefaultspectatorvalues). After the collapsing this information lost its meaning.
(0005869)
Dusk   
2013-01-30 12:01   
Quote
Just a small remark for future collapsing: It would be nice if the log message only contained what actually happened in the end and not the intermediate steps

I know - I just happened to already had pushed the changes and only then noticed on Bitbucket that it contained the other log message too - whoops.
(0006232)
Arco   
2013-04-05 17:52   
Fixed in latest version.