MantisBT - Zandronum
View Issue Details
0001112Zandronum[All Projects] Bugpublic2012-10-09 08:552024-04-08 17:47
Scorpion 
 
normalcrashsometimes
resolvedfixed 
MicrosoftWindowsXP/Vista/7
1.0 
3.23.2 
0001112: DM crashes when removing bots
When in a deathmatch game against bots and playing for a while, the game crashes when the bots are removed and then switching to spectator mode.

Thus far, it happens to me when I am playing against 7 or 8 bots, and nothing seems to go wrong when playing against 4. The problem seems to occur only after playing for a while. Not sure whether being in the lead or not has anything to do with it.
- Assign key to 'spectate' and 'addbot'
- menu -> multiplayer -> offline skirmish
  create deathmatch game, any skill#, map, or wad
  start game (without bots)
- press addbot key 7 or 8 times
- play
- open console, enter 'removebots', close console
- press spectate key
No tags attached.
related to 0000802resolved  Bot-activated scripts aren't terminated when bots are removed from the game 
zip dbguidedm.zip (7,831) 2012-10-09 15:40
https://zandronum.com/tracker/file_download.php?file_id=800&type=bug
zip CrashReport.zip (18,395) 2012-10-09 16:03
https://zandronum.com/tracker/file_download.php?file_id=801&type=bug
? zandronum-Garry.ini (22,662) 2012-10-09 16:03
https://zandronum.com/tracker/file_download.php?file_id=802&type=bug
patch botscrash.patch (1,962) 2024-01-28 08:13
https://zandronum.com/tracker/file_download.php?file_id=2897&type=bug
png error.png (8,633) 2024-03-13 14:27
https://zandronum.com/tracker/file_download.php?file_id=2936&type=bug
png
Issue History
2012-10-09 08:55ScorpionNew Issue
2012-10-09 14:59unknownnaNote Added: 0005057
2012-10-09 14:59unknownnaStatusnew => feedback
2012-10-09 15:11ScorpionNote Added: 0005058
2012-10-09 15:11ScorpionStatusfeedback => new
2012-10-09 15:39ScorpionNote Edited: 0005058bug_revision_view_page.php?bugnote_id=5058#r2762
2012-10-09 15:40ScorpionFile Added: dbguidedm.zip
2012-10-09 15:54unknownnaNote Added: 0005060
2012-10-09 15:55unknownnaStatusnew => feedback
2012-10-09 16:03ScorpionNote Added: 0005061
2012-10-09 16:03ScorpionStatusfeedback => new
2012-10-09 16:03ScorpionFile Added: CrashReport.zip
2012-10-09 16:03ScorpionFile Added: zandronum-Garry.ini
2012-10-09 22:13unknownnaNote Added: 0005065
2012-10-09 22:13unknownnaStatusnew => confirmed
2024-01-28 08:13Ru5tK1ngFile Added: botscrash.patch
2024-01-28 08:15Ru5tK1ngNote Added: 0023016
2024-01-28 08:15Ru5tK1ngStatusconfirmed => needs review
2024-03-12 04:59unknownnaNote Added: 0023367
2024-03-12 05:24Ru5tK1ngNote Added: 0023370
2024-03-12 05:41Ru5tK1ngNote Edited: 0023370bug_revision_view_page.php?bugnote_id=23370#r14123
2024-03-12 06:17unknownnaNote Added: 0023372
2024-03-13 08:44Ru5tK1ngNote Added: 0023380
2024-03-13 08:44Ru5tK1ngAssigned To => Ru5tK1ng
2024-03-13 08:44Ru5tK1ngStatusneeds review => feedback
2024-03-13 14:27unknownnaNote Added: 0023382
2024-03-13 14:27unknownnaFile Added: error.png
2024-03-13 16:26Ru5tK1ngNote Added: 0023385
2024-03-13 16:26Ru5tK1ngAssigned ToRu5tK1ng =>
2024-03-13 16:26Ru5tK1ngStatusfeedback => needs review
2024-03-16 01:15Ru5tK1ngRelationship addedrelated to 0000802
2024-04-07 20:32Ru5tK1ngNote Added: 0023528
2024-04-07 20:32Ru5tK1ngStatusneeds review => needs testing
2024-04-07 20:32Ru5tK1ngTarget Version => 3.2
2024-04-08 17:47Ru5tK1ngNote Added: 0023548
2024-04-08 17:47Ru5tK1ngStatusneeds testing => resolved
2024-04-08 17:47Ru5tK1ngResolutionopen => fixed
2024-04-08 17:47Ru5tK1ngFixed in Version => 3.2

Notes
(0005057)
unknownna   
2012-10-09 14:59   
It doesn't crash for me when following your steps. There's too little information. What files are you loading (skins/announcer folder)? What are the dmflags, dmflags2, dmflags3, compatflags, compatflags2 values?
(0005058)
Scorpion   
2012-10-09 15:11   
(edited on: 2012-10-09 15:39)
Clean Zandronum install (with Skulltag as subfolder).
No skins, ZanACG.pk3 and ZanGeneric.pk3 in announcer folder (latter is used).

dmflags: 20612; dmflags2: 512; compatflags: 0; compatflags2: 0

Most recently tried on DOOM2 MAP01, no additional PWADs loaded.

EDIT: Although it has happened to me once or twice with D2 MAP01, I seem to be able to recreate it more often with the attached PWAD.

(0005060)
unknownna   
2012-10-09 15:54   
What is skill, botskill, timelimit, fraglimit, pointlimit, duellimit, winlimit and wavelimit set to? Does it crash in both renderers? Does it only crash when you turn into a spectator? Do you have to win/lose a game first before it crashes?

I couldn't find any downloads for ZanACG.pk3 and ZanGeneric.pk3 anywhere.

Could you please upload your ini here? It doesn't crash for me.
(0005061)
Scorpion   
2012-10-09 16:03   
As I said, playing for a while with about 8 players is what does it.

Just tried again, 20 frags and typing REMOVEBOTS in the console and then closing the console did the trick, without having to go to spectator mode. - my apologies, I originally discovered the bug as a user rather than a bugtester.

I added the crashreport as well as my ini file.
(0005065)
unknownna   
2012-10-09 22:13   
Quote from Scorpion
I added the crashreport as well as my ini file.

Thank you very much for uploading your ini. I'm now able to reproduce the crashes on my end as well. It only crashes in the OpenGL renderer for me.
(0023016)
Ru5tK1ng   
2024-01-28 08:15   
I added a patch to resolve this crash. It seems that the bots being yanked so quickly caused a NULL pointer in gl_SetActorLights. GZDoom never made such a change pre3.0 (3.0 and above removed the file completely).
(0023367)
unknownna   
2024-03-12 04:59   
I can confirm it still crashes, since the patch of course wasn't added yet.
(0023370)
Ru5tK1ng   
2024-03-12 05:24   
(edited on: 2024-03-12 05:41)
I didn't make a merge request because I hadn't taken a closer look to why it crashes when bots are removed but not players. I suspect it has something to do with the order of PLAYER_SetDefaultSpectatorValues being called. By any chance can someone reproduce this bug on Gzdoom 1.8.6 or 1.9.0?

(0023372)
unknownna   
2024-03-12 06:17   
Testing GZDoom 1.8.6 with ZCajun bots for a while and removing them, and repeatedly doing it again, didn't yield any crashes compared to Zandronum.
(0023380)
Ru5tK1ng   
2024-03-13 08:44   
Can you test this build out and see if it resolves the crash? I believe just using 'removebot' can trigger this crash as well.

'https://www.mediafire.com/file/83ta32vlip91hy8/zandronum_3.2_r240311-0546M2.zip/file [^]'
(0023382)
unknownna   
2024-03-13 14:27   
"Removebots" seems to be fixed. I couldn't get it to crash.

Quote from Ru5tK1ng
I believe just using 'removebot' can trigger this crash as well.

I think you're right. I got this error when using "removebot", though I couldn't reproduce it again.

Thanks for the build!
(0023385)
Ru5tK1ng   
2024-03-13 16:26   
Thanks for testing. Merge request created.

'https://foss.heptapod.net/zandronum/zandronum-stable/-/merge_requests/54 [^]'
(0023528)
Ru5tK1ng   
2024-04-07 20:32   
The change was merged in:'https://foss.heptapod.net/zandronum/zandronum-stable/-/commit/ae34aedddd6fb58f56e4135d937a2f34c4d9ac53 [^]'
(0023548)
Ru5tK1ng   
2024-04-08 17:47   
Using the latest beta, this crash seems to be resolved.