MantisBT - Zandronum
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0001083Zandronum[All Projects] Bugpublic2012-09-28 18:302018-09-30 23:48
ReporterMazterQyoun-ae 
Assigned ToWatermelon 
PrioritylowSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformAllOSAllOS VersionAll
Product Version1.0 
Target Version1.4Fixed in Version1.4 
Summary0001083: [CTF] Flag can be picked up after game was finished
DescriptionNot really something that breaks the gameplay but still. In CTF, after one team member has bring the enemy flag to their own base so they score, if scorelimit was hit and there is a moving member of team on enemy base on the place where flag spawns, it will be picked up, hudmessage will appear and announcer will announce this.
Steps To Reproduce1. Create a CTF server
2. Have at least two players on red side and at least one on blue side
3. Keep playing until red has SCORELIMIT-1 scores
4. One of the red players should get enemy flag and run with it to the base
5. Another red player should keep moving on the blue flag spawn place
6. First red player should give red team last score, triggering a bug so second red player pickups the enemy flag.
Additional Information
TagsNo tags attached.
Relationships
has duplicate 0001084closed  [CTF] Flag can be picked up after game was finished 
related to 0002070resolved  in ctf, can score after timelimit is hit 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2012-09-28 18:30MazterQyoun-aeNew Issue
2012-09-28 18:35MazterQyoun-aeNote Added: 0004834
2012-09-28 18:41MazterQyoun-aeNote Deleted: 0004834
2012-09-28 22:29Blzut3ProjectSite => Zandronum
2012-09-29 00:51DuskRelationship addedhas duplicate 0001084
2012-09-29 01:00DuskProduct Version => 1.0
2012-10-06 17:03WatermelonNote Added: 0004999
2012-10-21 00:57unknownnaNote Added: 0005147
2012-10-21 00:57unknownnaStatusnew => confirmed
2012-10-22 19:24DuskAssigned To => Dusk
2012-10-22 19:24DuskStatusconfirmed => assigned
2013-04-25 16:20WatermelonNote Added: 0006296
2014-05-09 13:54WatermelonAssigned ToDusk => Watermelon
2014-06-07 19:25WatermelonAssigned ToWatermelon =>
2014-06-07 19:26WatermelonStatusassigned => confirmed
2014-10-11 14:33WatermelonNote Added: 0010485
2014-10-11 14:33WatermelonAssigned To => Watermelon
2014-10-11 14:33WatermelonStatusconfirmed => needs review
2014-10-11 14:34WatermelonNote Edited: 0010485bug_revision_view_page.php?bugnote_id=10485#r5688
2014-10-11 15:23WatermelonNote Added: 0010486
2014-10-11 15:30Torr SamahoNote Added: 0010488
2014-10-11 15:30Torr SamahoStatusneeds review => feedback
2014-10-12 00:56WatermelonNote Added: 0010516
2014-10-12 00:56WatermelonStatusfeedback => needs review
2014-10-12 08:03cobaltStatusneeds review => needs testing
2014-10-12 08:03cobaltTarget Version => 1.4
2014-10-12 08:03cobaltSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=5725#r5725
2014-10-12 08:03cobaltNote Added: 0010525
2015-01-18 01:22StrikerMan780Note Added: 0011413
2015-01-18 02:13WaTaKiDNote Added: 0011415
2015-01-18 10:45DuskNote Added: 0011427
2015-01-18 10:45DuskStatusneeds testing => resolved
2015-01-18 10:45DuskFixed in Version => 1.4
2015-01-18 10:45DuskResolutionopen => fixed
2015-01-18 11:02DuskRelationship addedrelated to 0002070
2018-09-30 23:48Blzut3Statusresolved => closed

Notes
(0004999)
Watermelon   
2012-10-06 17:03   
Today we just had someone score after the game was finished (the timer ran out and the velocity was enough to move the player onto the flag). They achieved a score even after the time ran out. I will check into this and see if it was maybe just a slight desync on my end or the player actually ended up scoring after the timelimit ended.
(0005147)
unknownna   
2012-10-21 00:57   
I can confirm both issues.
(0006296)
Watermelon   
2013-04-25 16:20   
'http://www.youtube.com/watch?v=phghxPc7R4A [^]'

Hopefully more proof it does happen
(0010485)
Watermelon   
2014-10-11 14:33   
(edited on: 2014-10-11 14:34)
Proposed fix (tested and all):

'https://bitbucket.org/ChrisKOmg/zandronum-stable/commits/c559a03f6c4528367be0a2c23e8175fb581e73ab [^]'

If it's good, I can create a patch with the modified history document to add this.
(0010486)
Watermelon   
2014-10-11 15:23   
Updated to a better function choice with Dusk's advice:

'https://bitbucket.org/ChrisKOmg/zandronum-stable/commits/673913aa566f6525a0ffe3f7c8386d8ac1fc6f5b [^]'
(0010488)
Torr Samaho   
2014-10-11 15:30   
Except for the comment that was apparently written for the old patch, the updated patch looks fine. If you add a history entry and fix the comment, I can pull it.
(0010516)
Watermelon   
2014-10-12 00:56   
Pull request sent.
(0010525)
cobalt   
2014-10-12 08:03   
Issue addressed by commit 60dc5a9f1f1c: Fixed: No longer can pick up team items in CTF or Skulltag after the round ends (fixes 1083).
Committed by WChrisK on Saturday 11 October 2014 20:53:57

2 files modified, 5 lines added, no lines removed
Files changed: docs/zandronum-history.txt, src/g_shared/a_flags.cpp
(0011413)
StrikerMan780   
2015-01-18 01:22   
After testing, you can no longer pick up the flag after the round ends.
(0011415)
WaTaKiD   
2015-01-18 02:13   
while the flag can no longer be picked up after the round ends, for what its worth, it is still possible to score after the timelimit is hit
(0011427)
Dusk   
2015-01-18 10:45   
That sounds like a separate issue, please make a new ticket for that.