MantisBT - Site
View Issue Details
0001069Site[All Projects] Bugpublic2012-09-26 15:132018-12-01 06:46
Qent 
Blzut3 
normalminoralways
closedno change required 
MicrosoftWindowsXP/Vista/7
0001069: Weird error in posts
limit 1, limit 2, gets replaced with LIMIT OFFSET 1LIMIT OFFSET 2
No tags attached.
Issue History
2012-09-26 15:13QentNew Issue
2012-09-27 01:09Blzut3Note Added: 0004820
2012-09-27 04:15QentNote Added: 0004824
2012-09-27 04:16QentNote Edited: 0004824bug_revision_view_page.php?bugnote_id=4824#r2630
2012-09-27 04:18QentNote Edited: 0004824bug_revision_view_page.php?bugnote_id=4824#r2631
2012-09-27 18:32Blzut3Note Added: 0004828
2012-09-27 18:33Blzut3Assigned To => Blzut3
2012-09-27 18:33Blzut3Statusnew => acknowledged
2012-10-01 15:57QentNote Added: 0004897
2012-10-01 21:37Blzut3Note Added: 0004904
2012-10-07 23:56QentNote Added: 0005047
2012-10-08 18:10Blzut3Note Added: 0005052
2013-09-27 10:59DuskNote Added: 0007285
2013-09-29 05:16Blzut3Note Added: 0007296
2016-03-20 16:14Dark-AssassinNote Added: 0014595
2016-03-20 19:44Blzut3Statusacknowledged => resolved
2016-03-20 19:44Blzut3Resolutionopen => no change required
2018-12-01 06:46Blzut3Statusresolved => closed

Notes
(0004820)
Blzut3   
2012-09-27 01:09   
Steps to reproduce?
(0004824)
Qent   
2012-09-27 04:15   
(edited on: 2012-09-27 04:18)
Make a post containing the phrase "limit 1, limit 2, fin" and then refresh the page. The actual post was'http://zandronum.com/forum/showthread.php?tid=1167&pid=14583#pid14583 [^]'

Quote
Depends on other settings. Probably duellimit 2, fraglimit 15, some newschool duel WAD.


Test thread:'http://zandronum.com/forum/showthread.php?tid=1175 [^]'

(0004828)
Blzut3   
2012-09-27 18:32   
'http://dev.mybb.com/issues/2110 [^]'

I don't think I can fully fix the issue, but I changed the regex so that it's more difficult to trigger. "LIMIT ([0-9]+),(?:[ ]+)?([0-9]+)" In other words to trigger now you need the word "limit" followed by a space, followed by a number, followed by a comma, followed by optionally any number of spaces, followed by another number. Before "limit <number>, " was enough.
(0004897)
Qent   
2012-10-01 15:57   
Thanks. Is there some feature that it's backing, that would be useful to know about?
(0004904)
Blzut3   
2012-10-01 21:37   
What do you mean? All forum database queries pass through that regular expression, so just avoid the phrase "limit number, number" and it should be fine.
(0005047)
Qent   
2012-10-07 23:56   
What I mean is, is there something useful that we would want to use "limit number, number" for?
(0005052)
Blzut3   
2012-10-08 18:10   
No. That's why I'm telling you to avoid the phrase.

It will trigger the bug on the forums as before. The only difference is it's restricted only to that specific phrase now.
(0007285)
Dusk   
2013-09-27 10:59   
This was fixed in 1.6.11 and was closed a month ago.
(0007296)
Blzut3   
2013-09-29 05:16   
Right, although if there hasn't been any one triggering my version of the fix. I don't really see a reason to back port the official fix until 1.6.11 comes out.
(0014595)
Dark-Assassin   
2016-03-20 16:14   
The forum software change invalidated this issue. It can now be closed.
This seemes to have been fixed anyway.