MantisBT - Zandronum
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0001027Zandronum[All Projects] Suggestionpublic2012-09-10 12:362018-09-30 23:53
Reporterunknownna 
Assigned ToWatermelon 
PrioritynormalSeverityfeatureReproducibilityN/A
StatusclosedResolutionfixed 
PlatformOSOS Version
Product Version1.0 
Target Version1.4Fixed in Version1.4 
Summary0001027: Ignore spectators when getting ready during a "changemap" map change
DescriptionAttached screenshot. Spectators shouldn't have the final say during "changemap" map changes when they're not even a part of the game to begin with.
Steps To Reproduce
Additional Information
TagsNo tags attached.
Relationships
Attached Filespng Screenshot_Doom_20120910_143124.png (36,883) 2012-09-10 12:36
/tracker/file_download.php?file_id=700&type=bug
png
Issue History
Date ModifiedUsernameFieldChange
2012-09-10 12:36unknownnaNew Issue
2012-09-10 12:36unknownnaFile Added: Screenshot_Doom_20120910_143124.png
2014-06-12 20:18WatermelonAssigned To => Watermelon
2014-06-12 20:18WatermelonStatusnew => assigned
2014-06-22 23:03WatermelonNote Added: 0009689
2014-06-22 23:03WatermelonStatusassigned => needs review
2014-06-23 04:18Blzut3Note Added: 0009702
2014-06-23 13:09DuskNote Added: 0009709
2014-06-23 14:02Konar6Note Added: 0009711
2014-06-23 19:24Torr SamahoNote Added: 0009719
2014-06-23 19:24Torr SamahoStatusneeds review => feedback
2014-08-03 15:53WatermelonStatusfeedback => assigned
2014-10-09 00:03WatermelonNote Added: 0010394
2014-10-09 00:03WatermelonAssigned ToWatermelon =>
2014-10-09 00:03WatermelonStatusassigned => new
2014-10-11 16:22WatermelonAssigned To => Watermelon
2014-10-11 16:22WatermelonStatusnew => assigned
2014-10-13 03:58WatermelonNote Added: 0010565
2014-10-13 03:58WatermelonStatusassigned => needs review
2014-10-25 13:38Torr SamahoNote Added: 0010684
2014-10-25 13:38Torr SamahoStatusneeds review => feedback
2014-10-26 20:09WatermelonNote Added: 0010697
2014-10-26 20:09WatermelonStatusfeedback => needs review
2014-10-26 21:13cobaltStatusneeds review => needs testing
2014-10-26 21:13cobaltTarget Version => 1.4
2014-10-26 21:13cobaltNote Added: 0010698
2015-01-18 02:54StrikerMan780Note Added: 0011416
2015-01-18 03:05ArcoStatusneeds testing => resolved
2015-01-18 03:05ArcoResolutionopen => fixed
2015-01-18 03:05ArcoFixed in Version => 1.4
2018-09-30 23:53Blzut3Statusresolved => closed

Notes
(0009689)
Watermelon   
2014-06-22 23:03   
Requesting input on this change:

'https://bitbucket.org/ChrisKOmg/zandronum-stable/commits/8381e8272bad3f6824f735fe839706917b960b7c [^]'

Additional thoughts:
Should this possibly be a cvar? Ex: sv_waitforspectatorready
(0009702)
Blzut3   
2014-06-23 04:18   
I would say no cvar. Is anyone really going to change it?
(0009709)
Dusk   
2014-06-23 13:09   
The padding is off though..
(0009711)
Konar6   
2014-06-23 14:02   
Also "bSpectating" should be replaced with PLAYER_IsTrueSpectator( player_t *pPlayer ). We don't want to ignore dead players, only true spectators.
(0009719)
Torr Samaho   
2014-06-23 19:24   
Yeah, dead spectators should definitely have a vote.
(0010394)
Watermelon   
2014-10-09 00:03   
Will handle this after a few other tickets
(0010565)
Watermelon   
2014-10-13 03:58   
Pull request made.
(0010684)
Torr Samaho   
2014-10-25 13:38   
I commented on the pull request on bitbucket.
(0010697)
Watermelon   
2014-10-26 20:09   
Updated and pull request sent.
(0010698)
cobalt   
2014-10-26 21:13   
Issue addressed by commit 6362a58ee5ed: Changed intermission proceeding to not rely on spectators if there is active players (fixes 1027).
Committed by WChrisK [Watermelon] on Sunday 26 October 2014 16:08:36

Changes in files:
 docs/zandronum-history.txt | 1 +
 src/sv_main.cpp | 44 ++++++++++++++++++++++++++++++++++++++++----
 2 files changed, 41 insertions(+), 4 deletions(-)
(0011416)
StrikerMan780   
2015-01-18 02:54   
Testing with WaTaKiD, we can conclude that this works.