MantisBT - Zandronum
View Issue Details
0001021Zandronum[All Projects] Bugpublic2012-09-07 08:192018-09-30 22:59
unknownna 
Edward-san 
normalminoralways
closedfixed 
1.0 
1.42.0 
0001021: Polyobjects don't play any sounds when closing online
This is specific to Zandronum 1.0.
1. zandronum.exe -host -file testdoor.wad
2. Connect a client to the server and join the game.
3. Push the switch.
testdoor.wad
No tags attached.
Issue History
2012-09-07 08:19unknownnaNew Issue
2012-09-07 08:20unknownnaStatusnew => confirmed
2012-09-07 21:33DuskAssigned To => Dusk
2012-09-07 21:33DuskStatusconfirmed => assigned
2012-09-07 21:48DuskNote Added: 0004616
2012-09-07 21:48DuskStatusassigned => needs review
2012-09-08 18:55Torr SamahoNote Added: 0004623
2012-09-08 19:00Torr SamahoStatusneeds review => feedback
2014-12-29 02:02Edward-sanNote Added: 0011116
2014-12-29 02:03Edward-sanAssigned ToDusk => Edward-san
2014-12-29 02:03Edward-sanStatusfeedback => needs review
2014-12-29 16:57cobaltStatusneeds review => needs testing
2014-12-29 16:57cobaltTarget Version => 1.4
2014-12-29 16:57cobaltSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=6192#r6192
2014-12-29 16:57cobaltNote Added: 0011128
2015-01-01 18:18ArcoNote Added: 0011177
2015-01-01 18:18ArcoSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=6226#r6226
2015-01-01 18:18ArcoStatusneeds testing => feedback
2015-01-01 18:20ArcoNote Edited: 0011177bug_revision_view_page.php?bugnote_id=11177#r6228
2015-01-01 18:27Torr SamahoNote Added: 0011181
2015-01-01 22:42LeonardNote Added: 0011201
2015-01-01 22:59Edward-sanNote Added: 0011203
2015-01-01 23:10Edward-sanNote Edited: 0011203bug_revision_view_page.php?bugnote_id=11203#r6245
2015-01-02 01:35Edward-sanNote Edited: 0011203bug_revision_view_page.php?bugnote_id=11203#r6249
2015-01-02 18:24Edward-sanNote Edited: 0011203bug_revision_view_page.php?bugnote_id=11203#r6268
2015-01-02 18:24Edward-sanStatusfeedback => needs testing
2015-01-02 18:25Edward-sanNote Edited: 0011203bug_revision_view_page.php?bugnote_id=11203#r6269
2015-01-02 18:41Torr SamahoNote Added: 0011227
2015-01-03 17:35Edward-sanNote Added: 0011243
2015-03-29 20:20DuskStatusneeds testing => resolved
2015-03-29 20:20DuskFixed in Version => 2.0
2015-03-29 20:20DuskResolutionopen => fixed
2018-09-30 22:59Blzut3Statusresolved => closed

Notes
(0004616)
Dusk   
2012-09-07 21:48   
Fixed
(0004623)
Torr Samaho   
2012-09-08 18:55   
In your patch the client doesn't get the value of m_Close but will always insert 0 as fourth argument of SN_StartSequence.
(0011116)
Edward-san   
2014-12-29 02:02   
I decided to go ahead and make a brute pull request, as I'd like to see this fixed for the next zandronum version.
(0011128)
cobalt   
2014-12-29 16:57   
Issue addressed by commit c7ac5ad10a85: - Fixed: a closing polyobject door made no sound online. (fixes 1021)
Committed by edward_san [edward-san] on Monday 29 December 2014 02:54:05

Changes in files:
 docs/zandronum-history.txt | 1 +
 src/cl_main.cpp | 45 ++++++++++++++++++++++++++++-----------------
 src/g_game.cpp | 2 +-
 src/network.h | 10 ----------
 src/network_enums.h | 1 +
 src/po_man.cpp | 21 ++++++++++++---------
 src/sv_commands.cpp | 14 ++++++++++++--
 src/sv_commands.h | 3 ++-
 8 files changed, 57 insertions(+), 40 deletions(-)
(0011177)
Arco   
2015-01-01 18:18   
(edited on: 2015-01-01 18:20)
The doortracks in the provided testwad appears to erroneously merge with the sectors. I tested this with r150101-1703.

(0011181)
Torr Samaho   
2015-01-01 18:27   
Can you elaborate? Also is this any different in 1.3?
(0011201)
Leonard   
2015-01-01 22:42   
In 1.3 :'http://i.imgur.com/AbxWKzS.jpg [^]'
In 2.0 :'http://i.imgur.com/er2I5k8.jpg [^]'

The door closing sound is properly playing and I think this bug is caused by something else and probably should be discussed in another ticket.
(0011203)
Edward-san   
2015-01-01 22:59   
(edited on: 2015-01-02 18:25)
I can confirm what Leonard found, I managed to reproduce that also in gzdoom 900 and in latest zdoom ...

[edit] Made a bug report about this.

[edit2]This bug report is regarding the door sound, so this should be still tested.

(0011227)
Torr Samaho   
2015-01-02 18:41   
Alright, so 0001021:0011201 is a separate issue and a ZDoom bug. The related discussion should be moved to another ticket then.
(0011243)
Edward-san   
2015-01-03 17:35   
I must inform that the issue in comment 0001021:0011201 is not fixable, because the design of the door was wrong to begin with, hence an user error.

Reference.