Anonymous | Login | Signup for a new account | 2024-04-23 17:50 UTC |
My View | View Issues | Change Log | Roadmap | Zandronum Issue Support Ranking | Rules | My Account |
View Issue Details [ Jump to Notes ] | [ Issue History ] [ Print ] | ||||||||
ID | Project | Category | View Status | Date Submitted | Last Update | ||||
0003769 | Zandronum | [All Projects] Bug | public | 2020-03-18 23:48 | 2024-02-29 21:13 | ||||
Reporter | sosleepy | ||||||||
Assigned To | |||||||||
Priority | normal | Severity | minor | Reproducibility | always | ||||
Status | resolved | Resolution | fixed | ||||||
Platform | OS | Ubuntu x86_64 | OS Version | Eoan | |||||
Product Version | 3.0 | ||||||||
Target Version | 3.1 | Fixed in Version | 3.1 | ||||||
Summary | 0003769: Bots tries to jump to reach item when sv_nojump is true | ||||||||
Description | WAD attached for easy reproduction of the issue. My guess is the issue can be easily solved by editing the ternary at line 464 in src/botpath.cpp to check the value of sv_nojump. I would appreciate if someone taught me how to have the current values of the server variables to try it myself. | ||||||||
Attached Files | testbot.wad [^] (2,716 bytes) 2020-03-18 23:48 | ||||||||
Notes | |
(0021232) sosleepy (reporter) 2020-03-24 22:10 |
Fixed, needs testing since this fix is fairly invasive. 'https://bitbucket.org/Torr_Samaho/zandronum/pull-requests/225/player-and-bots-shouldnt-attempt-to-jump/diff [^]' |
(0021234) sosleepy (reporter) 2020-03-25 01:12 |
Considering the locations this method is used, I would say it is a safe change. $ grep -R CalcJumpHeight src/botpath.cpp: fixed_t jumpheight = ( pActor->IsKindOf (RUNTIME_CLASS (APlayerPawn)) ) ? static_cast<APlayerPawn*>( pActor )->CalcJumpHeight( ) : 60; src/d_player.h: fixed_t CalcJumpHeight( bool bAddStep = true ); src/p_user.cpp:fixed_t APlayerPawn::CalcJumpHeight( bool bAddStepZ ) |
(0021238) sosleepy (reporter) 2020-03-25 19:00 |
There might be a better way, from these notes: 'https://zandronum.com/tracker/view.php?id=3775#c21236 [^]' 'https://zandronum.com/tracker/view.php?id=3775#c21237 [^]' The following values are relevant: BOTCMD_JUMP (59), BOTCMD_BEGINJUMPING (60), BOTCMD_STOPJUMPING (61). |
(0021244) Torr Samaho (administrator) 2020-03-29 19:17 |
I added your patch. |
(0023126) Ru5tK1ng (updater) 2024-02-29 21:13 |
Assuming the patch worked considering no new comment in almost 4 years. |
This issue is already marked as resolved. If you feel that is not the case, please reopen it and explain why. |
|
Supporters: | No one explicitly supports this issue yet. |
Opponents: | No one explicitly opposes this issue yet. |
Issue History | |||
Date Modified | Username | Field | Change |
2020-03-18 23:48 | sosleepy | New Issue | |
2020-03-18 23:48 | sosleepy | File Added: testbot.wad | |
2020-03-24 22:10 | sosleepy | Note Added: 0021232 | |
2020-03-25 01:12 | sosleepy | Note Added: 0021234 | |
2020-03-25 19:00 | sosleepy | Note Added: 0021238 | |
2020-03-29 19:17 | Torr Samaho | Note Added: 0021244 | |
2020-03-29 19:18 | Torr Samaho | Assigned To | => Torr Samaho |
2020-03-29 19:18 | Torr Samaho | Status | new => needs testing |
2020-03-29 19:19 | Torr Samaho | Assigned To | Torr Samaho => |
2024-02-29 21:13 | Ru5tK1ng | Note Added: 0023126 | |
2024-02-29 21:13 | Ru5tK1ng | Status | needs testing => resolved |
2024-02-29 21:13 | Ru5tK1ng | Resolution | open => fixed |
2024-02-29 21:13 | Ru5tK1ng | Status | resolved => feedback |
2024-02-29 21:13 | Ru5tK1ng | Resolution | fixed => reopened |
2024-02-29 21:13 | Ru5tK1ng | Status | feedback => resolved |
2024-02-29 21:13 | Ru5tK1ng | Resolution | reopened => fixed |
2024-02-29 21:13 | Ru5tK1ng | Fixed in Version | => 3.1 |
2024-02-29 21:13 | Ru5tK1ng | Target Version | => 3.1 |
Copyright © 2000 - 2024 MantisBT Team |