Zandronum Chat on our Discord Server Get the latest version: 3.1
Source Code

View Issue Details Jump to Notes ] Issue History ] Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0003205Zandronum[All Projects] Bugpublic2017-07-28 02:162024-03-01 05:06
ReporterJPL 
Assigned To 
PrioritynormalSeverityminorReproducibilityalways
Statusneeds reviewResolutionopen 
PlatformAllOSWindowsOS VersionXP/Vista/7
Product Version4.0-beta 
Target VersionFixed in Version 
Summary0003205: AddOptionMenu entry in MENUDEF crashes
DescriptionI use an AddOptionMenu block in the MENUDEF for WadSmoosh to provide a couple legacy back-compat options. This works fine in recent versions of GZDoom but not in any version of Zandronum. It would be nice if Zandronum could either support or ignore AddOptionMenu so that I can point users seeking Zandronum support for WadSmoosh to your latest version.
Steps To Reproduce1. Create a WAD with a MENUDEF lump
2. Add an AddOptionMenu block to the MENUDEF that defines an addition to the options menu
3. Open the WAD in Zandronum
Attached Filespatch file icon add_option_menu.patch [^] (1,353 bytes) 2018-01-18 19:18 [Show Content]

- Relationships

-  Notes
User avatar (0018116)
JPL (reporter)
2017-07-29 17:53

Here's the relevant commit from GZDoom, seems like it should be straightforward to merge:

'https://github.com/drfrag666/gzdoom/commit/559d3093ed0d32da71f245cd96ccfe89047aed6b [^]'
User avatar (0018999)
aitap (reporter)
2018-01-18 19:19

It was almost straightforward, because FMenuDescriptor is not a DObject, but we can use dynamic_cast instead. I have attached a patch from latest commit as of today.
User avatar (0021265)
KG_Guy (reporter)
2020-04-13 10:47

Could you explain to a non-programmer how to get this to work? Am I supposed to put names in or something?
User avatar (0021306)
sosleepy (reporter)
2020-05-03 00:28

Bumping this since this contain a patch.
User avatar (0023147)
Ru5tK1ng (updater)
2024-03-01 05:06

I'll set this to Needs Review. I'll see if this qualifies for an out of sync backport since it fixes a crash.

Issue Community Support
Only registered users can voice their support. Click here to register, or here to log in.
Supporters: aitap mifu Michaelis
Opponents: No one explicitly opposes this issue yet.

- Issue History
Date Modified Username Field Change
2017-07-28 02:16 JPL New Issue
2017-07-29 17:53 JPL Note Added: 0018116
2018-01-18 19:18 aitap File Added: add_option_menu.patch
2018-01-18 19:19 aitap Note Added: 0018999
2020-04-13 10:47 KG_Guy Note Added: 0021265
2020-05-03 00:28 sosleepy Note Added: 0021306
2024-03-01 05:06 Ru5tK1ng Note Added: 0023147
2024-03-01 05:06 Ru5tK1ng Status new => needs review






Questions or other issues? Contact Us.

Links


Copyright © 2000 - 2024 MantisBT Team
Powered by Mantis Bugtracker