Zandronum Chat on our Discord Server Get the latest version: 3.1
Source Code
My View | View Issues | Change Log | Roadmap | Doomseeker Issue Support Ranking | Rules | My Account
  

View Issue Details [ Jump to Notes ] [ Issue History ] [ Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0003838DoomseekerUIpublic2020-06-26 17:292022-03-22 11:12
ReporterWubTheCaptain 
Assigned ToZalewa 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionwon't fix 
PlatformOSOS Version
Product Version1.3.1 
Target VersionFixed in Version 
Summary0003838: In Create Game, "Flags" tab does not have a disabled state; the tab either exists, or it doesn't – inconsistency
DescriptionCreate Game has at least two tabs of importance to this issue: "Rules" and "Server". These always exist for any game engine, but depending on engine support (and online play features) these tabs may have an enabled or disabled state in the UI. This is as intended, clean/consistent UI.
Then, there are plugins (Odamex, Sonic Robo Blast 2, Zandronum) that create new tabs. Odamex and Sonic Robo Blast 2 create a tab called "Flags"; Zandronum names this new tab as "Zandronum". Functionally they are more or less the same, ideologically: To set game options (flags) specific to that engine.
In comparison, engines which do not support customization of "flags" don't get this "Flags" tab with a disabled UI state. The tab either exists in "enabled" state, or the tab doesn't exist. This sucks.
Steps To ReproduceFiddle with Create Game with all typical engines enabled. I'm sure you'll understand enough from the description and attached screenshots.
Attached Filespng file icon 2020-06-26-173015_maim.png [^] (8,222 bytes) 2020-06-26 17:31


png file icon 2020-06-26-173021_maim.png [^] (7,689 bytes) 2020-06-26 17:31


png file icon 2020-06-26-173026_maim.png [^] (8,858 bytes) 2020-06-26 17:31


png file icon 2020-06-26-173035_maim.png [^] (8,053 bytes) 2020-06-26 17:31


png file icon 2020-06-26-173041_maim.png [^] (8,288 bytes) 2020-06-26 17:32


png file icon 2021-08-16-194513_maim.png [^] (8,700 bytes) 2021-08-16 19:45

- Relationships
related to 0003866closedZalewa Add Q-Zandronum plugin 

-  Notes
User avatar (0021477)
WubTheCaptain (reporter)
2020-06-26 17:32
edited on: 2020-06-26 17:32

 Suggesting the Create Game UI redesign in 0003480 as part of a fix.
User avatar (0021481)
WubTheCaptain (reporter)
2020-06-26 18:09
edited on: 2020-06-26 18:19

 This inconsistency is more aggravating, because under "Rules" tab every feature is engine-specific (using shared widgets). But at least the "Rules" tab has an enabled/disabled state, and that makes it well-behaving.
I can't say "Flags" / "Zandronum" to be well-behaving in this regard, though they use unique widgets.
User avatar (0021736)
WubTheCaptain (reporter)
2021-08-16 19:45
edited on: 2021-08-16 19:47

 The Q-Zandronum plugin is affected by this issue, since its introduction in version 1.3.2 (0003866).
User avatar (0022020)
Zalewa (developer)
2021-12-27 23:06
edited on: 2021-12-27 23:07

 The plugin is free to create an extra tab or not. If it doesn't, there's nothing to show and disable. The Zandronum plugin creates the Zandronum tab, and Doomseeker itself doesn't control it.

The Flags tab is indeed a part of Doomseeker, so according to your proposal we could show it always and have it disabled. But then, when it comes to Zandronum, the Zandronum tab is a complete replacement for the Flags tab. Therefore it doesn't make sense for Zandronum to have the Flags tab disabled and the Zandronum tab next to it.

This means that the consistent well-behaving state is the opposite to what you're suggesting: all tabs that don't have any functionality for the given engine should disappear.
User avatar (0022026)
WubTheCaptain (reporter)
2021-12-28 10:41
edited on: 2021-12-28 10:42
Quote from Zalewa
The Flags tab is indeed a part of Doomseeker, so according to your proposal we could show it always and have it disabled.

Yes please (sort of).
Quote from Zalewa
But then, when it comes to Zandronum, the Zandronum tab is a complete replacement for the Flags tab. Therefore it doesn't make sense for Zandronum to have the Flags tab disabled and the Zandronum tab next to it.

That's a fair point, but it beats me why this isn't titled "Flags" in the UI for consistency. We are already hiding the Doomseeker native "Flags" tab.
Quote from Zalewa
This means that the consistent well-behaving state is the opposite to what you're suggesting: all tabs that don't have any functionality for the given engine should disappear.

Shit user story: I want to use muscle memory to click the correct tab in a consistent location, even if the tab is disabled.
User avatar (0022028)
Zalewa (developer)
2021-12-28 11:15
Quote from Wub
it beats me why this isn't titled "Flags" in the UI for consistency

Because "Flags" is for setting the DM Flags and nothing else, while the Zandronum tab does much more than that.

Quote from Wub
I want to use muscle memory to click the correct tab in a consistent location, even if the tab is disabled.

And it would be consistent within a game. When you change the game the UI needs to adapt because the games are different. Various other things appear and disappear too in different places, so the muscle memory point is moot already.

Issue Community Support
This issue is already marked as resolved.
If you feel that is not the case, please reopen it and explain why.
Supporters: No one explicitly supports this issue yet.
Opponents: No one explicitly opposes this issue yet.

- Issue History
Date Modified Username Field Change
2020-06-26 17:29 WubTheCaptain New Issue
2020-06-26 17:31 WubTheCaptain File Added: 2020-06-26-165232_maim.png
2020-06-26 17:31 WubTheCaptain File Deleted: 2020-06-26-165232_maim.png
2020-06-26 17:31 WubTheCaptain File Added: 2020-06-26-173015_maim.png
2020-06-26 17:31 WubTheCaptain File Added: 2020-06-26-173021_maim.png
2020-06-26 17:31 WubTheCaptain File Added: 2020-06-26-173026_maim.png
2020-06-26 17:31 WubTheCaptain File Added: 2020-06-26-173035_maim.png
2020-06-26 17:32 WubTheCaptain File Added: 2020-06-26-173041_maim.png
2020-06-26 17:32 WubTheCaptain Note Added: 0021477
2020-06-26 17:32 WubTheCaptain Note Edited: 0021477 View Revisions
2020-06-26 17:36 WubTheCaptain Note Added: 0021478
2020-06-26 17:37 WubTheCaptain Note Edited: 0021478 View Revisions
2020-06-26 17:39 WubTheCaptain Note Deleted: 0021478
2020-06-26 18:09 WubTheCaptain Note Added: 0021481
2020-06-26 18:13 WubTheCaptain Note Edited: 0021481 View Revisions
2020-06-26 18:14 WubTheCaptain Note Edited: 0021481 View Revisions
2020-06-26 18:19 WubTheCaptain Note Edited: 0021481 View Revisions
2021-08-16 19:45 WubTheCaptain File Added: 2021-08-16-194513_maim.png
2021-08-16 19:45 WubTheCaptain Note Added: 0021736
2021-08-16 19:46 WubTheCaptain Note Edited: 0021736 View Revisions
2021-08-16 19:47 WubTheCaptain Note Edited: 0021736 View Revisions
2021-08-16 19:54 WubTheCaptain Relationship added related to 0003866
2021-12-27 23:06 Zalewa Note Added: 0022020
2021-12-27 23:07 Zalewa Note Edited: 0022020 View Revisions
2021-12-28 10:41 WubTheCaptain Note Added: 0022026
2021-12-28 10:41 WubTheCaptain Assigned To => Zalewa
2021-12-28 10:41 WubTheCaptain Status new => feedback
2021-12-28 10:42 WubTheCaptain Note Edited: 0022026 View Revisions
2021-12-28 11:15 Zalewa Note Added: 0022028
2021-12-28 12:22 WubTheCaptain Status feedback => resolved
2021-12-28 12:22 WubTheCaptain Resolution open => won't fix
2022-03-22 11:12 WubTheCaptain Status resolved => closed




Questions or other issues? Contact Us.

Links

Copyright © 2000 - 2024 MantisBT Team
Powered by Mantis Bugtracker