Anonymous | Login | Signup for a new account | 2024-03-28 10:27 UTC |
My View | View Issues | Change Log | Roadmap | Doomseeker Issue Support Ranking | Rules | My Account |
View Issue Details [ Jump to Notes ] | [ Issue History ] [ Print ] | ||||||||
ID | Project | Category | View Status | Date Submitted | Last Update | ||||
0003672 | Doomseeker | [All Projects] Bug | public | 2019-06-28 08:35 | 2019-07-30 10:15 | ||||
Reporter | WubTheCaptain | ||||||||
Assigned To | Zalewa | ||||||||
Priority | normal | Severity | minor | Reproducibility | have not tried | ||||
Status | closed | Resolution | no change required | ||||||
Platform | OS | OS Version | |||||||
Product Version | 1.2 | ||||||||
Target Version | Fixed in Version | ||||||||
Summary | 0003672: Zeroing memory with memset() in SRB2 plugin may get optimized out by the compiler | ||||||||
Description | Using explicit_bzero() or memset_s() (with __STDC_LIB_EXT1__) could prevent the compiler from optimizing zeroing memory away in the SRB2 plugin. | ||||||||
Steps To Reproduce | src/plugins/srb2/srb2masterclient.cpp: memset(this, 0, sizeof(Header)); src/plugins/srb2/srb2server.cpp: memset(this, 0, sizeof(Header)); src/plugins/srb2/srb2server.cpp: memset(this, 0, sizeof(D)); src/plugins/srb2/srb2server.cpp: memset(this, 0, sizeof(D)); | ||||||||
Additional Information | 'https://man.openbsd.org/explicit_bzero.3 [^]' 'https://media.ccc.de/v/35c3-9788-memsad [^]' 'https://fahrplan.events.ccc.de/congress/2018/Fahrplan/events/9788.html [^]' | ||||||||
Attached Files | |||||||||
Notes | |
(0020843) WubTheCaptain (reporter) 2019-06-28 08:35 |
NB: I didn't find the data sensitive (server headers), so I don't consider this as a security bug. |
(0020848) Zalewa (developer) 2019-06-30 10:19 |
What are the undesireable side effects of such optimization happening in these specified instances? |
(0020854) WubTheCaptain (reporter) 2019-06-30 11:27 |
No undesirable side effects I can see, or at least I would assume. (grepping is harder.) |
(0020857) Zalewa (developer) 2019-06-30 11:38 |
Resolving as no change required. |
This issue is already marked as resolved. If you feel that is not the case, please reopen it and explain why. |
|
Supporters: | No one explicitly supports this issue yet. |
Opponents: | No one explicitly opposes this issue yet. |
Issue History | |||
Date Modified | Username | Field | Change |
2019-06-28 08:35 | WubTheCaptain | New Issue | |
2019-06-28 08:35 | WubTheCaptain | Note Added: 0020843 | |
2019-06-30 10:19 | Zalewa | Note Added: 0020848 | |
2019-06-30 11:26 | WubTheCaptain | Assigned To | => WubTheCaptain |
2019-06-30 11:26 | WubTheCaptain | Status | new => feedback |
2019-06-30 11:26 | WubTheCaptain | Assigned To | WubTheCaptain => Zalewa |
2019-06-30 11:27 | WubTheCaptain | Note Added: 0020854 | |
2019-06-30 11:27 | WubTheCaptain | Status | feedback => assigned |
2019-06-30 11:38 | Zalewa | Note Added: 0020857 | |
2019-06-30 11:38 | Zalewa | Status | assigned => resolved |
2019-06-30 11:38 | Zalewa | Fixed in Version | => 1.3 |
2019-06-30 11:38 | Zalewa | Resolution | open => no change required |
2019-06-30 11:43 | WubTheCaptain | Fixed in Version | 1.3 => |
2019-07-30 10:15 | WubTheCaptain | Status | resolved => closed |
Copyright © 2000 - 2024 MantisBT Team |