Anonymous | Login | Signup for a new account | 2024-04-24 12:29 UTC |
My View | View Issues | Change Log | Roadmap | Zandronum Issue Support Ranking | Rules | My Account |
View Issue Details [ Jump to Notes ] | [ Issue History ] [ Print ] | ||||||||
ID | Project | Category | View Status | Date Submitted | Last Update | ||||
0001967 | Zandronum | [All Projects] Bug | public | 2014-10-20 03:32 | 2020-04-11 00:38 | ||||
Reporter | EnsaladaDeTomate | ||||||||
Assigned To | Torr Samaho | ||||||||
Priority | high | Severity | crash | Reproducibility | always | ||||
Status | resolved | Resolution | fixed | ||||||
Platform | Microsoft | OS | Windows | OS Version | XP/Vista/7 | ||||
Product Version | 1.3 | ||||||||
Target Version | Fixed in Version | ||||||||
Summary | 0001967: Zandronum crashes for no known reason | ||||||||
Description | Title says it all. | ||||||||
Steps To Reproduce | zandronum -file samsara-v0.3.pk3 samsara_extraheroesv1.1_crashreport.pk3 -host +sv_cheats 1 Select "Caleb" as the class you will play, then warp to a map where you can find a BFG9000, pick it up, (you will need to get some "Ammo 4" type first to make this work, because that weapon doesnt give any ammo when picked), after that, select the BFG tier (slot 7 > "Life Leech" for Caleb class), press "Alt Fire", and wait. (This can be done faster with cheats too, by writing summon bfg9000, and summon ammo4big). 1. zandronum -iwad doom2.wad -file inventory_02.wad -host 2. zandronum -iwad doom2.wad -file inventory_02.wad -connect localhost 3. Join the game. 4. Fire the pistol. | ||||||||
Additional Information | Samsara-0.3.pk3 Link >'http://www.best-ever.org/download?file=samsara-v0.3.pk3 [^]' Samsara_ExtraHeroesv1.1_crashreport.pk3 Link >'http://www.best-ever.org/download?file=samsara_extraheroesv1.1_crashreport.pk3 [^]' | ||||||||
Attached Files | inventory_02.wad [^] (676 bytes) 2015-06-10 08:36 | ||||||||
Notes | |
(0010639) Watermelon (developer) 2014-10-20 03:58 edited on: 2014-10-20 12:49 |
I don't know why this is saying my source is different from 1.3 when I pull from the repo at the 1.3 tag... oh well: The minidump leads me to: Thingdef expression ExpVal FxMultiNameState::EvalExpression (AActor *self) { ExpVal ret; ret.Type = VAL_State; ret.pointer = self->GetClass()->ActorInfo->FindState(names.Size(), &names[0]); <-- Null pointer Stack trace:
================================================ This is from a Linux GDB trace, confirms the above
AActor *self is null @ FxMultiNameState::EvalExpression() at doom/zandronum/stable/zandronum_stable/src/thingdef/thingdef_expression.cpp:2681 Further inspection shows that stateowner is null when calling this: FState::CallAction() at doom/zandronum/stable/zandronum_stable/src/info.h:111 ActionFunc(self, stateowner, this, ParameterIndex-1, statecall); It appears in p_pspr.cpp at line 121: player->ReadyWeapon is null Crash in 1.3 Crash in 1.2.2 Crash in 1.2.1 No crash in 1.2 |
(0010641) Watermelon (developer) 2014-10-20 13:06 |
I isolated the bug to being introduced in revision 3719: Addition of the client movement buffer. |
(0010643) Torr Samaho (administrator) 2014-10-20 17:40 edited on: 2014-10-20 19:41 |
Since neither 1.2.1, not 1.2.2 had the new buffer, the following two statements contradict each other:Quote from Watermelon Quote from Watermelon Which one is correct? EDIT: I had a quick look and I'd say the second statement is correct. I'll look at this in more detail. |
(0010941) Torr Samaho (administrator) 2014-11-23 14:04 |
This should at least fix the crash. To find out what is really happening I need a minimal example wad. |
(0010968) EnsaladaDeTomate (reporter) 2014-11-25 03:37 edited on: 2014-11-25 03:48 |
Arent the provided links working? If not, i can upload them again. PD: Also, i already could test'd it, but i havent got enough time atm, university is beign heavily insane. |
(0010970) Watermelon (developer) 2014-11-25 11:25 |
That link is working for me |
(0010973) Torr Samaho (administrator) 2014-11-25 17:44 |
The links are working just fine and I used the example files to develop the tentative fix. But your files are nowhere near a minimal example. To really understand what the mod is doing there and why it's problematic requires an example that is stripped down to the absolute minimum. It's completely infeasible to wade through a mod of Samsara's size to debug this. |
(0010977) EnsaladaDeTomate (reporter) 2014-11-26 01:34 |
Ohhhhhh kk, i got it now, sorry, sometimes my lack of english just derps over me, i didnt got that u were trying to said that. Also, i dunno how can i help on that, since i dont have that much experience on WADs. |
(0011071) haxmurderer (reporter) 2014-12-17 03:32 |
Torr, can you give us a commit number or something to test with? How can I find out which commit you fixed this in? |
(0011072) Edward-san (developer) 2014-12-17 11:10 |
There is no fixing commit to test with yet, because no one provided the minimum example wad, as Torr asked many times. |
(0012627) unknownna (updater) 2015-06-10 08:38 edited on: 2015-06-10 08:50 |
It crashes when it decides whether to jump or not (A_JumpIfInventory) immediately after the weapon has removed itself (A_TakeInventory) from the player's inventory. If the client has no other weapons in the inventory after the weapon has removed itself, the client also crashes. If I add a single 1 tic frame before A_JumpIfInventory is called or add 1 tic to the frame that calls A_TakeInventory, it stops crashing. Actor Pistol_02 : Pistol |
(0012628) Edward-san (developer) 2015-06-10 09:17 |
Can you crash with'https://www.dropbox.com/s/76gxuvlsq9yhb9k/zandronum-2.1-150604-1440-9b91f0c-windows.zip?dl=0 [^]' ? |
(0012630) unknownna (updater) 2015-06-10 09:37 edited on: 2015-06-10 09:46 |
No, it's actually fixed in 2.0. I made the example WAD to help Torr with pinpointing out the exact cause, hoping that it would shed some light on what's going on. |
(0012639) EnsaladaDeTomate (reporter) 2015-06-10 16:45 edited on: 2015-06-10 16:48 |
I also noticed in the weapon code that if i keep the A_takeinventory part with 0 tic or if i add 1 tic, the turrets will still not beign spawned, but if i add 2 tics, the turrets will spawn normally. This wasnt happening in zandy 1.2 Edit:(the crash and turrets not beign spawned started since zandy 1.2.1+, as watermelon stated) |
(0021259) Ru5tK1ng (updater) 2020-04-11 00:38 |
Marking as resolved based on'https://zandronum.com/tracker/view.php?id=1967#c12630 [^]' |
This issue is already marked as resolved. If you feel that is not the case, please reopen it and explain why. |
|
Supporters: | No one explicitly supports this issue yet. |
Opponents: | No one explicitly opposes this issue yet. |
Issue History | |||
Date Modified | Username | Field | Change |
2014-10-20 03:32 | EnsaladaDeTomate | New Issue | |
2014-10-20 03:58 | Watermelon | Note Added: 0010639 | |
2014-10-20 12:12 | Watermelon | Note Added: 0010640 | |
2014-10-20 12:17 | Watermelon | Note Edited: 0010640 | View Revisions |
2014-10-20 12:23 | Watermelon | Note Edited: 0010640 | View Revisions |
2014-10-20 12:24 | Watermelon | Note Edited: 0010640 | View Revisions |
2014-10-20 12:25 | Watermelon | Note Edited: 0010640 | View Revisions |
2014-10-20 12:26 | Watermelon | Note Edited: 0010639 | View Revisions |
2014-10-20 12:26 | Watermelon | Note Deleted: 0010640 | |
2014-10-20 12:32 | Watermelon | Note Edited: 0010639 | View Revisions |
2014-10-20 12:46 | Watermelon | Note Edited: 0010639 | View Revisions |
2014-10-20 12:46 | Watermelon | Status | new => confirmed |
2014-10-20 12:49 | Watermelon | Note Edited: 0010639 | View Revisions |
2014-10-20 12:49 | Watermelon | Note Edited: 0010639 | View Revisions |
2014-10-20 13:06 | Watermelon | Note Added: 0010641 | |
2014-10-20 17:40 | Torr Samaho | Note Added: 0010643 | |
2014-10-20 19:41 | Torr Samaho | Note Edited: 0010643 | View Revisions |
2014-11-23 13:34 | Torr Samaho | Steps to Reproduce Updated | View Revisions |
2014-11-23 14:04 | Torr Samaho | Note Added: 0010941 | |
2014-11-23 14:31 | Torr Samaho | Assigned To | => Torr Samaho |
2014-11-23 14:31 | Torr Samaho | Status | confirmed => needs testing |
2014-11-25 03:37 | EnsaladaDeTomate | Note Added: 0010968 | |
2014-11-25 03:48 | EnsaladaDeTomate | Note Edited: 0010968 | View Revisions |
2014-11-25 11:25 | Watermelon | Note Added: 0010970 | |
2014-11-25 17:44 | Torr Samaho | Note Added: 0010973 | |
2014-11-26 01:34 | EnsaladaDeTomate | Note Added: 0010977 | |
2014-12-17 03:32 | haxmurderer | Note Added: 0011071 | |
2014-12-17 11:10 | Edward-san | Note Added: 0011072 | |
2015-06-10 08:36 | unknownna | File Added: inventory_02.wad | |
2015-06-10 08:36 | unknownna | Steps to Reproduce Updated | View Revisions |
2015-06-10 08:38 | unknownna | Note Added: 0012627 | |
2015-06-10 08:39 | unknownna | Note Edited: 0012627 | View Revisions |
2015-06-10 08:50 | unknownna | Note Edited: 0012627 | View Revisions |
2015-06-10 09:17 | Edward-san | Note Added: 0012628 | |
2015-06-10 09:37 | unknownna | Note Added: 0012630 | |
2015-06-10 09:46 | unknownna | Note Edited: 0012630 | View Revisions |
2015-06-10 16:45 | EnsaladaDeTomate | Note Added: 0012639 | |
2015-06-10 16:48 | EnsaladaDeTomate | Note Edited: 0012639 | View Revisions |
2020-04-11 00:38 | Ru5tK1ng | Note Added: 0021259 | |
2020-04-11 00:38 | Ru5tK1ng | Status | needs testing => resolved |
2020-04-11 00:38 | Ru5tK1ng | Resolution | open => fixed |
Copyright © 2000 - 2024 MantisBT Team |