The Golden Super Shotgun v4 + Overpowered Version!

[Screenracer]

why the blue shells tho? if you going to make the shells in the hud blue you might also want to add a sprite for the ammo pickup.

Ok, ill work on it.

[Screenracer]

Does anyone have any idea why this DECORATE code isnt working?

ACTOR GoldSuperShotgun : Weapon 16752
{
SpawnID 16752
Weapon.AmmoUse 2
Weapon.AmmoGive 8
Weapon.AmmoType "Shell"
Inventory.PickupMessage "You got the GoldSuperShotgun"

States
{
Ready:
GSHT2 A 1 A_WeaponReady
Loop
Deselect:
GSHT2 A 1 A_Lower
Loop
Select:
GSHT2 A 1 A_Raise
Loop
Fire:
GSHT2 A 3
GSHT2 A 7 A_FireShotgun2
GSHT2 B 7
GSHT2 C 7 A_CheckReload
GSHT2 D 7 A_OpenShotgun2
GSHT2 E 7
GSHT2 F 7 A_LoadShotgun2
GSHT2 G 6
GSHT2 H 6 A_CloseShotgun2
GSHT2 A 5 A_ReFire
Goto Ready
// unused states
GSHT2 B 7
GSHT2 A 3
Goto Deselect
Flash:
GSHT2 I 4 Bright A_Light1
GSHT2 J 3 Bright A_Light2
Goto LightDone
Spawn:
GSGN2 A -1
Stop
}
}

[Lollipop]

1. please specify your error when you got one.
2. you probably shouldn't have "goto deselect" put in the fire state, as that will make the weapon deselect each time you fire it.
3. what are those "A_checkreload", "A_OpenShotgun2", "A_LoadShotgun2" and "A_CloseShotgun2" for some states? are they made by you or are they original? I can recomment using A_firebullets for fireing hitscan weapons.

[Screenracer]

1. please specify your error when you got one.

when I type in the console "give GoldSuperShotgun" it says its a unknown item.

[Lollipop]

try and remove the spawn ID, might be causing you a problem, as far as I remember, the max number for that is 255...

[Screenracer]

Still says unknown item, I tried setting the spawnID to 166 and tried removing it and still the same error.

[Lollipop]

try removing pats of the code a little by a little, trying to track the sinner.

[Echo]

I've never used the SpawnID parameter in any custom weapons. It's not really required for anything outside of ACS dickery.

[Lollipop]

Well, not even nessesary for anything at all anymore, as kind of all spawning functions have a version that uses the actor name instead of the id of the actor, so there is no real reason for having it so you should just remove it.

[Screenracer]

Do you think that its because the state sprites are not right?

[Lollipop]

no, then za would give you a generic error telling you that the sprite names must be exact 4 caracters or something similar to that.
btw, REMOVE GOTO DESELECT!
also, your select and deselect states shouldnt have a loop in them, that can cause the problem too.

[Screenracer]

I did remove it, this is what I have now.

ACTOR GoldSuperShotgun : Weapon 16752
{
Weapon.AmmoUse 2
Weapon.AmmoGive 8
Weapon.AmmoType "Shell"
Inventory.PickupMessage "You got the GoldSuperShotgun"

States
{
Ready:
GSHT2 A 0 A_WeaponReady
Loop
Deselect:
GSHT2 A 0 A_Lower
Loop
Select:
GSHT2 A 0 A_Raise
Loop
Fire:
GSHT2 A 3
GSHT2 A 7
GSHT2 B 7
GSHT2 C 7
GSHT2 D 7
GSHT2 E 7
GSHT2 F 7
GSHT2 G 6
GSHT2 H 6
GSHT2 A 5 A_ReFire
Goto Ready

Flash:
GSHT2 I 4 Bright A_Light1
GSHT2 J 3 Bright A_Light2
Goto LightDone
Spawn:
GSGN2 A -1
Stop
}
}

Also, after the states sprites what does the number mean? Like how it is like this: GSHT2 A 3 because no sprite in the wad dictionary has the number of 3.

[Echo]

Your spritenames are too long by one digit.

GSHT2 won't be recognised. Rename the sprites to GSH2 or something, and change the code accordingly.

[Lollipop]

that was so basic I did not notice, silly me.
also, those loops can cause errors for you I believe, as the end of the sate will restart the sate creating an infinite loop.

[Screenracer]

Ill post the WAD archive if that helps any.

EDIT: Damn mediafire, acting wierd. It may take a bit to upload.

[Echo]

Try SpeedyShare or FileSmelt.

[Screenracer]

Alright mediafire was acting up so I uploaded it to 4shared.

http://www.4shared.com/zip/JsZ4BhMa/Scr ... eview.html

[Echo]

Holy Christ, what a clusterfuck.

1) Only SPRITES go between S_START/S_END markers. DECORATE and sound lumps belong outside of these markers.
2) You still have sprite lumps with fewer than four characters for their name.
3) DECORATE is still trying to reference sprite names with five characters.
4) Weapon doesn't have a slot assignment.
5) Spawn frame is followed by STOP, meaning that the item is erased from the map.
6) Frame durations are at 0 for raise/lower, so even after fixing all that it still goes and crashes ZDoom.
7) Fixing that... there are no attack functions. Weapon just animates harmlessly.

What the hell is this.

Edit:

Code: Select all

ACTOR GoldSuperShotgun : SuperShotgun 16752
{
  Weapon.AmmoUse 2
  Weapon.AmmoGive 8
  Weapon.AmmoType "Shell"
  Inventory.PickupMessage "You got the GoldSuperShotgun"
  Weapon.SlotNumber 0
  Height 16
  Radius 16
  States
  {
  Ready:
    GSH2 A 1 A_WeaponReady
    Loop
  Deselect:
    GSH2 A 1 A_Lower
    Loop
  Select:
    GSH2 A 1 A_Raise
    Loop
  Fire:
    GSH2 A 3
    GSH2 A 7 A_FireShotgun2
    GSH2 B 7
    GSH2 C 7 A_CheckReload
    GSH2 D 7 A_OpenShotgun2
    GSH2 E 7
    GSH2 F 7 A_LoadShotgun2
    GSH2 G 6
    GSH2 H 6 A_CloseShotgun2
    GSH2 A 5 A_ReFire
    Goto Ready
	
  Flash:
    GSH2 I 4 Bright A_Light1
    GSH2 J 3 Bright A_Light2
    Goto LightDone
  Spawn:
    GS2P A -1
    Stop
  }
}

This works. Now take this fixed WAD. And this one too, because a completely cloned weapon is needless.

[Screenracer]

I actually did try the "ACTOR GoldSuperShotgun : SuperShotgun" However it did not work. :p

[Echo]

Yes, because everything else was broken. You might as well have tried "ACTOR GoldSuperShotgun : Turds".