Can I make a fork of Zandronum?

Discuss all aspects related to modding Zandronum here.
User avatar
StrikerMan780
Forum Regular
Posts: 279
Joined: Tue May 29, 2012 9:16 pm
Clan: Shadow Mavericks
Clan Tag: [SM]

RE: Can I make a fork of Zandronum?

#101

Post by StrikerMan780 » Fri Jul 11, 2014 2:54 am

Catastrophe wrote:
SwordGrunt wrote:But you can make "our" Zandronum better and believe me, if you get good work done, you WILL be recognized for it.
Yep. Still remember Spleen for unlagged.
Aye, that guy is a fucking hero. I also remember working with him to help test things. He's a nice guy too from what I've seen during test sessions.

User avatar
Torr Samaho
Lead Developer
Posts: 1543
Joined: Fri May 25, 2012 6:03 pm
Location: Germany

RE: Can I make a fork of Zandronum?

#102

Post by Torr Samaho » Fri Jul 11, 2014 6:13 am

Ok, we asked for proof and now we have proof. Proof that Quaker540 has no idea of what he is doing. Quaker540, if you really think that this kind of trivial changes (that don't even compile because you forgot all the necessary internal definitions required to even declare the new flags) bring you anywhere closer to ZDoom 2.7.1 in a reasonable way, you still have a lot of things to learn before you should even consider trying the revision-by-revision approach.
Tiger wrote: Torr Samaho, excuse my ignorance with Git (or Bitbucket) as I only have a limited knowledge of Subversion. If I where to create an account on BitBucket and I want to peak or modify the code (assuming I'll have a local working copy on my filesystem), would I need to 'fork' the Zandronum project or do I need to do anything special?

EDIT:
In addition, would I need any specialized permissions, or I'm I just free todo as I please? Again, excuse my ignorance as I never used BitBucket nor GIT.
If you just want to play around with the source, you don't even need a Bitbucket account. Just clone my repository to your machine (cloning is what you do instead of svn checkout). If you intend to submit patches, creating a fork in bitbucket is helpful. This way you can upload your changes to your bitbucket fork, I can look at them and decide whether I want to include them in Zandronum.

User avatar
Tiger
Retired Staff / Community Team Member
Posts: 381
Joined: Thu May 31, 2012 6:21 am
Location: United States
Contact:

RE: Can I make a fork of Zandronum?

#103

Post by Tiger » Fri Jul 11, 2014 3:01 pm

Thank you, later on I'll take a peak at the source code and play around with it.

User avatar
Tiger
Retired Staff / Community Team Member
Posts: 381
Joined: Thu May 31, 2012 6:21 am
Location: United States
Contact:

RE: Can I make a fork of Zandronum?

#104

Post by Tiger » Fri Jul 11, 2014 6:03 pm

Question, would I need both a Git client (TortoiseGit) and a Mercurial client (TortoiseHg) for this project? BitBucket manages Git (unless I read it wrong), and the wiki article states that I need a Mercurial client.

User avatar
ibm5155
Addicted to Zandronum
Posts: 1641
Joined: Tue Jun 05, 2012 9:32 pm
Location: Somewhere, over the rainbow

RE: Can I make a fork of Zandronum?

#105

Post by ibm5155 » Fri Jul 11, 2014 6:24 pm

I didn't use none of this to download all the code, I think there was a button to download all the code at a single click...
Well, you may need if you want to fork, at least, I needed here
Projects
Cursed Maze: DONE, V2.0
Zombie Horde - ZM09 map update: [3/15/13]
Need help with English? Then you've come to the right place!

<this post is proof of "Decline">

User avatar
Tiger
Retired Staff / Community Team Member
Posts: 381
Joined: Thu May 31, 2012 6:21 am
Location: United States
Contact:

RE: Can I make a fork of Zandronum?

#106

Post by Tiger » Fri Jul 11, 2014 7:02 pm

Ja, looks like I didn't fully catch it before - but I need TortoiseHg as BitBucket does handle both Git and Mercurial repo types. I don't want to immediately jump and fork the project just yet, I still want to play around with it first before I make any decisions. I remember reading the nice horror stories of ZDoom's source code in #ZDoom; you look at the source code - and it stares back at you! :P

User avatar
Tiger
Retired Staff / Community Team Member
Posts: 381
Joined: Thu May 31, 2012 6:21 am
Location: United States
Contact:

RE: Can I make a fork of Zandronum?

#107

Post by Tiger » Fri Jul 11, 2014 9:05 pm

My next question is, where can I find (if they even exist at all) the SVN repo's for ZDoom and\or GZDoom? The reason why I ask is merely for code comparisons against (G)ZDoom and Zandronum, or should I only pay full attention to the Zandronum source only when it comes to merely bug-hunting?

The older links no longer exists:

Arco
Retired Staff / Community Team Member
Posts: 69
Joined: Thu Jun 28, 2012 6:42 pm
Location: New York

RE: Can I make a fork of Zandronum?

#108

Post by Arco » Fri Jul 11, 2014 9:41 pm

Tiger wrote: My next question is, where can I find (if they even exist at all) the SVN repo's for ZDoom and\or GZDoom? The reason why I ask is merely for code comparisons against (G)ZDoom and Zandronum, or should I only pay full attention to the Zandronum source only when it comes to merely bug-hunting?

The older links no longer exists:
Both no longer use SVN; they're transferred to GitHub. Zdoom is located here and (G)ZDoom is here.
Image
When the weather changes, we will be lost. And no one will know who anyone is anymore.

User avatar
Tiger
Retired Staff / Community Team Member
Posts: 381
Joined: Thu May 31, 2012 6:21 am
Location: United States
Contact:

RE: Can I make a fork of Zandronum?

#109

Post by Tiger » Fri Jul 11, 2014 9:57 pm

How is Torr Samaho able to back-port within revisions? For example, Zandronum 2.0 is caught up to ZDoom revision 2509 and GZDoom revision 880 [1]. Were both projects GZDoom and ZDoom able to retain their revision ID's and history when they switched to a new repo type?


Question of the Day:
Where the fuck is main.cpp in Zandronum?!?!
Last edited by Tiger on Fri Jul 11, 2014 9:58 pm, edited 1 time in total.

User avatar
skyrimguy
 
Posts: 86
Joined: Sun Jul 29, 2012 8:35 am

RE: Can I make a fork of Zandronum?

#110

Post by skyrimguy » Fri Jul 11, 2014 10:45 pm

Tiger wrote: Question of the Day:
Where the fuck is main.cpp in Zandronum?!?!
<your_zandronum_source_directory>/masterserver/main.cpp
<your_zandronum_source_directory>/statsmaker/main.cpp
<your_zandronum_source_directory>/rcon_utility/main.cpp

User avatar
Tiger
Retired Staff / Community Team Member
Posts: 381
Joined: Thu May 31, 2012 6:21 am
Location: United States
Contact:

RE: Can I make a fork of Zandronum?

#111

Post by Tiger » Fri Jul 11, 2014 10:52 pm

skyrimguy wrote:
Tiger wrote: Question of the Day:
Where the fuck is main.cpp in Zandronum?!?!
<your_zandronum_source_directory>/masterserver/main.cpp
<your_zandronum_source_directory>/statsmaker/main.cpp
<your_zandronum_source_directory>/rcon_utility/main.cpp
I meant the actual engine :P
I am still digging around, I am struggling to find - exactly where the computer starts the zandronum program. There should be one function that starts the entire program, which is what I am still trying to look for...

Blzut3
Developer
Posts: 308
Joined: Thu May 24, 2012 9:37 pm

RE: Can I make a fork of Zandronum?

#112

Post by Blzut3 » Fri Jul 11, 2014 11:04 pm

Tiger wrote: I remember reading the nice horror stories of ZDoom's source code in #ZDoom; you look at the source code - and it stares back at you! :P
Not to say that ZDoom's code is free of WTF moments or anything like that, but I think the horror stories are heavily exaggerated. ZDoom's code is quite typical for a large project, especially one that based on an old C code base. Plus given the extensive documentation available for the external interfaces, I'd even argue that the code is above average. I think part of the issue is that OOP is so ingrained into people these days that any C-ism makes no sense.

Zandronum on the other hand...
Tiger wrote: Were both projects GZDoom and ZDoom able to retain their revision ID's and history when they switched to a new repo type?
I think Torr has an offline backup of the GZDoom repository, since GZDoom's git repository is a clean start from the ZDoom repo. As far as ZDoom goes though, the Git repository contains the full history and the svn revision is in the meta data.
Tiger wrote: I am still digging around, I am struggling to find - exactly where the computer starts the zandronum program. There should be one function that starts the entire program, which is what I am still trying to look for...
You're looking for D_DoomMain. How that function gets called depends on the OS.
Last edited by Blzut3 on Fri Jul 11, 2014 11:05 pm, edited 1 time in total.

User avatar
Tiger
Retired Staff / Community Team Member
Posts: 381
Joined: Thu May 31, 2012 6:21 am
Location: United States
Contact:

RE: Can I make a fork of Zandronum?

#113

Post by Tiger » Fri Jul 11, 2014 11:28 pm

Thank you for your help! I am going to look around and do some researching to better understand what is going on within the code...

User avatar
ibm5155
Addicted to Zandronum
Posts: 1641
Joined: Tue Jun 05, 2012 9:32 pm
Location: Somewhere, over the rainbow

RE: Can I make a fork of Zandronum?

#114

Post by ibm5155 » Fri Jul 11, 2014 11:34 pm

hmm I got curious, shouldn't zandronum just port revisions from gzdoom? because it would include the zdoom revisions too (or it's what they're making right now?)

EDIT:
It's not a scary code actually, on the first look you'll look 1k of .cpp files (or .c) and alot of code, but, you shouldn't understand everything at the minimum details, like on my port of musicalias feature, I would just need to find where the changes were made and copy and paste...

But it's not an easy code, since it's a big project, you'll may lost some time trying to get why there's so many vars into actors strucs or other thing :rolleyes:
Last edited by ibm5155 on Fri Jul 11, 2014 11:37 pm, edited 1 time in total.
Projects
Cursed Maze: DONE, V2.0
Zombie Horde - ZM09 map update: [3/15/13]
Need help with English? Then you've come to the right place!

<this post is proof of "Decline">

User avatar
Tiger
Retired Staff / Community Team Member
Posts: 381
Joined: Thu May 31, 2012 6:21 am
Location: United States
Contact:

RE: Can I make a fork of Zandronum?

#115

Post by Tiger » Sun Jul 13, 2014 7:25 am

I have peaked around the code, found out some really cool stuff that I didn't really know before - parameters you can use and what directories Zandronum accepts (Skins, Announcers, and bots), and small things here and there. Sadly, I don't think my C++ knowledge is up to the same level that is needed for this project. Thus, I don't think I will be able to really help out at all, that is until I better understand some of the C++ language than what I already know now. I might re-look at this again in the future and try again to read the code, line-by-line.

User avatar
Monsterovich
Forum Regular
Posts: 343
Joined: Sun Jun 17, 2012 5:46 pm

RE: Can I make a fork of Zandronum?

#116

Post by Monsterovich » Sun Jul 13, 2014 6:15 pm

Tiger wrote: Question of the Day:
Where the fuck is main.cpp in Zandronum?!?!
Answer of the Day:
i_main.cpp line 205

Blzut3
Developer
Posts: 308
Joined: Thu May 24, 2012 9:37 pm

RE: Can I make a fork of Zandronum?

#117

Post by Blzut3 » Sun Jul 13, 2014 8:54 pm

Tiger wrote: try again to read the code, line-by-line.
If you're going to try to fully understand a project the size of Zandronum in one go, you will fail. The best way to learn it is to decide what you want to work on and do it.

User avatar
Tiger
Retired Staff / Community Team Member
Posts: 381
Joined: Thu May 31, 2012 6:21 am
Location: United States
Contact:

RE: Can I make a fork of Zandronum?

#118

Post by Tiger » Sun Jul 13, 2014 10:01 pm

Blzut3 wrote:
Tiger wrote: try again to read the code, line-by-line.
If you're going to try to fully understand a project the size of Zandronum in one go, you will fail. The best way to learn it is to decide what you want to work on and do it.
Good idea, I'll do that instead.

Post Reply