Zandronum Chat on our Discord Server Get the latest version: 3.1
Source Code
My View | View Issues | Change Log | Roadmap | Zandronum Issue Support Ranking | Rules | My Account
  

View Issue Details [ Jump to Notes ] [ Issue History ] [ Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0000814Zandronum[All Projects] Bugpublic2012-04-25 11:592018-09-30 23:38
ReporterTheMisterCat 
Assigned ToWatermelon 
PrioritynormalSeveritytrivialReproducibilityalways
StatusclosedResolutionfixed 
PlatformOSOS Version
Product Version98d 
Target Version1.4Fixed in Version1.4 
Summary0000814: Light_Fade without any tic duration fails to fade online
Description
Quote from unknownna
Quote from TheMisterCat
Light_Fade does not function at all online.

It does function online, but Light_Fade without any tic duration will fail to fade online.
Steps To Reproduce1. skulltag.exe -file light_fade_01.wad -host
2. Connect a client to the server and join the game.
3. Push the switches.
Attached Files? file icon light_fade_01.wad [^] (2,520 bytes) 2012-04-25 11:59

- Relationships

-  Notes
User avatar (0010496)
Watermelon (developer)
2014-10-11 16:19

 Requesting code review:

'https://bitbucket.org/ChrisKOmg/zandronum-stable/commits/c2db25f44763bdcb87d9c04e832ab05121529079 [^]'
User avatar (0010557)
Torr Samaho (administrator)
2014-10-12 19:24

 The patch looks ok.
User avatar (0010563)
Dusk (developer)
2014-10-12 23:46

 Nitpick: the comments on lines 718-720 imply that the main reason for the new code block is not to update the variable if it hasn't changed while the real reason for it is preventing wasting bandwidth.
User avatar (0010569)
Watermelon (developer)
2014-10-13 15:26

 Fixed comments as for what Dusk said.

Pull request sent.
User avatar (0010571)
cobalt (updater)
2014-10-13 18:55

 Issue addressed by commit d470e1b042d1: Instant light fading was not updated on the client's side (fixes 814).
Committed by WChrisK on Monday 13 October 2014 11:25:17

Changes in files:
 docs/zandronum-history.txt | 1 +
 src/p_lights.cpp | 12 +++++++++++-
 2 files changed, 12 insertions(+), 1 deletions(-)
User avatar (0010577)
Arco (updater)
2014-10-13 23:36

 The light in the testing map does not properly revert to its proper color after map restarts.
User avatar (0010581)
Watermelon (developer)
2014-10-14 03:02

 That's interesting, it did for me. I will investigate further. You're on windows right?


Do you mean 'color' or light level?
User avatar (0010583)
Watermelon (developer)
2014-10-14 16:59

 I just tested it on Linux and it worked perfectly in the wad. Are you sure you got the latest version?
User avatar (0010588)
Watermelon (developer)
2014-10-14 23:04

 So apparently the light does not reset when countdowns are involved, but works fine in coop and other similar modes.
User avatar (0010589)
Watermelon (developer)
2014-10-14 23:41

 Pull request sent, luckily this was a trivial fix.
User avatar (0010591)
cobalt (updater)
2014-10-15 06:07

 Issue addressed by commit 31047954d012: A light level changed was not mark for an instant fading workaround fix, which resulted in not being reset properly (further fixes 814).
Committed by WChrisK on Tuesday 14 October 2014 19:44:43

Changes in files:
 src/p_lights.cpp | 1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
User avatar (0010600)
StrikerMan780 (reporter)
2014-10-15 22:04

 Hitting the switches in light_test_01.wad seems to work fine on a server running this build:'http://l.xd.cm:8080/builders/windows-x86-stable/builds/18 [^]'

Issue Community Support
This issue is already marked as resolved.
If you feel that is not the case, please reopen it and explain why.
Supporters: No one explicitly supports this issue yet.
Opponents: No one explicitly opposes this issue yet.

- Issue History
Date Modified Username Field Change
2012-04-25 11:59 unknownna New Issue
2012-04-25 11:59 unknownna File Added: light_fade_01.wad
2012-04-25 11:59 unknownna Status new => confirmed
2012-04-25 12:05 unknownna Reporter unknownna => TheMisterCat
2012-06-09 13:22 Torr Samaho Category General => Bug
2014-10-11 16:19 Watermelon Note Added: 0010496
2014-10-11 16:19 Watermelon Assigned To => Watermelon
2014-10-11 16:19 Watermelon Status confirmed => needs review
2014-10-12 19:24 Torr Samaho Note Added: 0010557
2014-10-12 21:19 Watermelon Status needs review => assigned
2014-10-12 23:46 Dusk Note Added: 0010563
2014-10-13 15:26 Watermelon Note Added: 0010569
2014-10-13 15:26 Watermelon Status assigned => needs review
2014-10-13 18:55 cobalt Status needs review => needs testing
2014-10-13 18:55 cobalt Target Version => 1.4
2014-10-13 18:55 cobalt Description Updated View Revisions
2014-10-13 18:55 cobalt Steps to Reproduce Updated View Revisions
2014-10-13 18:55 cobalt Note Added: 0010571
2014-10-13 23:36 Arco Note Added: 0010577
2014-10-13 23:36 Arco Status needs testing => feedback
2014-10-13 23:36 Arco Description Updated View Revisions
2014-10-13 23:36 Arco Steps to Reproduce Updated View Revisions
2014-10-14 03:02 Watermelon Note Added: 0010581
2014-10-14 16:59 Watermelon Note Added: 0010583
2014-10-14 23:04 Watermelon Note Added: 0010588
2014-10-14 23:04 Watermelon Status feedback => assigned
2014-10-14 23:41 Watermelon Note Added: 0010589
2014-10-14 23:41 Watermelon Status assigned => needs review
2014-10-15 06:07 cobalt Status needs review => needs testing
2014-10-15 06:07 cobalt Description Updated View Revisions
2014-10-15 06:07 cobalt Steps to Reproduce Updated View Revisions
2014-10-15 06:07 cobalt Note Added: 0010591
2014-10-15 22:04 StrikerMan780 Note Added: 0010600
2015-03-16 01:26 Dusk Status needs testing => resolved
2015-03-16 01:26 Dusk Fixed in Version => 1.4
2015-03-16 01:26 Dusk Resolution open => fixed
2018-09-30 23:38 Blzut3 Status resolved => closed




Questions or other issues? Contact Us.

Links

Copyright © 2000 - 2024 MantisBT Team
Powered by Mantis Bugtracker