0003149: EVENT script for return and capture don't work on Skulltag

Chat on our Discord Server Get the latest version: 3.1
Source Code

View Issue Details [ Jump to Notes ]

[ Issue History ] [ Print ]

Project

Category

View Status

Date Submitted

Last Update

0003149

Zandronum

[All Projects] Bug

public

2017-05-30 23:09

2021-12-17 14:23

Reporter

Catastrophe

Assigned To

Kaminsky

Priority

normal

Severity

minor

Reproducibility

always

Status

resolved

Resolution

fixed

Platform

OS Version

Product Version

2.1

Target Version

3.1

Fixed in Version

3.1

Summary

0003149: EVENT script for return and capture don't work on Skulltag

Description

This happens in both 2.1.2 and 3.0-beta.

Basically returning the skull and capturing in Skulltag doesn't seem to run the appropriate EVENT script. It works fine in CTF though.

Happens in both Singleplayer and Multiplayer.

I don't know if this is the right place to put this, but once this is fixed, could we also have arg2 of the capture EVENT to return the number of points obtained as well? Skulltag features certain scoring areas that give more than one point.

Steps To Reproduce

Load this'http://allfearthesentinel.net/download?file=fnf-stats-r3-test4.pk3 [^]'
Load any skulltag mappack; here's one for the lazy:'http://allfearthesentinel.net/download?file=stcomp_b2.pk3 [^]' (start at map stcomp01)

Add a bot and go ahead and grab their skull and capture it, you'll see that fnf-stats will print a debug message in the console if you pick up the enemy skull but not if you capture it.

The same can be done in CTF to see that everything works fine in that gamemode.

Attached Files

Relationships

related to

0003126

resolved

Kaminsky

GAMEEVENT_CAPTURES does not trigger when One Flag CTF flags are captured

Notes
(0017841) Ru5tK1ng (updater) 2017-06-19 03:42	Looking through the code it seems water didn't notice that Skulltag mode handles returns and captures in different spots than in CTF. Since 3.0 is coming out soon, I'll mark this for 3.1 and leave my fix for review for a later PR. 'https://bitbucket.org/Ru5tK1ng/zandoom/commits/8cd52f40824879da9a2d94281521be8e4020a588 [^]'

(0017847) Cutman (reporter) 2017-06-19 13:30 edited on: 2017-06-19 13:35	If this is a priority please do the same for the White Flag too, I believe it is also missing compatibility (issue 0003126 and maybe 0003078 )

(0021552) Torr Samaho (administrator) 2020-10-25 21:14	I added Kaminsky's patch for this.

(0021918) Kaminsky (developer) 2021-12-17 14:23	This has been fixed in 3.1, and arg2 of GAMEEVENT_CAPTURES now contains the number of points earned from the capture.

**Issue Community Support**
This issue is already marked as resolved. If you feel that is not the case, please reopen it and explain why.
Supporters:	Combinebobnt EpicTyphlosion
Opponents:	No one explicitly opposes this issue yet.

Issue History
Date Modified	Username	Field	Change
2017-05-30 23:09	Catastrophe	New Issue
2017-06-04 08:58	Torr Samaho	Product Version	3.0-beta => 2.1
2017-06-19 03:42	Ru5tK1ng	Note Added: 0017841
2017-06-19 03:42	Ru5tK1ng	Status	new => needs review
2017-06-19 03:42	Ru5tK1ng	Target Version	=> 3.1
2017-06-19 13:30	Cutman	Note Added: 0017847
2017-06-19 13:35	Cutman	Note Edited: 0017847	View Revisions
2017-06-19 19:03	Ru5tK1ng	Relationship added	related to 0003126
2020-10-25 21:14	Torr Samaho	Note Added: 0021552
2020-10-25 21:14	Torr Samaho	Status	needs review => needs testing
2021-12-17 14:23	Kaminsky	Note Added: 0021918
2021-12-17 14:23	Kaminsky	Status	needs testing => resolved
2021-12-17 14:23	Kaminsky	Fixed in Version	=> 3.1
2021-12-17 14:23	Kaminsky	Resolution	open => fixed
2021-12-17 14:23	Kaminsky	Assigned To	=> Kaminsky

Questions or other issues? Contact Us.

Links

Doom and Doom II are the property of id Software.