Zandronum Chat on our Discord Server Get the latest version: 3.1
Source Code
My View | View Issues | Change Log | Roadmap | Zandronum Issue Support Ranking | Rules | My Account
  

View Issue Details [ Jump to Notes ] [ Issue History ] [ Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0002978Zandronum[All Projects] Bugpublic2017-01-09 18:142018-09-30 21:44
ReporterBorg 
Assigned ToEdward-san 
PrioritynormalSeverityminorReproducibilityN/A
StatusclosedResolutionfixed 
PlatformSource CodeOSOS Version
Product Version2.1 
Target Version3.0Fixed in Version3.0 
Summary0002978: DamageFactor calculation executed twice for Armors
DescriptionAfter doing some modding with multiple Protection artifacts, I found a problem
with stacking. It seems when 2 or more Protection are active, they start to
stack badly and become much more strong that any single of them.
After brief peek to source code, I found this strange thing:
src/g_shared/a_armor.cpp,178:
// Once the armor has absorbed its part of the damage, then apply its damage factor, if any, to the player

Read up the whole block, with is executed twice (copy&paste).
Looks like a bug to me, is it intended?
Additional InformationI would inspect other code around DamageFactor as well.
As said, stacking Protection Inventory items greeat odd efect of very
strong Protection.
Attached Files

- Relationships

-  Notes
User avatar (0016629)
Dusk (developer)
2017-01-09 22:01

 Looks like a merge error. A very old one too, as 2.1 also exhibits it.
User avatar (0016631)
Edward-san (developer)
2017-01-10 10:19

 'https://bitbucket.org/zandronum/zandronum-sandbox/commits/187adb8ccddd380a6d122b5aecad622ff0ccac25 [^]'

In 2.1, the two copies are identical, while in 3.0 they diverged because of the code upgrade (zdoom svn r3469, added in zandronum with changeset 6bbe67e64b39a951 ), so removing the second copy is the right way.
User avatar (0016636)
Torr Samaho (administrator)
2017-01-15 08:55

 I added your patch.
User avatar (0016707)
Ru5tK1ng (updater)
2017-01-28 17:48

 Can we get an example wad to correctly test the fix?
User avatar (0017164)
Combinebobnt (reporter)
2017-04-16 22:59

 yea def are gonna need an example wad

i tested stacking armor + 1 or 2 powerprotection items and nothing seemed out of the ordinary in both 2.1.2 and r170416-0710. Each protection was 0.5 damage and it worked the same in both ports.
User avatar (0017193)
Borg (reporter)
2017-04-18 07:39

 Testing this is not obvious. I had 2 powerprotection items on my mod and
it was all okey on single player test map. Things start to work strange
on multiplayer... For example, suprised by HexaZombie.. I wasnt even damaged
from his full blast hexa...
After some more online testing then, I noticed that sometimes damage
is very very low or nullified...

After switching to ACS and APROP_DamageFactor things work good now.
User avatar (0017356)
Ru5tK1ng (updater)
2017-04-27 01:42

 So is your issue now solved? It's hard to understand without an example wad.
User avatar (0017740)
Ru5tK1ng (updater)
2017-05-23 01:20

 Marking as resolved since 'things work good now' according to the author.

Issue Community Support
This issue is already marked as resolved.
If you feel that is not the case, please reopen it and explain why.
Supporters: No one explicitly supports this issue yet.
Opponents: Combinebobnt

- Issue History
Date Modified Username Field Change
2017-01-09 18:14 Borg New Issue
2017-01-09 22:01 Dusk Note Added: 0016629
2017-01-10 10:19 Edward-san Note Added: 0016631
2017-01-10 10:19 Edward-san Assigned To => Edward-san
2017-01-10 10:19 Edward-san Status new => needs review
2017-01-15 08:55 Torr Samaho Note Added: 0016636
2017-01-15 08:56 Torr Samaho Product Version 4.0-beta => 2.1
2017-01-15 08:56 Torr Samaho Target Version => 3.0
2017-01-15 08:56 Torr Samaho Status needs review => needs testing
2017-01-28 17:48 Ru5tK1ng Note Added: 0016707
2017-04-16 22:59 Combinebobnt Note Added: 0017164
2017-04-18 07:39 Borg Note Added: 0017193
2017-04-27 01:42 Ru5tK1ng Note Added: 0017356
2017-05-23 01:20 Ru5tK1ng Note Added: 0017740
2017-05-23 01:20 Ru5tK1ng Status needs testing => resolved
2017-05-23 01:20 Ru5tK1ng Resolution open => fixed
2017-05-23 01:20 Ru5tK1ng Fixed in Version => 3.0
2018-09-30 21:44 Blzut3 Status resolved => closed




Questions or other issues? Contact Us.

Links

Copyright © 2000 - 2024 MantisBT Team
Powered by Mantis Bugtracker