Zandronum Chat @ irc.zandronum.com
#zandronum
Get the latest version: 2.1.2
Source Code

View Issue Details Jump to Notes ] Issue History ] Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0002978Zandronum[All Projects] Bugpublic2017-01-09 18:142017-01-15 08:56
ReporterBorg 
Assigned ToEdward-san 
PrioritynormalSeverityminorReproducibilityN/A
Statusneeds testingResolutionopen 
PlatformSource CodeOSOS Version
Product Version2.1 
Target Version3.0Fixed in Version 
Summary0002978: DamageFactor calculation executed twice for Armors
DescriptionAfter doing some modding with multiple Protection artifacts, I found a problem
with stacking. It seems when 2 or more Protection are active, they start to
stack badly and become much more strong that any single of them.
After brief peek to source code, I found this strange thing:
src/g_shared/a_armor.cpp,178:
// Once the armor has absorbed its part of the damage, then apply its damage factor, if any, to the player

Read up the whole block, with is executed twice (copy&paste).
Looks like a bug to me, is it intended?
Additional InformationI would inspect other code around DamageFactor as well.
As said, stacking Protection Inventory items greeat odd efect of very
strong Protection.
Attached Files

- Relationships

-  Notes
User avatar (0016629)
Dusk (developer)
2017-01-09 22:01

Looks like a merge error. A very old one too, as 2.1 also exhibits it.
User avatar (0016631)
Edward-san (developer)
2017-01-10 10:19

https://bitbucket.org/zandronum/zandronum-sandbox/commits/187adb8ccddd380a6d122b5aecad622ff0ccac25 [^]

In 2.1, the two copies are identical, while in 3.0 they diverged because of the code upgrade (zdoom svn r3469, added in zandronum with changeset 6bbe67e64b39a951 ), so removing the second copy is the right way.
User avatar (0016636)
Torr Samaho (administrator)
2017-01-15 08:55

I added your patch.

Issue Community Support
Only registered users can voice their support. Click here to register, or here to log in.
Supporters: No one explicitly supports this issue yet.
Opponents: No one explicitly opposes this issue yet.

- Issue History
Date Modified Username Field Change
2017-01-09 18:14 Borg New Issue
2017-01-09 22:01 Dusk Note Added: 0016629
2017-01-10 10:19 Edward-san Note Added: 0016631
2017-01-10 10:19 Edward-san Assigned To => Edward-san
2017-01-10 10:19 Edward-san Status new => needs review
2017-01-15 08:55 Torr Samaho Note Added: 0016636
2017-01-15 08:56 Torr Samaho Product Version 4.0-beta => 2.1
2017-01-15 08:56 Torr Samaho Target Version => 3.0
2017-01-15 08:56 Torr Samaho Status needs review => needs testing






Questions or other issues? Contact Us.

Links


Copyright © 2000 - 2017 MantisBT Team
Powered by Mantis Bugtracker