|Anonymous | Login | Signup for a new account||2017-03-27 22:25 UTC|
|My View | View Issues | Change Log | Roadmap | Zandronum Issue Support Ranking | Rules | My Account|
|View Issue Details|
|ID||Project||Category||View Status||Date Submitted||Last Update|
|0002978||Zandronum||[All Projects] Bug||public||2017-01-09 18:14||2017-01-28 17:48|
|Platform||Source Code||OS||OS Version|
|Target Version||3.0||Fixed in Version|
|Summary||0002978: DamageFactor calculation executed twice for Armors|
|Description||After doing some modding with multiple Protection artifacts, I found a problem|
with stacking. It seems when 2 or more Protection are active, they start to
stack badly and become much more strong that any single of them.
After brief peek to source code, I found this strange thing:
// Once the armor has absorbed its part of the damage, then apply its damage factor, if any, to the player
Read up the whole block, with is executed twice (copy&paste).
Looks like a bug to me, is it intended?
|Additional Information||I would inspect other code around DamageFactor as well.|
As said, stacking Protection Inventory items greeat odd efect of very
|Looks like a merge error. A very old one too, as 2.1 also exhibits it.|
In 2.1, the two copies are identical, while in 3.0 they diverged because of the code upgrade (zdoom svn r3469, added in zandronum with changeset 6bbe67e64b39a951 ), so removing the second copy is the right way.
Torr Samaho (administrator)
|I added your patch.|
|Can we get an example wad to correctly test the fix?|
|Only registered users can voice their support. Click here to register, or here to log in.|
|Supporters:||No one explicitly supports this issue yet.|
|Opponents:||No one explicitly opposes this issue yet.|
|2017-01-09 18:14||Borg||New Issue|
|2017-01-09 22:01||Dusk||Note Added: 0016629|
|2017-01-10 10:19||Edward-san||Note Added: 0016631|
|2017-01-10 10:19||Edward-san||Assigned To||=> Edward-san|
|2017-01-10 10:19||Edward-san||Status||new => needs review|
|2017-01-15 08:55||Torr Samaho||Note Added: 0016636|
|2017-01-15 08:56||Torr Samaho||Product Version||4.0-beta => 2.1|
|2017-01-15 08:56||Torr Samaho||Target Version||=> 3.0|
|2017-01-15 08:56||Torr Samaho||Status||needs review => needs testing|
|2017-01-28 17:48||Ru5tK1ng||Note Added: 0016707|
Questions or other issues? Contact Us.
|Copyright © 2000 - 2017 MantisBT Team|