0002899: Spectating string doesn't show line number when coop spying in 3.0

Notes
(0016021) unknownna (updater) 2016-10-16 14:50 edited on: 2016-10-16 14:53	Actually, the spectator message is updated, but is broken if coop spying.

(0016031) Edward-san (developer) 2016-10-17 13:58	Quote Additionally, the "Your position in line is: x" message isn't displayed if you join the game again after initially joining the queue in 3.0. Can you elaborate?

(0016032) Edward-san (developer) 2016-10-17 14:04	I'd like to know also which beta regressed.

(0016033) unknownna (updater) 2016-10-17 14:17	The message in the upper left of the screen isn't repeated when you select "join game" through the menu after having joined once already. I attached a screenshot to show you how it worked before. It started to break in 151228-1140.

(0016036) Edward-san (developer) 2016-10-17 16:18 edited on: 2016-10-17 16:24	Quote from unknownna Actually, the spectator message is updated, but is broken if coop spying. I'd like to see this bisected, because actually I have a patch which works but the piece of code I change was always present since old times, hence it's not clear what exactly changed.

(0016037) unknownna (updater) 2016-10-17 16:45	If it helps, here's what I found in the changelog for that build regarding line queues. There were a lot of changes: * 9381:c801abda95a7 : Made the join queue TArray-based * 9382:c5bf89850ea2 : Remove use of hungarian notation and LONG/ULONG in join queue code * 9383:4b5ba1fea3e5 : Renamed JOINSLOT_t to JoinSlot and made it private * 9384:92a3264f3984 : Join queue is now synchronized to clients in full. * 9385:f6f2087ded57 : Render the join queue position on the scoreboard (addresses 1028) * 9386:9d7a137168e7 : Handle the "your position in line is: #" message on the client side now that we can. (Perhaps this one for the message on the upper left.) * 9388:cd1886c2eaa6 : Store JOINQUEUE_AddPlayer parameters as local variables or the bytestream will be read incorrectly on Windows

(0016038) WaTaKiD (updater) 2016-10-17 20:02	ok so heres wut i got: from 'https://bitbucket.org/Torr_Samaho/zandronum/commits/92a3264f3984218f6663229420695f7f4eaeac34 [^]' to 'https://bitbucket.org/Torr_Samaho/zandronum/commits/5254b2c231e39c79daeda442bf5951953e6049d4 [^]' the "spectating - space to join" message shows, regardless if f12ing or in queue "waiting to play" doesnt show at all the top left "your position" message doesnt show at all however, starting with 'https://bitbucket.org/Torr_Samaho/zandronum/commits/cd1886c2eaa6f6c1ff7fb039d4e9c3e9db0d7342 [^]' the "spectating - space to join" message shows if im f12ing and in queue "waiting to play" shows if i dont f12 and am in queue the top left "your position" message shows only once, when first entering the queue, instead of every time i try to join it

(0016039) Dusk (developer) 2016-10-17 20:20	Fixed

(0016235) Torr Samaho (administrator) 2016-11-21 07:02	I added this a while ago.

(0016447) Ru5tK1ng (updater) 2016-12-08 04:02	Works fine now even after spectating and rejoining the queue.

**Issue Community Support**
This issue is already marked as resolved. If you feel that is not the case, please reopen it and explain why.
Supporters:	No one explicitly supports this issue yet.
Opponents:	No one explicitly opposes this issue yet.

Issue Community Support

This issue is already marked as resolved.
If you feel that is not the case, please reopen it and explain why.

Supporters:

No one explicitly supports this issue yet.

Opponents:

No one explicitly opposes this issue yet.

Issue History
Date Modified	Username	Field	Change
2016-10-16 10:56	unknownna	New Issue
2016-10-16 10:56	unknownna	File Added: 3.0vs2.1.2.png
2016-10-16 14:50	unknownna	Note Added: 0016021
2016-10-16 14:51	unknownna	Summary	Spectating string doesn't show line number in 3.0 => Spectating string doesn't show line number when coop spying in 3.0
2016-10-16 14:53	unknownna	Note Edited: 0016021	View Revisions
2016-10-17 13:58	Edward-san	Note Added: 0016031
2016-10-17 13:59	Edward-san	Status	new => feedback
2016-10-17 14:04	Edward-san	Note Added: 0016032
2016-10-17 14:16	unknownna	File Added: Screenshot_Doom_20161017_161435.png
2016-10-17 14:17	unknownna	Note Added: 0016033
2016-10-17 14:17	unknownna	Status	feedback => new
2016-10-17 16:18	Edward-san	Note Added: 0016036
2016-10-17 16:19	Edward-san	Status	new => feedback
2016-10-17 16:24	Edward-san	Note Edited: 0016036	View Revisions
2016-10-17 16:45	unknownna	Note Added: 0016037
2016-10-17 16:45	unknownna	Status	feedback => new
2016-10-17 18:10	Edward-san	Status	new => feedback
2016-10-17 20:02	WaTaKiD	Note Added: 0016038
2016-10-17 20:10	Dusk	Assigned To	=> Dusk
2016-10-17 20:10	Dusk	Status	feedback => assigned
2016-10-17 20:20	Dusk	Note Added: 0016039
2016-10-17 20:20	Dusk	Status	assigned => needs review
2016-11-21 07:02	Torr Samaho	Note Added: 0016235
2016-11-21 07:02	Torr Samaho	Status	needs review => needs testing
2016-11-21 07:03	Torr Samaho	Target Version	=> 3.0
2016-12-08 04:02	Ru5tK1ng	Note Added: 0016447
2016-12-08 04:02	Ru5tK1ng	Status	needs testing => resolved
2016-12-08 04:02	Ru5tK1ng	Resolution	open => fixed
2016-12-08 04:02	Ru5tK1ng	Fixed in Version	=> 3.0
2018-09-30 21:55	Blzut3	Status	resolved => closed

Relationships