Anonymous | Login | Signup for a new account | 2024-04-23 06:49 UTC |
My View | View Issues | Change Log | Roadmap | Zandronum Issue Support Ranking | Rules | My Account |
View Issue Details [ Jump to Notes ] | [ Issue History ] [ Print ] | ||||||||
ID | Project | Category | View Status | Date Submitted | Last Update | ||||
0002846 | Zandronum | [All Projects] Bug | public | 2016-10-01 19:06 | 2018-09-30 21:46 | ||||
Reporter | AtomicLugia | ||||||||
Assigned To | |||||||||
Priority | normal | Severity | minor | Reproducibility | have not tried | ||||
Status | closed | Resolution | fixed | ||||||
Platform | Microsoft | OS | Windows | OS Version | XP/Vista/7 | ||||
Product Version | 3.0-beta | ||||||||
Target Version | 3.0 | Fixed in Version | 3.0 | ||||||
Summary | 0002846: Railgun kills ignores custom obituaries | ||||||||
Description | I'm working on a lightning gun and it has the obituary "%o was electroduced by %k's lightning gun.". But if I kill a plyer/bot with this weapon, it prints out "%o was railed by %k.". | ||||||||
Steps To Reproduce | - Create a custom weapon with uses A_RailAttack. - Create a custom obituary for this weapon. - Start Zandronum with it. - Play a deathmatch with a bot. - Get the weapon with IDKFA or Give. - Kill the bot. - Look at the messages. OR - Start Zandronum with the included WAD. - Play a deathmatch with a bot. - Get the weapon with IDKFA or Give. - Kill the bot. - Look at the messages. | ||||||||
Additional Information | The weapon also spams the "Impressive!" medal, because it uses a Railgun attack. An option to prevent this would be nice, too. xD | ||||||||
Attached Files | LightningGun.wad [^] (83,932 bytes) 2016-10-01 19:06 LightningGun212.wad [^] (83,422 bytes) 2016-11-27 16:37 | ||||||||
Notes | |
(0015721) Ru5tK1ng (updater) 2016-10-02 04:20 |
I took a look at the decorate and it seems fine. Given the fact the obituary is ignored in GZdoom 1.8.6 and Zdoom 2.8, this should be reported to ZDoom. |
(0015723) Ivan (reporter) 2016-10-02 09:17 |
Turn off medals to disable that medal spam thing. |
(0015724) AtomicLugia (reporter) 2016-10-02 09:39 |
It's also ignored in ZDoom 2.8.1, GZDoom 2.2 and GZDoom 2.3pre. |
(0015725) Edward-san (developer) 2016-10-02 09:50 |
Then please report it in zdoom forum. |
(0015776) AtomicLugia (reporter) 2016-10-06 16:38 |
I reported it in the ZDoom forums. 'http://forum.zdoom.org/viewtopic.php?f=2&t=53731 [^]' |
(0016358) Torr Samaho (administrator) 2016-11-27 16:38 |
I added Zandronum 2.1.2 compatible version of the example. With it, it works in 2.1.2 but not in 3.0. So this is a regression. |
(0016710) Ru5tK1ng (updater) 2017-01-28 20:56 |
The ClientObituary code is the same between 2.1.2 and 3.0. I wasn't able to find the cause of the regression, but commenting out:'https://bitbucket.org/Torr_Samaho/zandronum/src/0c977c782fb6d412681bd05e7539b4159d832138/src/p_interaction.cpp?at=default&fileviewer=file-view-default#p_interaction.cpp-341 [^]' seemed to fix the railgun obituary. But I don't think that's the right way to go about it. |
(0016827) Ru5tK1ng (updater) 2017-02-08 19:47 edited on: 2017-02-08 19:48 |
Did a bit of testing and apparently the obituary behavior broke between zdoom 2.5 & 2.6. Hopefully this narrows it down enough to findthe cause. |
(0016829) Edward-san (developer) 2017-02-08 20:45 |
I already found the cause, see this. |
(0016830) Ru5tK1ng (updater) 2017-02-08 22:08 |
This seemed to fix the issue. |
(0016834) Torr Samaho (administrator) 2017-02-11 12:50 |
The patch does not seem to work for me. I start the game with
add a bot and get the wrong obituary. In 2.1.2, this works fine. Did you test your patch offline or online? |
(0016838) Ru5tK1ng (updater) 2017-02-11 19:10 |
Hmm, I tested online with a bot and the obituary shows up fine. But now I caught that it doesn't offline. I'll have to take another shot. |
(0016840) Edward-san (developer) 2017-02-11 20:53 |
Added a ticket in the zdoom tracker for making this bug more visible:'https://mantis.zdoom.org/view.php?id=244 [^]' |
(0016855) Ru5tK1ng (updater) 2017-02-12 21:41 |
Following Torr's suggestion, this seemed to fix the obituary offline and it works online. If there is no specified obituary on a weapon using railattack, the default OB_Railgun message gets used successfully. |
(0016942) Ru5tK1ng (updater) 2017-03-05 19:41 |
Patch was added, needs testing. |
(0017232) Combinebobnt (reporter) 2017-04-19 23:08 |
r170416-0710 tested LightningGun212.wad offline/online in dm/tlms. the obiturary worked. |
(0017237) Ru5tK1ng (updater) 2017-04-20 00:56 |
Thanks for testing my patch. |
This issue is already marked as resolved. If you feel that is not the case, please reopen it and explain why. |
|
Supporters: | No one explicitly supports this issue yet. |
Opponents: | No one explicitly opposes this issue yet. |
Issue History | |||
Date Modified | Username | Field | Change |
2016-10-01 19:06 | AtomicLugia | New Issue | |
2016-10-01 19:06 | AtomicLugia | File Added: LightningGun.wad | |
2016-10-02 04:20 | Ru5tK1ng | Note Added: 0015721 | |
2016-10-02 09:17 | Ivan | Note Added: 0015723 | |
2016-10-02 09:39 | AtomicLugia | Note Added: 0015724 | |
2016-10-02 09:50 | Edward-san | Note Added: 0015725 | |
2016-10-02 09:50 | Edward-san | Status | new => feedback |
2016-10-06 16:38 | AtomicLugia | Note Added: 0015776 | |
2016-10-06 16:38 | AtomicLugia | Status | feedback => new |
2016-10-06 17:11 | Edward-san | Status | new => acknowledged |
2016-10-06 17:11 | Edward-san | Resolution | open => waiting for zdoom |
2016-11-27 16:37 | Torr Samaho | File Added: LightningGun212.wad | |
2016-11-27 16:38 | Torr Samaho | Note Added: 0016358 | |
2016-11-27 16:38 | Torr Samaho | Target Version | => 3.0 |
2017-01-28 20:56 | Ru5tK1ng | Note Added: 0016710 | |
2017-02-08 19:47 | Ru5tK1ng | Note Added: 0016827 | |
2017-02-08 19:47 | Ru5tK1ng | Note Edited: 0016827 | View Revisions |
2017-02-08 19:48 | Ru5tK1ng | Note Edited: 0016827 | View Revisions |
2017-02-08 20:11 | Ru5tK1ng | Note Added: 0016828 | |
2017-02-08 20:28 | Ru5tK1ng | Note Deleted: 0016828 | |
2017-02-08 20:45 | Edward-san | Note Added: 0016829 | |
2017-02-08 22:08 | Ru5tK1ng | Note Added: 0016830 | |
2017-02-11 12:50 | Torr Samaho | Note Added: 0016834 | |
2017-02-11 12:50 | Torr Samaho | Status | acknowledged => feedback |
2017-02-11 19:10 | Ru5tK1ng | Note Added: 0016838 | |
2017-02-11 20:53 | Edward-san | Note Added: 0016840 | |
2017-02-12 00:48 | Ru5tK1ng | Note Added: 0016841 | |
2017-02-12 00:51 | Ru5tK1ng | Note Deleted: 0016841 | |
2017-02-12 21:41 | Ru5tK1ng | Note Added: 0016855 | |
2017-02-12 21:42 | Ru5tK1ng | Status | feedback => needs review |
2017-03-05 19:41 | Ru5tK1ng | Note Added: 0016942 | |
2017-03-05 19:41 | Ru5tK1ng | Status | needs review => needs testing |
2017-03-05 19:41 | Ru5tK1ng | Resolution | waiting for zdoom => open |
2017-04-19 23:08 | Combinebobnt | Note Added: 0017232 | |
2017-04-20 00:56 | Ru5tK1ng | Note Added: 0017237 | |
2017-04-20 00:56 | Ru5tK1ng | Status | needs testing => resolved |
2017-04-20 00:56 | Ru5tK1ng | Resolution | open => fixed |
2017-04-20 00:56 | Ru5tK1ng | Fixed in Version | => 3.0 |
2018-09-30 21:46 | Blzut3 | Status | resolved => closed |
Copyright © 2000 - 2024 MantisBT Team |