Zandronum Chat on our Discord Server Get the latest version: 3.1
Source Code
My View | View Issues | Change Log | Roadmap | Zandronum Issue Support Ranking | Rules | My Account
  

View Issue Details [ Jump to Notes ] [ Issue History ] [ Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0002815Zandronum[All Projects] Bugpublic2016-08-23 11:492016-08-23 15:47
ReporterDrinkyBird 
Assigned ToTorr Samaho 
PrioritynormalSeverityminorReproducibilityalways
Statusneeds reviewResolutionopen 
PlatformOSFreeBSDOS Version10.3-RELEASE
Product Version 
Target VersionFixed in Version 
Summary0002815: Include <sys/wait.h> in sdl/i_system.cpp
DescriptionThe lack of this include is the only thing preventing Zandronum compiling without errors on FreeBSD.
Steps To ReproduceCompile a fresh clone of Zandronum under FreeBSD and get this error:

[ 36%] Building CXX object src/CMakeFiles/zdoom.dir/sdl/i_system.o
/root/zandronum/src/sdl/i_system.cpp: In function 'int I_PickIWad(WadStuff*, int, bool, int)':
/root/zandronum/src/sdl/i_system.cpp:697:23: error: 'WIFEXITED' was not declared in this scope
    if(WIFEXITED(status) && (WEXITSTATUS(status) == 0 || WEXITSTATUS(status) == 1))
                       ^
/root/zandronum/src/sdl/i_system.cpp:697:47: error: 'WEXITSTATUS' was not declared in this scope
    if(WIFEXITED(status) && (WEXITSTATUS(status) == 0 || WEXITSTATUS(status) == 1))
Additional Information<sys/wait.h> is a standard POSIX header, so it shouldn't cause issues on Linux or other POSIX platforms.
Attached Files

- Relationships

-  Notes
User avatar (0015521)
DrinkyBird (developer)
2016-08-23 11:51

 Uh, I should have marked this as a suggestion, not a bug. Oh well.
User avatar (0015522)
Dusk (developer)
2016-08-23 14:32

 ZDoom fixed it in this changeset.
User avatar (0015523)
Edward-san (developer)
2016-08-23 14:36
edited on: 2016-08-23 15:36

 ZDoom fixed it and zandronum-zdoom-sync added it with this changeset. The problem is that the path to i_system.cpp is different (src/posix/i_system.cpp against src/sdl/i_system.cpp).


Also, is that really the only error? I see that there are other zdoom fixes as well:

'https://bitbucket.org/Torr_Samaho/zandronum-zdoom-sync/commits/cf6dc04d4170 [^]'
'https://bitbucket.org/Torr_Samaho/zandronum-zdoom-sync/commits/7c6e85b9eaf8 [^]'
'https://bitbucket.org/Torr_Samaho/zandronum-zdoom-sync/commits/7fc685d96943 [^]' (conflicting paths as well)

[edit]ninja'd. would be nice if the tracker could hold pushing comments when new and unread comments appear..
User avatar (0015524)
DrinkyBird (developer)
2016-08-23 15:47

 The tip of the default branch compiles fine (excluding the <sys/wait.h> error) on FreeBSD 10.3 using GCC 5.4.0, and I don't know what setup the person who made those other commits used, or whatever G/ZDoom made changes after the revision 3.0 is based on to require those commits.

Issue Community Support
Only registered users can voice their support. Click here to register, or here to log in.
Supporters: DrinkyBird DevilHunter
Opponents: No one explicitly opposes this issue yet.

- Issue History
Date Modified Username Field Change
2016-08-23 11:49 DrinkyBird New Issue
2016-08-23 11:51 DrinkyBird Note Added: 0015521
2016-08-23 14:32 Dusk Note Added: 0015522
2016-08-23 14:32 Dusk Assigned To => Torr Samaho
2016-08-23 14:32 Dusk Status new => needs review
2016-08-23 14:36 Edward-san Note Added: 0015523
2016-08-23 14:37 Edward-san Note Edited: 0015523 View Revisions
2016-08-23 15:36 Edward-san Note Edited: 0015523 View Revisions
2016-08-23 15:47 DrinkyBird Note Added: 0015524




Questions or other issues? Contact Us.

Links

Copyright © 2000 - 2024 MantisBT Team
Powered by Mantis Bugtracker