0002791: Moving slightly off a spawn makes you vunerable to join/defect telefrag in team games

Notes
(0015398) Edward-san (developer) 2016-07-19 17:30	This is caused by G_CheckSpot being called for the joining spectator having no body. This happens because selecting the team makes the server destroy the currently available spectator body. When the player's body is not present, the in-game players position is checked with the spawn spot with exact match, i.e. no bounds checking at all. The fix would be avoiding the body removal under these circumstances, but this must be discussed first.

(0015403) Edward-san (developer) 2016-07-20 16:45 edited on: 2016-07-20 16:46	Please check if this changeset:'https://bitbucket.org/zandronum/zandronum-sandbox/commits/49b6b1d75a0189c34dae8019750e3db2d7f4a526 [^]' fixes the issue and introduces no regressions in team gaming.

(0015404) WaTaKiD (updater) 2016-07-20 18:09	this 3.0 build contains the above commit: 'https://www.dropbox.com/s/0px3gg0ga5nqrb8/zandronum-3.0-r160720-1643-49b6b1d-windows.zip?dl=0 [^]'

(0015454) Edward-san (developer) 2016-08-17 08:45	I'm thinking there's a major problem, but I need some info: does the telefrag happen also when the victim moved a bit and then an enemy defects their team to join the victim's?

(0015462) WaTaKiD (updater) 2016-08-17 22:40	if the victim moves, then yes a defection has a chance to telefrag

(0015472) Edward-san (developer) 2016-08-18 08:47 edited on: 2016-08-18 08:49	Damn it, that's caused by the same issue as the spectator joining: the code in server_ChangeTeam destroys the player's body before the team spot selection. The fix has to be different. Sadly the fix must be postponed for after 3.0 release, because of possible side effects which should be avoided for now.

**Issue Community Support**
Only registered users can voice their support. Click here to register, or here to log in.
Supporters:	Combinebobnt
Opponents:	No one explicitly opposes this issue yet.

Issue Community Support

Only registered users can voice their support. Click here to register, or here to log in.

Supporters:

Combinebobnt

Opponents:

No one explicitly opposes this issue yet.

Issue History
Date Modified	Username	Field	Change
2016-07-19 17:17	Ru5tK1ng	New Issue
2016-07-19 17:19	Ru5tK1ng	Relationship added	related to 0001253
2016-07-19 17:21	Ru5tK1ng	Relationship added	related to 0001499
2016-07-19 17:30	Edward-san	Note Added: 0015398
2016-07-19 17:30	Edward-san	Status	new => confirmed
2016-07-20 16:45	Edward-san	Note Added: 0015403
2016-07-20 16:45	Edward-san	Assigned To	=> Edward-san
2016-07-20 16:45	Edward-san	Status	confirmed => feedback
2016-07-20 16:46	Edward-san	Note Edited: 0015403	View Revisions
2016-07-20 18:09	WaTaKiD	Note Added: 0015404
2016-08-17 08:45	Edward-san	Note Added: 0015454
2016-08-17 22:40	WaTaKiD	Note Added: 0015462
2016-08-18 08:47	Edward-san	Note Added: 0015472
2016-08-18 08:49	Edward-san	Note Edited: 0015472	View Revisions
2016-08-18 08:53	Edward-san	Assigned To	Edward-san =>
2016-08-18 08:53	Edward-san	Status	feedback => confirmed
2016-08-18 08:53	Edward-san	Summary	Moving slightly off a spawn makes you vunerable to telefrag in team games => Moving slightly off a spawn makes you vunerable to join telefrag in team games
2016-08-18 08:53	Edward-san	Description Updated	View Revisions
2016-08-18 08:54	Edward-san	Summary	Moving slightly off a spawn makes you vunerable to join telefrag in team games => Moving slightly off a spawn makes you vunerable to join/defect telefrag in team games
2016-10-15 16:32	Ru5tK1ng	Relationship added	related to 0001634