0002766: ReplaceTextures() no longer works online properly

Chat on our Discord Server Get the latest version: 3.1
Source Code

View Issue Details [ Jump to Notes ]

[ Issue History ] [ Print ]

Project

Category

View Status

Date Submitted

Last Update

0002766

Zandronum

[All Projects] Bug

public

2016-06-26 21:55

2018-09-30 21:39

Reporter

Dusk

Assigned To

Torr Samaho

Priority

normal

Severity

minor

Reproducibility

always

Status

closed

Resolution

fixed

Platform

OS Version

Product Version

2.1

Target Version

Fixed in Version

2.2

Summary

0002766: ReplaceTextures() no longer works online properly

Description

It looks like the ACS function ReplaceTextures no longer works online. It does not update clients of the change. Reconnecting solves the desync.

As for the cause, the client end of DLevelScript::ReplaceTextures gets fromname and toname to be NULL, causing the function to fail.

Steps To Reproduce

Launch a server and client with attached pwad:
zandronum -iwad doom -warp 3 1 -nomonsters -file replacetextures.pk3
zandronum -connect localhost -file replacetextures.pk3

Run "puke 1" as either the client or the server. The red fort is supposed to turn green but doesn't until the client reconnects.

Attached Files

replacetextures.pk3 [^] (979 bytes) 2016-06-26 21:55

Relationships

Notes
(0015149) Torr Samaho (administrator) 2016-06-28 19:45	Should be fixed now. Seems to have been caused by the ZDoom changes to dynamically generated ACS strings.

(0015181) WaTaKiD (updater) 2016-07-02 15:46	added in 3.0 with:'https://bitbucket.org/Torr_Samaho/zandronum/commits/b82e0cd2e09011c9fe30c2bdaa3b7585722a23a7 [^]'

(0015192) Ru5tK1ng (updater) 2016-07-02 19:05	Tested online with r160702-1232 and the sp_hot textures changed to marble without problem and showed up properly to newly connected clients. .

**Issue Community Support**
This issue is already marked as resolved. If you feel that is not the case, please reopen it and explain why.
Supporters:	No one explicitly supports this issue yet.
Opponents:	No one explicitly opposes this issue yet.

Issue History
Date Modified	Username	Field	Change
2016-06-26 21:55	Dusk	New Issue
2016-06-26 21:55	Dusk	File Added: replacetextures.pk3
2016-06-28 19:23	Torr Samaho	Product Version	=> 2.1
2016-06-28 19:45	Torr Samaho	Note Added: 0015149
2016-06-28 19:46	Torr Samaho	Assigned To	=> Torr Samaho
2016-06-28 19:46	Torr Samaho	Status	new => needs testing
2016-07-02 15:46	WaTaKiD	Note Added: 0015181
2016-07-02 19:05	Ru5tK1ng	Note Added: 0015192
2016-07-02 19:26	Dusk	Status	needs testing => resolved
2016-07-02 19:26	Dusk	Fixed in Version	=> 2.2
2016-07-02 19:26	Dusk	Resolution	open => fixed
2018-09-30 21:39	Blzut3	Status	resolved => closed

Questions or other issues? Contact Us.

Links

Doom and Doom II are the property of id Software.