Zandronum Chat on our Discord Server Get the latest version: 3.1
Source Code
My View | View Issues | Change Log | Roadmap | Zandronum Issue Support Ranking | Rules | My Account
  

View Issue Details [ Jump to Notes ] [ Issue History ] [ Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0002741Zandronum[All Projects] Bugpublic2016-05-26 00:572018-09-30 21:43
ReporterCatastrophe 
Assigned ToDusk 
PrioritynormalSeveritycrashReproducibilityalways
StatusclosedResolutionfixed 
PlatformMicrosoftOSWindowsOS VersionXP/Vista/7
Product Version2.1 
Target Version3.0Fixed in Version3.0 
Summary0002741: Database mod crash
DescriptionLoad up these files on ctf in order

'http://static.allfearthesentinel.net/wads/idl201x_b.pk3 [^]'
'http://gam.thewaitingroom.org/be_wads/fnf-stats-test.pk3 [^]'

join server

crash!
Attached Files

- Relationships

-  Notes
User avatar (0014984)
Catastrophe (reporter)
2016-05-26 00:59
edited on: 2016-05-26 01:01

 this is the script that is causing it.'http://hastebin.com/basomihura.vhdl [^]'
User avatar (0014985)
Catastrophe (reporter)
2016-05-26 04:58

 After more testing, I've figured it out, it is this line.

key = strParam(s:FNF_LONGESTFRAGSTREAK_NAME_, d:i);
setDBEntryString(FNF_SERVER_TOTALS, key, 0);

It appears doing setDBEntryString with an integer, such as 0, causes Zandronum to crash. Since you're only supposed to put strings in here, perhaps the ACS compiler should give an error if it isn't?
User avatar (0015013)
Dusk (developer)
2016-06-04 20:37

 The crash appears to happen when the const char *-type string pointers get nulled as a result of this.

If I change the database code to use FStrings, the crashing goes away.

Is this a good approach?
User avatar (0017791)
Catastrophe (reporter)
2017-05-30 23:33

 Is this being fixed? Ran into it again and I daresay it'll drive people insane trying to debug their mods.
User avatar (0017793)
Torr Samaho (administrator)
2017-06-04 08:45

 Should definitely be fixed, but I'm not sure that we should change the database code from const char * to FString for this. A few sanity checks on the pointers should be enough. I'll have a look.
User avatar (0017795)
Torr Samaho (administrator)
2017-06-04 08:53

 Can you check if this fixes the problem?
User avatar (0017812)
Ru5tK1ng (updater)
2017-06-10 04:50

 -Updated the example wad links-

That build seemed to fix the issue, the server didn't crash.
User avatar (0017838)
Ru5tK1ng (updater)
2017-06-18 19:14

 Pulled the latest changes and I didn't get any crash online.

Issue Community Support
This issue is already marked as resolved.
If you feel that is not the case, please reopen it and explain why.
Supporters: Korshun
Opponents: No one explicitly opposes this issue yet.

- Issue History
Date Modified Username Field Change
2016-05-26 00:57 Catastrophe New Issue
2016-05-26 00:59 Catastrophe Note Added: 0014984
2016-05-26 01:01 Catastrophe Note Edited: 0014984 View Revisions
2016-05-26 04:58 Catastrophe Note Added: 0014985
2016-06-04 19:45 Dusk Assigned To => Dusk
2016-06-04 19:45 Dusk Status new => assigned
2016-06-04 20:37 Dusk Note Added: 0015013
2016-06-04 20:37 Dusk Status assigned => needs review
2016-06-04 20:38 Dusk View Status private => public
2017-05-30 23:33 Catastrophe Note Added: 0017791
2017-06-04 08:45 Torr Samaho Note Added: 0017793
2017-06-04 08:53 Torr Samaho Note Added: 0017795
2017-06-04 08:53 Torr Samaho Status needs review => needs testing
2017-06-10 04:50 Ru5tK1ng Note Added: 0017812
2017-06-10 04:50 Ru5tK1ng Description Updated View Revisions
2017-06-18 19:14 Ru5tK1ng Note Added: 0017838
2017-06-18 19:14 Ru5tK1ng Status needs testing => resolved
2017-06-18 19:14 Ru5tK1ng Resolution open => fixed
2017-06-18 19:14 Ru5tK1ng Fixed in Version => 3.0
2017-06-18 19:14 Ru5tK1ng Target Version => 3.0
2018-09-30 21:43 Blzut3 Status resolved => closed




Questions or other issues? Contact Us.

Links

Copyright © 2000 - 2024 MantisBT Team
Powered by Mantis Bugtracker