Zandronum Chat @ irc.zandronum.com
#zandronum
Get the latest version: 2.1.2
Source Code

View Issue Details Jump to Notes ] Issue History ] Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0002667Zandronum[All Projects] Bugpublic2016-03-06 21:542017-04-15 13:12
ReporterWaTaKiD 
Assigned ToTorr Samaho 
PrioritynormalSeverityminorReproducibilityalways
Statusneeds testingResolutionopen 
PlatformMicrosoftOSWindowsOS VersionXP/Vista/7
Product Version2.1 
Target VersionFixed in Version 
Summary0002667: Server informs the client about map changes, before the client fully loaded the map.
Descriptionfound with 3.0-r160229-1221 and cl_showwarnings 1
Steps To Reproducehost server with doom2.wad map14
connect, join, warp 3022 -512, and exit
client_SoundActor: Couldn't find thing: 262
Attached Files

- Relationships
parent of 0002947acknowledged SoundActorIfNotPlaying: couldn't find actor 
parent of 0002951new SetThingState: couldn't find actor 
parent of 0002952new MoveThing: couldn't find actor 
parent of 0003008new DoSectorLightPhased: couldn't find sector 
parent of 0002950new client_DoRotatePoly: Invalid polyobj number 
has duplicate 0002652closed client_DoSectorLightStrobe: Cannot find sector 
has duplicate 0002666closed client_DoSectorLightFireFlicker: Cannot find sector 
has duplicate 0002665closed client_DoSectorLightLightFlash: Cannot find sector 
has duplicate 0002664closed client_DoSectorLightGlow: Cannot find sector 
child of 0002561resolvedDusk CLIENT_WARNING_MESSAGES 
Not all the children of this issue are yet resolved or closed.

-  Notes
User avatar (0016337)
Torr Samaho (administrator)
2016-11-27 09:40

This one is tricky. The server already starts sending actor updates for the new map right after it asked the client to authenticate the new map, i.e. before the client loaded the map. This way the client is asked to do stuff with actors he doesn't know about yet, which causes the warnings. One would have to prevent the server from sending this kind of updates to clients who didn't load the map yet.

Adding

    if ( !( _flags & SVCF_ONLYTHISCLIENT ) && ( SERVER_GetClient( _current )->State == CLS_SPAWNED_BUT_NEEDS_AUTHENTICATION ) )
        return false;

to ClientIterator::isCurrentValid seems to do the trick, but this may possibly break other stuff since it affects all net commands.
User avatar (0016345)
Torr Samaho (administrator)
2016-11-27 10:10

For the record, this is also happening in 2.1.2. We just didn't notice it, because 2.1.2 doesn't have cl_showwarnings.
User avatar (0017016)
Torr Samaho (administrator)
2017-03-19 14:05

I thought about 0002667:0016337 a bit more and think this needs to be handled on a command level and integrated into the code generator.https://bitbucket.org/zandronum/zandronum-sandbox/commits/dc038f3ec5bb3592ca6cd49f8c3dbe89a6ebf6fd [^] is a proof of concept to fix this for 0002947.
User avatar (0017135)
Torr Samaho (administrator)
2017-04-15 13:12

After further thinking about this there seems to be an easier way to fix this.

https://bitbucket.org/zandronum/zandronum-sandbox/commits/de63310eb8c3735ee1e5e10da5cd9e4bfb1de7a4 [^] is a very experimental attempt to fix this by simply restricting to whom broadcasted packets are sent.

Issue Community Support
Only registered users can voice their support. Click here to register, or here to log in.
Supporters: No one explicitly supports this issue yet.
Opponents: No one explicitly opposes this issue yet.

- Issue History
Date Modified Username Field Change
2016-03-06 21:54 WaTaKiD New Issue
2016-03-06 21:54 WaTaKiD Relationship added child of 0002561
2016-11-27 09:40 Torr Samaho Note Added: 0016337
2016-11-27 09:40 Torr Samaho Status new => confirmed
2016-11-27 10:01 Torr Samaho Relationship added has duplicate 0002652
2016-11-27 10:03 Torr Samaho Relationship added has duplicate 0002666
2016-11-27 10:04 Torr Samaho Relationship added has duplicate 0002665
2016-11-27 10:05 Torr Samaho Relationship added related to 0002664
2016-11-27 10:06 Torr Samaho Relationship deleted related to 0002664
2016-11-27 10:06 Torr Samaho Relationship added has duplicate 0002664
2016-11-27 10:07 Torr Samaho Product Version 3.0-beta => 2.1
2016-11-27 10:07 Torr Samaho Summary client_SoundActor: Couldn't find thing => Server informs the client about map changes, before the client fully loaded the map.
2016-11-27 10:10 Torr Samaho Note Added: 0016345
2017-03-19 11:17 Torr Samaho Relationship added parent of 0002947
2017-03-19 11:18 Torr Samaho Relationship added related to 0002952
2017-03-19 11:19 Torr Samaho Relationship added related to 0002951
2017-03-19 11:19 Torr Samaho Relationship deleted related to 0002951
2017-03-19 11:19 Torr Samaho Relationship added parent of 0002951
2017-03-19 11:20 Torr Samaho Relationship deleted related to 0002952
2017-03-19 11:20 Torr Samaho Relationship added parent of 0002952
2017-03-19 11:21 Torr Samaho Relationship added parent of 0003008
2017-03-19 11:22 Torr Samaho Relationship added parent of 0002950
2017-03-19 14:05 Torr Samaho Note Added: 0017016
2017-04-15 13:12 Torr Samaho Note Added: 0017135
2017-04-15 13:12 Torr Samaho Assigned To => Torr Samaho
2017-04-15 13:12 Torr Samaho Status confirmed => needs testing






Questions or other issues? Contact Us.

Links


Copyright © 2000 - 2017 MantisBT Team
Powered by Mantis Bugtracker