Zandronum Chat on our Discord Server Get the latest version: 3.1
Source Code
My View | View Issues | Change Log | Roadmap | Zandronum Issue Support Ranking | Rules | My Account
  

View Issue Details [ Jump to Notes ] [ Issue History ] [ Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0002651Zandronum[All Projects] Bugpublic2016-03-01 17:202018-09-30 21:57
ReporterDusk 
Assigned ToEdward-san 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOSOS Version
Product Version2.1 
Target Version3.0Fixed in Version3.0 
Summary0002651: SVC_SPAWNPLAYER sends the player class with two bytes
DescriptionThe CurrentPlayerClass field in player_t is a BYTE. Which means the second byte is going to waste and we should just use one.


    BYTE CurrentPlayerClass; // class # for this player instance
Attached Files

- Relationships

-  Notes
User avatar (0014521)
Edward-san (developer)
2016-03-01 19:47

 'https://bitbucket.org/Torr_Samaho/zandronum/pull-requests/76/fixed-the-spawn-player-server-command-used/diff [^]'
User avatar (0014559)
cobalt (updater)
2016-03-06 13:07

 Issue addressed by commit 7cad9115a2b0: - Fixed: the 'spawn player' server command used 1 more byte than needed (fixes 2651).
Committed by Edoardo Prezioso [edward-san] on Wednesday 31 December 1969 23:59:57

Changes in files:

 docs/zandronum-history.txt | 1 +
 src/cl_main.cpp | 2 +-
 src/sv_commands.cpp | 2 +-
 3 files changed, 3 insertions(+), 2 deletions(-)
User avatar (0015660)
Ru5tK1ng (updater)
2016-09-18 15:46

 This was overwritten by:

'https://bitbucket.org/Torr_Samaho/zandronum/commits/f3a66955c77b0ced59604d73117f4e6ab95080de?at=default#chg-src/sv_commands.cpp [^]'
User avatar (0015662)
Edward-san (developer)
2016-09-18 21:05

 The code changed, sure, but the fix is still present, here.

Issue Community Support
This issue is already marked as resolved.
If you feel that is not the case, please reopen it and explain why.
Supporters: No one explicitly supports this issue yet.
Opponents: No one explicitly opposes this issue yet.

- Issue History
Date Modified Username Field Change
2016-03-01 17:20 Dusk New Issue
2016-03-01 18:52 Edward-san Assigned To => Edward-san
2016-03-01 18:52 Edward-san Status new => assigned
2016-03-01 19:47 Edward-san Note Added: 0014521
2016-03-01 19:47 Edward-san Status assigned => needs review
2016-03-06 13:07 cobalt Status needs review => needs testing
2016-03-06 13:07 cobalt Target Version => 3.0
2016-03-06 13:07 cobalt Description Updated View Revisions
2016-03-06 13:07 cobalt Note Added: 0014559
2016-09-18 15:46 Ru5tK1ng Note Added: 0015660
2016-09-18 15:46 Ru5tK1ng Status needs testing => closed
2016-09-18 15:46 Ru5tK1ng Resolution open => no change required
2016-09-18 15:46 Ru5tK1ng Target Version 3.0 =>
2016-09-18 15:46 Ru5tK1ng Description Updated View Revisions
2016-09-18 21:05 Edward-san Note Added: 0015662
2016-09-18 21:05 Edward-san Status closed => resolved
2016-09-18 21:05 Edward-san Resolution no change required => fixed
2016-09-18 21:05 Edward-san Fixed in Version => 3.0
2016-09-18 21:05 Edward-san Target Version => 3.0
2016-11-27 00:24 Edward-san Product Version 2.2 => 2.1
2018-09-30 21:57 Blzut3 Status resolved => closed




Questions or other issues? Contact Us.

Links

Copyright © 2000 - 2024 MantisBT Team
Powered by Mantis Bugtracker