Zandronum Chat on our Discord Server Get the latest version: 3.1
Source Code
My View | View Issues | Change Log | Roadmap | Zandronum Issue Support Ranking | Rules | My Account
  

View Issue Details [ Jump to Notes ] [ Issue History ] [ Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0002431Zandronum[All Projects] Bugpublic2015-09-03 16:432018-09-30 21:55
ReporterZalewa 
Assigned ToTorr Samaho 
PrioritynormalSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformMicrosoftOSWindowsOS VersionXP/Vista/7
Product Version3.0-beta 
Target Version3.0Fixed in Version3.0 
Summary0002431: Rapid PUKENAME on a net script will get you kicked from the server for "client command flood".
DescriptionKick threshold for client command flood is too strict when it comes to pukename. Modifications may bind pukename ccmd to a key to provide extended functionality to the player. An example of this is in ZDCMP2 where grenade throw is a pukename that can be bound to a key. A player who rapidly presses the bound key will get kicked out from the server very quickly. Flood kick thresholds shouldn't be so strict. I've provided an example where puking an empty script will get you kicked out too. I haven't verified if puke ccmd suffers from the same problem.
Steps To Reproduce1. Download the attached clientflood.pk3.
2. Load it up on a server.
3. Join this server.
4. Run "PUKENAME abc" several times in the console in rapid succession.
Attached Files? file icon clientflood.pk3 [^] (537 bytes) 2015-09-03 16:43

- Relationships
related to 0002519closedTorr Samaho some scripts in this wad dont work properly online 

-  Notes
User avatar (0013385)
Dusk (developer)
2015-09-03 17:03

 puke and pukename use the same netcode, thus puke must be affected too. Which in turn suggests this problem affects earlier Zandronum versions as well.
User avatar (0013388)
ZzZombo (reporter)
2015-09-04 08:59

 But, since it uses strings that consume more space, it's evident only there, I think.
User avatar (0013391)
Dusk (developer)
2015-09-04 14:29

 What? Names are internally numbers. No strings are sent.
User avatar (0016225)
Torr Samaho (administrator)
2016-11-20 21:06

 There shouldn't be any flood protection for puking valid scripts, but the server will kick clients that flood puking scripts that are not allowed to be puked (which legit clients shouldn't do since they will not request the server to puke such a script). Possibly there was a bug that caused this. Can you check whether it still happens for you in the latest beta?
User avatar (0016304)
Zalewa (developer)
2016-11-23 18:21

 I tested in 3.0-alpha-r161030-2038 and the problem seems to be fixed. I no longer get kicked by puking NET scripts.

I don't get kicked for puking non-NET scripts either, unless I should be doing this at the rate that's impossible to do by repeating UP+ENTER in the console.
User avatar (0016305)
Torr Samaho (administrator)
2016-11-23 18:30
Quote from Zalewa

I don't get kicked for puking non-NET scripts either, unless I should be doing this at the rate that's impossible to do by repeating UP+ENTER in the console.

A legit client notices that a non-NET script cannot be puked and thus will simply not request the server to do so. The flood kick will only happen if the client is modified to ignore the check and request the puking anyway.
User avatar (0016449)
Ru5tK1ng (updater)
2016-12-08 04:23

 I'll mark this as resolved based upon the above check with 3.0-alpha-r161030.

Issue Community Support
This issue is already marked as resolved.
If you feel that is not the case, please reopen it and explain why.
Supporters: No one explicitly supports this issue yet.
Opponents: No one explicitly opposes this issue yet.

- Issue History
Date Modified Username Field Change
2015-09-03 16:43 Zalewa New Issue
2015-09-03 16:43 Zalewa File Added: clientflood.pk3
2015-09-03 17:03 Dusk Note Added: 0013385
2015-09-04 08:59 ZzZombo Note Added: 0013388
2015-09-04 14:29 Dusk Note Added: 0013391
2016-11-20 21:04 Torr Samaho Product Version 3.0 => 3.0-beta
2016-11-20 21:04 Torr Samaho Target Version => 3.0
2016-11-20 21:06 Torr Samaho Note Added: 0016225
2016-11-20 21:07 Torr Samaho Relationship added related to 0002519
2016-11-20 21:08 Torr Samaho Assigned To => Torr Samaho
2016-11-20 21:08 Torr Samaho Status new => needs testing
2016-11-23 18:05 Zalewa File Added: forbidden.pk3
2016-11-23 18:08 Zalewa Note Added: 0016303
2016-11-23 18:10 Zalewa Note Deleted: 0016303
2016-11-23 18:10 Zalewa File Deleted: forbidden.pk3
2016-11-23 18:21 Zalewa Note Added: 0016304
2016-11-23 18:30 Torr Samaho Note Added: 0016305
2016-12-08 04:23 Ru5tK1ng Note Added: 0016449
2016-12-08 04:23 Ru5tK1ng Status needs testing => resolved
2016-12-08 04:23 Ru5tK1ng Resolution open => fixed
2016-12-08 04:23 Ru5tK1ng Fixed in Version => 3.0
2018-09-30 21:55 Blzut3 Status resolved => closed




Questions or other issues? Contact Us.

Links

Copyright © 2000 - 2024 MantisBT Team
Powered by Mantis Bugtracker