0002312: sv_forcegldefaults 1 does not cover gl_distfog changes.

Notes
(0012726) Edward-san (developer) 2015-06-14 21:04	Should be taken care of with'https://bitbucket.org/crimsondusk/zandronum-sandbox-stable/commits/d277446ec0b9cf74d85c66703549ece5d6d952d4 [^]' .

(0012728) Edward-san (developer) 2015-06-14 21:18	Build with the fix:'https://www.dropbox.com/s/anco00od31qg2ok/zandronum-2.1-150614-2059-d277446-windows.zip?dl=0 [^]' .

(0012759) unknownna (updater) 2015-06-20 13:06	Yeah, that seems to work fine.

(0012766) Torr Samaho (administrator) 2015-06-21 08:54	Copying any pasting the large for loop doesn't look like a clean way to fix this.

(0012767) Edward-san (developer) 2015-06-21 09:12	What about'https://bitbucket.org/crimsondusk/zandronum-sandbox-stable/commits/91e0d813570154992094489cb450114e6c9096e4 [^]' ?

(0012768) Torr Samaho (administrator) 2015-06-21 09:29	That's better but has a large delta to the original GZDoom code. Does the usual trick with the define not work if you put it inside the CUSTOM_CVAR (Int, gl_distfog ... block, combined with with the necessary addition in zadmflags (like done for gl_lightmode)?

(0012769) Edward-san (developer) 2015-06-21 10:00 edited on: 2015-06-21 10:25	I'm lost there, but I improved the code and should be okay with delta:'https://bitbucket.org/crimsondusk/zandronum-sandbox-stable/commits/86e82b058afd69e7bcdc41018ce4a58f20e218e5 [^]' Found an useless delta inside the function. Removed with'https://bitbucket.org/crimsondusk/zandronum-sandbox-stable/commits/6e43e0480b149f4efbc014be655169a061d2638a [^]' .

(0012770) Torr Samaho (administrator) 2015-06-21 14:04	The biggest delta is that you rip out the code that creates the table from the place where it is in GZDoom and move it elsewhere. Your recent changes have no effect on this. What I meant is, what prevents you from putting OVERRIDE_INT_GL_CVAR_IF_NECESSARY( gl_distfog ) into CUSTOM_CVAR (Int, gl_distfog ... and gl_distfog.Callback(); into CUSTOM_CVAR (Int, zadmflags, ... ? It may not work exactly like this, but is there anything that prevents us from using this general strategy that we already successfully apply for all the other GL settings?

(0012771) Edward-san (developer) 2015-06-21 14:44 edited on: 2015-06-21 14:45	It seems I overlooked that.'https://bitbucket.org/crimsondusk/zandronum-sandbox-stable/commits/e8b7e5bd26aef86e98ce7c49d0832730907b88a2 [^]' should handle this.

(0013927) Edward-san (developer) 2015-12-01 11:20	Recovered the fix from the old repository:'https://bitbucket.org/Torr_Samaho/zandronum-stable/pull-requests/18/fixed-sv_forcegldefaults-1-didnt-cover/diff [^]'

(0013941) cobalt (updater) 2015-12-06 20:12	Issue addressed by commit d60f6521ed73: - Fixed: sv_forcegldefaults 1 didn't cover gl_distfog changes (addresses 2312). Committed by Edoardo Prezioso [edward-san] on Tuesday 01 December 2015 12:18:44 Changes in files: docs/zandronum-history.txt \| 1 + src/d_main.cpp \| 8 ++++++-- src/gl/renderer/gl_lightdata.cpp \| 3 +++ 3 files changed, 10 insertions(+), 2 deletions(-)

(0014830) Ru5tK1ng (updater) 2016-05-06 22:02	Tested this with r160410-1037 and distfog couldn't be toggled with forced defaults on.

**Issue Community Support**
This issue is already marked as resolved. If you feel that is not the case, please reopen it and explain why.
Supporters:	No one explicitly supports this issue yet.
Opponents:	No one explicitly opposes this issue yet.

Issue Community Support

This issue is already marked as resolved.
If you feel that is not the case, please reopen it and explain why.

Supporters:

No one explicitly supports this issue yet.

Opponents:

No one explicitly opposes this issue yet.

Issue History
Date Modified	Username	Field	Change
2015-06-14 20:43	Edward-san	New Issue
2015-06-14 20:43	Edward-san	Status	new => assigned
2015-06-14 20:43	Edward-san	Assigned To	=> Edward-san
2015-06-14 20:44	Edward-san	Relationship added	related to 0002258
2015-06-14 21:04	Edward-san	Note Added: 0012726
2015-06-14 21:04	Edward-san	Status	assigned => needs review
2015-06-14 21:05	Edward-san	Description Updated	View Revisions
2015-06-14 21:18	Edward-san	Note Added: 0012728
2015-06-20 13:06	unknownna	Note Added: 0012759
2015-06-21 08:54	Torr Samaho	Note Added: 0012766
2015-06-21 08:54	Torr Samaho	Status	needs review => feedback
2015-06-21 09:12	Edward-san	Note Added: 0012767
2015-06-21 09:12	Edward-san	Status	feedback => assigned
2015-06-21 09:12	Edward-san	Status	assigned => needs review
2015-06-21 09:29	Torr Samaho	Note Added: 0012768
2015-06-21 09:30	Torr Samaho	Status	needs review => feedback
2015-06-21 10:00	Edward-san	Note Added: 0012769
2015-06-21 10:00	Edward-san	Status	feedback => assigned
2015-06-21 10:00	Edward-san	Status	assigned => needs review
2015-06-21 10:25	Edward-san	Note Edited: 0012769	View Revisions
2015-06-21 14:04	Torr Samaho	Note Added: 0012770
2015-06-21 14:04	Torr Samaho	Status	needs review => feedback
2015-06-21 14:44	Edward-san	Note Added: 0012771
2015-06-21 14:44	Edward-san	Status	feedback => assigned
2015-06-21 14:44	Edward-san	Status	assigned => needs review
2015-06-21 14:45	Edward-san	Note Edited: 0012771	View Revisions
2015-06-24 22:43	Dusk	Target Version	2.1 => 2.2
2015-12-01 11:20	Edward-san	Note Added: 0013927
2015-12-05 12:11	Torr Samaho	Status	needs review => needs testing
2015-12-06 20:12	cobalt	Note Added: 0013941
2016-05-06 22:02	Ru5tK1ng	Note Added: 0014830
2016-05-06 22:03	Ru5tK1ng	Status	needs testing => resolved
2016-05-06 22:03	Ru5tK1ng	Resolution	open => fixed
2016-05-06 22:03	Ru5tK1ng	Fixed in Version	=> 2.2
2018-09-30 21:40	Blzut3	Status	resolved => closed