Zandronum Chat on our Discord Server Get the latest version: 3.1
Source Code

View Issue Details Jump to Notes ] Issue History ] Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0002195Zandronum[All Projects] Bugpublic2015-04-17 20:152018-09-30 21:37
ReporterCatastrophe 
Assigned ToEdward-san 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformMicrosoftOSWindowsOS VersionXP/Vista/7
Product Version 
Target Version2.1Fixed in Version2.1 
Summary0002195: a_changeflag and +thruspecies is very jittery online
DescriptionBasically, giving players an item that changes their +thruspecies flag to false makes them really jittery when colliding with other players who've also had their flag changed.

This works fine offline, but online it is broken.
Steps To ReproduceStart a server with the attached wad
Add a bunch of bots
Puke 203 to remove +thruspecies from everyone
Try to bump into other players, and notice how jittery it is compared to online
Attached Files? file icon thruspeciesbug.wad [^] (101,932 bytes) 2015-04-17 20:15

- Relationships

-  Notes
User avatar (0012126)
Catastrophe (reporter)
2015-04-17 20:16

compared to offline* not online.
User avatar (0012129)
Edward-san (developer)
2015-04-17 21:40

Done:'https://bitbucket.org/crimsondusk/zandronum-sandbox/commits/bbaf2fa9c7e6b1ceb1b5a41aa633041a90d70fdf [^]'
User avatar (0012131)
Torr Samaho (administrator)
2015-04-18 13:19

See my comment on bitbucket.
User avatar (0012135)
Edward-san (developer)
2015-04-18 14:31
edited on: 2015-04-18 14:32

Fixed in the same head. While working on this, I noticed that the clients don't relink the actors in case MF_NOSECTOR is changed (like it's done in the A_ChangeFlag code). See'https://bitbucket.org/crimsondusk/zandronum-sandbox/commits/e8cfadb7f3fd0be56eb7903da83fd716e91be52c [^]' for a fix.

User avatar (0012167)
cobalt (updater)
2015-04-25 09:31

Issue addressed by commit 3fb9a04c953c: - Fixed: clients were not informed of some actor flag modifications with A_ChangeFlag (addresses 2195).
Committed by edward_san [edward-san] on Sunday 19 April 2015 13:26:58

Changes in files:
 docs/zandronum-history.txt | 1 +
 src/cl_main.cpp | 15 ++++++++++++---
 src/network.h | 17 +++++++++++------
 src/sv_commands.cpp | 7 ++++---
 src/sv_commands.h | 2 +-
 src/thingdef/thingdef_codeptr.cpp | 18 ++++++++++--------
 6 files changed, 39 insertions(+), 21 deletions(-)
User avatar (0012171)
Hypnotoad (reporter)
2015-04-25 22:28

Confirmed fixed after testing in local server.
User avatar (0012172)
Edward-san (developer)
2015-04-25 22:59

WaTaKiD and I discovered that the clients, after the puke is done, would desync again after a changemap map change.'https://bitbucket.org/crimsondusk/zandronum-sandbox-stable/commits/67ef3e0be7f4652acccdb27cbed2a609f7dd29ff [^]' should fix this.
User avatar (0012363)
Torr Samaho (administrator)
2015-05-24 11:50

I transplanted the fix.

Issue Community Support
This issue is already marked as resolved.
If you feel that is not the case, please reopen it and explain why.
Supporters: No one explicitly supports this issue yet.
Opponents: No one explicitly opposes this issue yet.

- Issue History
Date Modified Username Field Change
2015-04-17 20:15 Catastrophe New Issue
2015-04-17 20:15 Catastrophe File Added: thruspeciesbug.wad
2015-04-17 20:16 Catastrophe Note Added: 0012126
2015-04-17 20:37 Edward-san Note Added: 0012128
2015-04-17 20:37 Edward-san Assigned To => Edward-san
2015-04-17 20:37 Edward-san Status new => assigned
2015-04-17 21:40 Edward-san Note Added: 0012129
2015-04-17 21:40 Edward-san Status assigned => needs review
2015-04-17 21:40 Edward-san Note Deleted: 0012128
2015-04-18 13:19 Torr Samaho Note Added: 0012131
2015-04-18 13:20 Torr Samaho Status needs review => feedback
2015-04-18 14:31 Edward-san Note Added: 0012135
2015-04-18 14:32 Edward-san Note Edited: 0012135 View Revisions
2015-04-23 20:31 Edward-san Status feedback => needs review
2015-04-23 20:31 Edward-san Target Version => 2.1
2015-04-25 09:31 cobalt Status needs review => needs testing
2015-04-25 09:31 cobalt Description Updated View Revisions
2015-04-25 09:31 cobalt Steps to Reproduce Updated View Revisions
2015-04-25 09:31 cobalt Note Added: 0012167
2015-04-25 22:28 Hypnotoad Note Added: 0012171
2015-04-25 22:59 Edward-san Note Added: 0012172
2015-05-10 20:19 Edward-san Status needs testing => needs review
2015-05-24 11:50 Torr Samaho Note Added: 0012363
2015-05-24 11:50 Torr Samaho Status needs review => needs testing
2015-06-24 22:46 Dusk Status needs testing => resolved
2015-06-24 22:46 Dusk Fixed in Version => 2.2
2015-06-24 22:46 Dusk Resolution open => fixed
2015-06-24 22:47 Dusk Fixed in Version 2.2 => 2.1
2018-09-30 21:37 Blzut3 Status resolved => closed






Questions or other issues? Contact Us.

Links


Copyright © 2000 - 2024 MantisBT Team
Powered by Mantis Bugtracker