0002042: A_WeaponBob exists

Notes
(0011198) Edward-san (developer) 2015-01-01 22:15	To be more precise, it was introduced in ZDoom r1698, then it was removed in r1711.

(0011199) Dusk (developer) 2015-01-01 22:17 edited on: 2015-01-01 22:54	Was removed here:'http://zdoom.org/Changelog/23e4c47/files [^]' (thanks edward-san for pointing this out) Looks like it was otherwise backported but the action function implementation was never removed. It looks like it's not exported to DECORATE through an 'action native' statement in Inventory currently either. EDIT: So turns out this was first backported out of sequence (what.) and then backported in sequence. It must've been removed somewhere in between, can't find out where...

(0011202) Edward-san (developer) 2015-01-01 22:53 edited on: 2015-01-01 22:54	In other words: - Backport out-of-sequence of zdoom r1689 - Backport out-of-sequence of zdoom r1711 (which removed A_WeaponBob properly) - Backport in sequence of r1689 - Backport inf sequence of r1711 (whoops!)

(0011209) Torr Samaho (administrator) 2015-01-02 13:18	You are right, this was a merge error. The code is removed now.

(0011210) cobalt (updater) 2015-01-02 13:23	Issue addressed by commit 8ad299b21096: Removed some obsolete ZDoom code that already should have been removed in 81e9ceb7635539aa528e7db49c999e23365c6f67 (fixes 2042). Committed by Benjamin Berkels [Torr Samaho] on Friday 02 January 2015 14:12:11 Changes in files: src/p_pspr.cpp \| 23 ----------------------- 1 files changed, 0 insertions(+), 23 deletions(-)

(0011291) Dusk (developer) 2015-01-05 20:11	Since we ultimately only ended up removing dead code, there is no testing to do.

**Issue Community Support**
This issue is already marked as resolved. If you feel that is not the case, please reopen it and explain why.
Supporters:	No one explicitly supports this issue yet.
Opponents:	No one explicitly opposes this issue yet.

Issue Community Support

This issue is already marked as resolved.
If you feel that is not the case, please reopen it and explain why.

Supporters:

No one explicitly supports this issue yet.

Opponents:

No one explicitly opposes this issue yet.

Issue History
Date Modified	Username	Field	Change
2015-01-01 22:00	Dusk	New Issue
2015-01-01 22:01	Dusk	Product Version	2.0 => 2.0-beta
2015-01-01 22:15	Edward-san	Note Added: 0011198
2015-01-01 22:17	Dusk	Note Added: 0011199
2015-01-01 22:20	Edward-san	Note Added: 0011200
2015-01-01 22:21	Edward-san	Note Edited: 0011200	View Revisions
2015-01-01 22:30	Edward-san	Note Edited: 0011200	View Revisions
2015-01-01 22:32	Edward-san	Note Deleted: 0011200
2015-01-01 22:39	Dusk	Note Edited: 0011199	View Revisions
2015-01-01 22:48	Dusk	Note Edited: 0011199	View Revisions
2015-01-01 22:49	Dusk	Note Edited: 0011199	View Revisions
2015-01-01 22:53	Edward-san	Note Added: 0011202
2015-01-01 22:54	Edward-san	Note Edited: 0011202	View Revisions
2015-01-01 22:54	Dusk	Note Edited: 0011199	View Revisions
2015-01-02 13:16	cobalt	Assigned To	=> Torr Samaho
2015-01-02 13:16	cobalt	Status	new => needs testing
2015-01-02 13:16	cobalt	Target Version	=> 2.0
2015-01-02 13:16	cobalt	Description Updated	View Revisions
2015-01-02 13:17	cobalt	Note Added: 0011208
2015-01-02 13:18	Torr Samaho	Note Added: 0011209
2015-01-02 13:23	cobalt	Note Added: 0011210
2015-01-02 13:27	Torr Samaho	Note Deleted: 0011208
2015-01-05 20:11	Dusk	Note Added: 0011291
2015-01-05 20:11	Dusk	Status	needs testing => resolved
2015-01-05 20:11	Dusk	Fixed in Version	=> 2.0
2015-01-05 20:11	Dusk	Resolution	open => fixed
2018-09-30 23:10	Blzut3	Status	resolved => closed

Relationships