0002010: Admin lists aren't working at all.

Chat on our Discord Server Get the latest version: 3.1
Source Code

View Issue Details [ Jump to Notes ]

[ Issue History ] [ Print ]

Project

Category

View Status

Date Submitted

Last Update

0002010

Zandronum

[All Projects] Bug

public

2014-11-25 19:32

2017-11-08 21:40

Reporter

Ch0wW

Assigned To

Priority

normal

Severity

major

Reproducibility

always

Status

closed

Resolution

unable to reproduce

Platform

Any

OS Version

Any

Product Version

1.3

Target Version

Fixed in Version

Summary

0002010: Admin lists aren't working at all.

Description

I tried to understand why the adminlists aren't letting me to connect on the server when it was full.

It simply looks like it doesn't work at all, as it doesn't understand the netadress of the player.

It confirmed when I tried Konar6's patch with auto-rcon for people in the adminlist.

Steps To Reproduce

[PRE-REQUISITES] Get yourself into the Adminlist file.

1) Join a server full (or make a server with sv_maxclients to 0)
2) Join it.
3) "Server is full" while it should accept you.

Additional Information

======= FIXING THE PROBLEM ========

In SV_MAIN.CPP :

Line 1994:

Replace:
if ( g_AdminIPList.isIPInList ( AddressFrom ) )
By:
if ( SERVER_GetAdminList()->isIPInList ( szAddress ))

vvvvvvvvvvvvvvvvvvvvvv

For Konar6:

Replace:
if ( SERVER_GetAdminList()->isIPInList( SERVER_GetClient( lClient )->Address ) )
by:
if ( g_AdminIPList.isIPInList( szAddress ) )

Attached Files

Relationships

Notes
(0010975) Ch0wW (reporter) 2014-11-25 20:02 edited on: 2014-11-25 20:41	for the fix, I forgot to add this, which should be ABOVE: NETWORK_AddressToIPStringArray( AddressFrom, szAddress ); So it works for [Maxplayers]+1 person... Kinda strange then, if we have the possibility to add multiple admins to the list, don't you think? If multiple admins would connect to it, other than localhost, what could we do, unless commenting the very first check for the SERVER_FindFreeClientSlot( void ) function?

(0010976) DevilHunter (reporter) 2014-11-25 21:38	It works fine for me™

(0011026) Dusk (developer) 2014-12-02 13:52	SERVER_GetAdminList returns a pointer to g_AdminIPList. How does changing the way it's called fix any scemantic behavior? To me this sounds like the problem in 0001194. What happens if you revert the change and compile the binary? Do admin lists work then?

(0018826) Dusk (developer) 2017-11-08 21:40	Still works fine for me and no feedback was given, closing.

**Issue Community Support**
This issue is already marked as resolved. If you feel that is not the case, please reopen it and explain why.
Supporters:	JC
Opponents:	No one explicitly opposes this issue yet.

Issue History
Date Modified	Username	Field	Change
2014-11-25 19:32	Ch0wW	New Issue
2014-11-25 20:02	Ch0wW	Note Added: 0010975
2014-11-25 20:41	Ch0wW	Note Edited: 0010975	View Revisions
2014-11-25 21:38	DevilHunter	Note Added: 0010976
2014-12-02 13:52	Dusk	Note Added: 0011026
2014-12-02 13:52	Dusk	Status	new => feedback
2017-11-08 21:40	Dusk	Note Added: 0018826
2017-11-08 21:40	Dusk	Status	feedback => closed
2017-11-08 21:40	Dusk	Resolution	open => unable to reproduce

Questions or other issues? Contact Us.

Links

Doom and Doom II are the property of id Software.