0001994: Adding +NOSKIN breaks skin scaling in SKININFO

Chat on our Discord Server Get the latest version: 3.1
Source Code

View Issue Details [ Jump to Notes ]

[ Issue History ] [ Print ]

Project

Category

View Status

Date Submitted

Last Update

0001994

Zandronum

[All Projects] Bug

public

2014-11-09 02:11

2018-09-30 22:59

Reporter

Catastrophe

Assigned To

Torr Samaho

Priority

normal

Severity

minor

Reproducibility

always

Status

closed

Resolution

fixed

Platform

Microsoft

Windows

OS Version

XP/Vista/7

Product Version

1.3

Target Version

1.4

Fixed in Version

2.0

Summary

0001994: Adding +NOSKIN breaks skin scaling in SKININFO

Description

Basically if you have a "scale" set to any skin via SKININFO it won't register if the player has +NOSKIN

Steps To Reproduce

Go to any wad, compare the classes "bug" and "nobug".

The only difference between these two classes is that one has +NOSKIN and the other doesn't. "nobugplayer" has its' skin shrinked correctly because it doesn't have +NOSKIN. But "buggedplayer" will not scale because of +NOSKIN.

Additional Information

Hopefully this gets fixed soon, it would help a ton with a project I'm working on.

Attached Files

bugdemonstration.pk3 [^] (63,033 bytes) 2014-11-09 02:14

Relationships

Notes
(0011212) cobalt (updater) 2015-01-02 13:45	Issue addressed by commit 1199a4dae019: Fixed: The scale of skins enforced through Weapon.PreferredSkin was ignored if the player class had +NOSKIN (fixes 1994). Committed by Benjamin Berkels [Torr Samaho] on Friday 02 January 2015 14:40:37 Changes in files: docs/zandronum-history.txt \| 1 + src/p_user.cpp \| 3 ++- 2 files changed, 3 insertions(+), 1 deletions(-)

(0011213) Torr Samaho (administrator) 2015-01-02 13:48	Should be fixed now.

**Issue Community Support**
This issue is already marked as resolved. If you feel that is not the case, please reopen it and explain why.
Supporters:	No one explicitly supports this issue yet.
Opponents:	No one explicitly opposes this issue yet.

Issue History
Date Modified	Username	Field	Change
2014-11-09 02:11	Catastrophe	New Issue
2014-11-09 02:14	Dusk	File Added: bugdemonstration.pk3
2014-11-09 02:14	Dusk	Additional Information Updated	View Revisions
2015-01-02 13:21	Torr Samaho	Product Version	2.0-beta => 1.3
2015-01-02 13:26	Torr Samaho	Note Added: 0011211
2015-01-02 13:29	Torr Samaho	Note Deleted: 0011211
2015-01-02 13:44	cobalt	Assigned To	=> Torr Samaho
2015-01-02 13:44	cobalt	Status	new => needs testing
2015-01-02 13:44	cobalt	Target Version	=> 1.4
2015-01-02 13:44	cobalt	Steps to Reproduce Updated	View Revisions
2015-01-02 13:45	cobalt	Note Added: 0011212
2015-01-02 13:48	Torr Samaho	Note Added: 0011213
2015-03-29 20:21	Dusk	Status	needs testing => resolved
2015-03-29 20:21	Dusk	Fixed in Version	=> 2.0
2015-03-29 20:21	Dusk	Resolution	open => fixed
2018-09-30 22:59	Blzut3	Status	resolved => closed

Questions or other issues? Contact Us.

Links

Doom and Doom II are the property of id Software.