Zandronum Chat on our Discord Server Get the latest version: 3.1
Source Code
My View | View Issues | Change Log | Roadmap | Zandronum Issue Support Ranking | Rules | My Account
  

View Issue Details [ Jump to Notes ] [ Issue History ] [ Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0001907Zandronum[All Projects] Bugpublic2014-08-04 19:442018-09-30 21:35
ReporterKonar6 
Assigned ToBlzut3 
PriorityhighSeverityminorReproducibilityrandom
StatusclosedResolutionfixed 
PlatformOSOS Version
Product Version1.3 
Target Version1.3Fixed in Version1.3 
Summary0001907: Problems with the new huffman
DescriptionBeginning with the revision where the new huffman was introduced ('https://bitbucket.org/Torr_Samaho/zandronum/commits/109ab2dbc5fef9888b3733d6196b8379a2b0e6d2 [^]' ), the server->launcher messages sometimes seem to arrive corrupted - the launcher shows an absurd ping value, and in addition, the whole server info is corrupted in IDE as can be seen here ->'http://prntscr.com/48z8hu [^]'
Steps To ReproduceRefresh a 1.3 or 2.0 server in IDE or Doomseeker. The bug happens at random every 0000010:0000030-50 attempts.
Additional InformationSince there are 600+ servers on Zandronum, I anticipate this problem to become more apparent if not fixed until 1.3 is released.
Attached Files

- Relationships

-  Notes
User avatar (0010175)
Blzut3 (administrator)
2014-08-11 06:51

 Not having much luck reproducing this with a local server.
User avatar (0010178)
Konar6 (reporter)
2014-08-11 17:50

 I would suggest using IDE if you don't do already - it doesn't throttle refreshing. You can also turn on the Auto refresh feature in ServerInfo and wait. You will get to know that the bug occurred from the "average ping" value.

Several players have already spotted this bug just by refreshing the server list.
User avatar (0010187)
Torr Samaho (administrator)
2014-08-12 17:31
Quote from Konar6
the server->launcher messages sometimes seem to arrive corrupted
Since the server<->client communication appears to work flawlessly, I think it's more likely that Vortex Cortex' Huffman implementation is not 100% compatible with the old code.
User avatar (0010188)
Torr Samaho (administrator)
2014-08-12 18:40

 Looks as my suspicion is correct. I used the old implementation of HUFFMAN_Decode to decode messages encoded by Vortex Cortex's HUFFMAN_Encode while playing on a 2.0 server. I didn't do any statistics, but at first glance it seems that the new HUFFMAN_Encode is not compatible with the old HUFFMAN_Decode in more than 1% of the cases. In less than a minute of playtime there were dozens of mismatches when decoding the packets for the client<->server communication.

Either I'm doing something wrong in my tests or Vortex Cortex didn't really test the compatibility or something went wrong when Blzut3 replaced the old with the new Huffman implementation.
User avatar (0010191)
Blzut3 (administrator)
2014-08-12 21:29

 OK, that explains that. Of course if IDE is using the old code then bond is obligated by the GPL to release the source code to IDE. :P

I will investigate a bit since I don't recall Doomseeker having problems communicating with servers before the switch.
User avatar (0010202)
Blzut3 (administrator)
2014-08-14 10:53

 Pull request sent against Zandronum-stable.
User avatar (0010204)
Torr Samaho (administrator)
2014-08-14 17:27

 Thanks! Pulled and also merged with 2.0.
User avatar (0010346)
Dusk (developer)
2014-10-05 22:22

 Marking as resolved as 1.3 is now released.

Issue Community Support
This issue is already marked as resolved.
If you feel that is not the case, please reopen it and explain why.
Supporters: No one explicitly supports this issue yet.
Opponents: No one explicitly opposes this issue yet.

- Issue History
Date Modified Username Field Change
2014-08-04 19:44 Konar6 New Issue
2014-08-04 20:19 Torr Samaho Assigned To => Blzut3
2014-08-04 20:19 Torr Samaho Status new => assigned
2014-08-11 06:51 Blzut3 Note Added: 0010175
2014-08-11 17:50 Konar6 Note Added: 0010178
2014-08-12 17:31 Torr Samaho Note Added: 0010187
2014-08-12 18:40 Torr Samaho Note Added: 0010188
2014-08-12 21:29 Blzut3 Note Added: 0010191
2014-08-14 10:53 Blzut3 Note Added: 0010202
2014-08-14 10:53 Blzut3 Status assigned => needs review
2014-08-14 10:54 Blzut3 Product Version 2.0-beta => 1.3
2014-08-14 10:54 Blzut3 Target Version => 1.3
2014-08-14 17:27 Torr Samaho Note Added: 0010204
2014-08-14 18:29 Torr Samaho Status needs review => needs testing
2014-10-05 22:20 Dusk Fixed in Version => 1.3
2014-10-05 22:22 Dusk Note Added: 0010346
2014-10-05 22:22 Dusk Status needs testing => resolved
2014-10-05 22:22 Dusk Resolution open => fixed
2018-09-30 21:35 Blzut3 Status resolved => closed




Questions or other issues? Contact Us.

Links

Copyright © 2000 - 2024 MantisBT Team
Powered by Mantis Bugtracker