0001642: SBARINFO's gamemode detection is confusing

Notes
(0007913) Torr Samaho (administrator) 2014-01-07 20:16 edited on: 2014-01-07 20:17	After I backported Blzut3 ZDoom fix for this, Samsara 0.3 does work, but I get the warning: "Ignoring unknown gamemode Teamplay". I had a quick look at the SBARINFO code and it seems that "Teamplay" was never a valid gamemode for SBARINFO, even though the gamemode GAMEMODE_TEAMPLAY (aka team dm) exists.

(0007915) Blzut3 (administrator) 2014-01-07 21:15	Team DM is detectable through "TeamGame" since it's a ZDoom game mode and for some reason that's the identifier I picked for it. It's our custom team game mode that seems to be missing.

(0007917) Torr Samaho (administrator) 2014-01-08 07:09	I see. That's rather confusing if you look at our CVAR names. Do you have a suggestion to resolve this?

(0007918) Dusk (developer) 2014-01-08 11:16	Make a TeamDeathmatch alias for it, use CustomTeamGame for our teamgames and print a warning if TeamGame is used?

(0007919) Torr Samaho (administrator) 2014-01-08 18:06	In this case, code that is perfectly fine in ZDoom would generate a warning in Zandronum and it would be impossible to fix the warning without breaking ZDoom compatibility or at least generating a warning in ZDoom. This could be fixed by adding the TeamDeathmatch alias also to ZDoom.

(0007920) Dusk (developer) 2014-01-08 19:09	Another option would be to specifically name the teamgame "custom team game" all across the board on Zandronum, though this would require changing the CVAR (we're already forcing server hosts to update configs so this is not a problem) and changing strings. The change of meaning of "team game" to actually mean team deathmatch might come off confusing at first but honestly it's very confusing to begin with. If we add "custom" to the name we would provide some well needed clarity over what is what.

(0007921) Torr Samaho (administrator) 2014-01-08 21:21	Mods that rely on the value of the CVAR teamgame would break if we rename it, wouldn't they?

(0007922) Blzut3 (administrator) 2014-01-08 21:30	Right, I would just call the game customteamgame in SBarInfo and be done with it. No sense trying to clean up the confusion there since I'm not sure detecting the game mode outright is the best way to do things. Especially since we do support game mode configuration, gamemode needs to be extended to allow detecting what type of game (points? frags? teams?) is being played rather than what precisely is being played.

(0007923) Torr Samaho (administrator) 2014-01-08 21:55	Good point.

(0010990) Blzut3 (administrator) 2014-11-28 18:30	Changed the ticket information since after the first note it stopped being about backwards compatibility and it confused Dusk.

(0011240) Torr Samaho (administrator) 2015-01-03 15:20	customteamgame sounds like a reasonable compromise. Are you going to add it, Blzut3?

(0011311) Blzut3 (administrator) 2015-01-06 02:07	Marking as needs testing per:'https://bitbucket.org/Torr_Samaho/zandronum/commits/f5fa9ddda9f19c0f00942fd1ed2a89e440832d4c [^]' However, I would not consider that a complete solution to the issue, so after that change is confirmed working I recommend removing this ticket from 2.0 target instead of marking as resolved.

**Issue Community Support**
This issue is already marked as resolved. If you feel that is not the case, please reopen it and explain why.
Supporters:	No one explicitly supports this issue yet.
Opponents:	No one explicitly opposes this issue yet.

Issue Community Support

This issue is already marked as resolved.
If you feel that is not the case, please reopen it and explain why.

Supporters:

No one explicitly supports this issue yet.

Opponents:

No one explicitly opposes this issue yet.

Issue History
Date Modified	Username	Field	Change
2014-01-05 17:32	Torr Samaho	New Issue
2014-01-05 17:34	Torr Samaho	Note Added: 0007891
2014-01-05 17:34	Torr Samaho	Assigned To	=> Blzut3
2014-01-05 17:34	Torr Samaho	Status	new => assigned
2014-01-05 17:34	Torr Samaho	Product Version	=> 2.0-beta
2014-01-05 17:34	Torr Samaho	Target Version	=> 2.0
2014-01-05 17:35	Torr Samaho	Note Edited: 0007891
2014-01-07 20:16	Torr Samaho	Note Added: 0007913
2014-01-07 20:16	Torr Samaho	Note Deleted: 0007891
2014-01-07 20:17	Torr Samaho	View Status	private => public
2014-01-07 20:17	Torr Samaho	Note Edited: 0007913	View Revisions
2014-01-07 20:17	Torr Samaho	Note Revision Dropped: 7913: 0004381
2014-01-07 20:17	Torr Samaho	Note Revision Dropped: 7891: 0004364
2014-01-07 20:17	Torr Samaho	Note Revision Dropped: 7891: 0004365
2014-01-07 21:15	Blzut3	Note Added: 0007915
2014-01-08 07:09	Torr Samaho	Note Added: 0007917
2014-01-08 11:16	Dusk	Note Added: 0007918
2014-01-08 18:06	Torr Samaho	Note Added: 0007919
2014-01-08 19:09	Dusk	Note Added: 0007920
2014-01-08 21:21	Torr Samaho	Note Added: 0007921
2014-01-08 21:30	Blzut3	Note Added: 0007922
2014-01-08 21:55	Torr Samaho	Note Added: 0007923
2014-01-14 20:14	Dusk	Relationship added	child of 0001604
2014-01-14 20:15	Dusk	Relationship deleted	child of 0001604
2014-11-28 18:29	Blzut3	Summary	ZDoom 2.5.0's SBARINFO parser is not backwards compatible with the one from Zandronum 1.2 => SBARINFO's gamemode detection is confusing
2014-11-28 18:29	Blzut3	Description Updated	View Revisions
2014-11-28 18:30	Blzut3	Note Added: 0010990
2014-11-29 02:45	Blzut3	Priority	high => low
2014-11-29 02:45	Blzut3	Severity	major => minor
2015-01-03 15:20	Torr Samaho	Note Added: 0011240
2015-01-06 02:07	Blzut3	Note Added: 0011311
2015-01-06 02:07	Blzut3	Status	assigned => needs testing
2015-03-29 20:20	Dusk	Status	needs testing => resolved
2015-03-29 20:20	Dusk	Fixed in Version	=> 2.0
2015-03-29 20:20	Dusk	Resolution	open => fixed
2018-09-30 23:00	Blzut3	Status	resolved => closed

Relationships