0001526: Project cleanup: medal.cpp/.h

View Issue Details [ Jump to Notes ]

Project

Category

View Status

Date Submitted

Last Update

0001526

Zandronum

[All Projects] Suggestion

public

2013-09-29 19:50

2018-09-30 22:57

Reporter

Dusk

Assigned To

Dusk

Priority

normal

Severity

minor

Reproducibility

unable to reproduce

Status

closed

Resolution

fixed

Platform

OS Version

Product Version

Target Version

2.0

Fixed in Version

2.0

Summary

0001526: Project cleanup: medal.cpp/.h

Description

Removed code duplication, use FStrings over char arrays, corrected whitespace and suppressed gcc warnings.

'http://pastebin.com/LcEr1x6U [^]'

Relationships

Notes
(0007317) Torr Samaho (administrator) 2013-10-05 15:35	The patch looks fine. Since it doesn't fix any bugs, but is solely intended to improve the code quality, I suggest to add this to 2.0.

(0007391) Dusk (developer) 2013-10-13 09:24	Why to 2.0? If it's pushed to 1.3 we'll get less differences in medal.cpp and any bugfixes to the file in 1.3 would possibly cause less conflicts when merging to 2.0.

(0007393) Torr Samaho (administrator) 2013-10-13 09:46	As far I can tell, your cleanup is not intended to fix any issues with the behavior of the code, but is solely meant to increase the quality and future maintainability of the code. Changing proven code always risks introducing new issues (I have witnessed unexpected issues popping up with code rewrites often enough) and without getting something tangible in return (like a bug fix or new feature) I'd prefer not to risk 1.3's stability.

(0007394) Torr Samaho (administrator) 2013-10-13 11:06	Pulled and rebased.

**Issue Community Support**
This issue is already marked as resolved. If you feel that is not the case, please reopen it and explain why.
Supporters:	Toxicity
Opponents:	No one explicitly opposes this issue yet.

Links

Doom and Doom II are the property of id Software.